(learning jass) Help

[Sk8-tEr]

Event-A unit enters Jass region <gen>
Condtion-
Action-Create 1 footman for player 1 (red) at (center of(playable map area))

I converted it to custom text

function Trig_Enters_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), GetRectCenter(GetPlayableMapRect()), bj_UNIT_FACING )
endfunction

//===========================================================================
function InitTrig_Enters takes nothing returns nothing
    set gg_trg_Enters = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Enters, gg_rct_Jass_Region )
    call TriggerAddAction( gg_trg_Enters, function Trig_Enters_Actions )
endfunction

Then i tried to make a variable

function Trig_Enters_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), GetRectCenter(GetPlayableMapRect()), bj_UNIT_FACING )
endfunction

//===========================================================================
function InitTrig_Enters takes nothing returns nothing
    set gg_trg_Enters = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Enters, gg_rct_Jass_Region )
    call TriggerAddAction( gg_trg_Enters, function Trig_Enters_Actions )
    unit (entering unit) = A
endfunction

I tested but it didnt work... how do you make a variable?

 

[Viikuna]

function Trig_Enters_Actions takes nothing returns nothing
    local unit u=GetTriggerUnit() // This is the entering unit
    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), GetRectCenter(GetPlayableMapRect()), bj_UNIT_FACING )
    // Now you can do something to you unit:
    call KillUnit(u) // like kill it
    // you should null local handles in the end of the function:
    set u=null
endfunction

//===========================================================================
function InitTrig_Enters takes nothing returns nothing
    set gg_trg_Enters = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Enters, gg_rct_Jass_Region )
    call TriggerAddAction( gg_trg_Enters, function Trig_Enters_Actions )
    // nothing here, this function is only called at map
    // initialization
endfunction

 

[Sk8-tEr]

What do u mean null local handles?

 

[Flare]

Local variables that aren't of the following types:

• integer
• real
• boolean
• string
• code

Locals which are derived from the handle-type (e.g. unit, group, etc - anything that isn't in the list above, essentially) must be nulled. There are some handles which don't need to be nulled (since they aren't created/destroyed e.g. player), but there isn't any harm in doing it anyway AFAIK

 

[Viikuna]

If you dont null, you leak a handle.

 

[Sk8-tEr]

function Trig_Enter1_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), GetRectCenter(GetPlayableMapRect()), bj_UNIT_FACING )
    set u=null
    local unit u=get trigger unit
endfunction

//===========================================================================
function InitTrig_Enter1 takes nothing returns nothing
    set gg_trg_Enter1 = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Enter1, gg_rct_Jass_Region )
    call TriggerAddAction( gg_trg_Enter1, function Trig_Enter1_Actions )
endfunction

I nulled by setting u=null
And make get trigger unit what u is equal to
But i tested and trigger didnt work

 

[Flare]

Move the 'local unit u = ...' to the top of your function - local variables can only be declared at the top of a function

function Trig_Enter1_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit ()
    call CreateNUnitsAtLoc( 1, 'hfoo', Player(0), GetRectCenter(GetPlayableMapRect()), bj_UNIT_FACING )
    set u=null
endfunction

And make use of it - you could replace Player (0) with GetOwningPlayer (u)

 

[Sk8-tEr]

thx! it worked

function Trig_Enter1_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit ()
    call CreateNUnitsAtLoc( 1, 'hfoo', GetOwningPlayer (u) , GetRectCenter(GetPlayableMapRect()), bj_UNIT_FACING )
    set u = null
endfunction

//===========================================================================
function InitTrig_Enter1_Copy_2 takes nothing returns nothing
    set gg_trg_Enter1_Copy_2 = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Enter1_Copy_2, gg_rct_Jass_Region )
    call TriggerAddAction( gg_trg_Enter1_Copy_2, function Trig_Enter1_Actions )
endfunction

What does Get mean? getowningplayer
why does it Get something? shouldnt it be set or call?

 

[Flare]

call or set only needs to be used once per line (and only one or the other is used, unless it is a local declaration) - if you are using a function call as a function parameter (e.g. what you have there, using GetOwningPlayer in the CreateNUnitsAtLoc call), you don't need to add the call/set e.g.

function Sample takes nothing returns string
  return "Hello"
endfunction

function TestingSample takes nothing returns nothing
  local string str
  set str = Sample () //Setting a var to the returned value from the Sample function
  call BJDebugMsg (str) //Displaying a message using the variable
  call BJDebugMsg (Sample ()) //Displaying a message using the function call 
endfunction

And GetOwningPlayer (as the name suggests) retrieves the player 'value' for the player who owns the taken unit. If you have NewGen, you can use the Function List

 

[Vestras]

Remember that function names are case-sensitive.

 

[SFilip]

You really should consider reading a tutorial.

 

[Sk8-tEr]

I read the tutorial by trigger happy.... but it didn't explain much...

 

[Flare]

I read the tutorial by trigger happy.... but it didn't explain much...

Then read the ones that SFilip linked to, they are much better IMO

 

[Romek]

I read the tutorial by trigger happy.... but it didn't explain much...

Read one of the ones SFilip linked to.
They're much more professional, and explain things better.

 

[Sk8-tEr]

Thanks for the links, i started reading the third one
But where is the list of premade functions from the JASS editor?
What jass editor?

 

[WarLuvr3393]

If you DL JASSCraft or the NewGen editor, it gives you a whole list of functions/BJ's.

A "JASS Editor" is an editor which allows you to open ".j" files (JASS Files) and edit then so you can save and edit then later on.

Merry Christmas.

 

[Sk8-tEr]

Where could i dl this?

 

[WarLuvr3393]

Download JASS Craft

Here's the thread for the NewGen WE:

http://www.thehelper.net/forums/showthread.php?t=73936

*Use google, it's there for a reason.

 

[Azlier]

NewGen is magical.

EDIT: God, beaten by three seconds. I blame my popup blocker, it was giving me hyperlink problems

 

[Romek]

> A "JASS Editor" is an editor which allows you to open ".j" files (JASS Files)
Tried notepad?

NewGen and Jasscraft simply organize the functions into a nice list.