Spell Lightning Anger

[Flare]

That's freehand coding for you

 

[PurgeandFire]

I guess it might be faster, but in my opinion it isn't really too necessary to declare a local. The speed difference (if any) is so minimal, but I guess that is better primarily for organization.

 

[quraji]

Some stuff that can help it do less multiplication:

local real real1                   = GetUnitFacing(GetTriggerUnit())*bj_DEGTORAD

local real x2 = x + 300 * Cos(real1 + 2.531)
local real y2 = y + 300 * Sin(real1 + 2.531)

local real x3 = x + 300 * Cos(real1 + 3.142)
local real y3 = y + 300 * Sin(real1 + 3.142)

local real x4 = x + 300 * Cos(real1 + 3.752)
local real y4 = y + 300 * Sin(real1 + 3.752)

Because it is doing the radians of the facing + the radians of the numbers you have. A little less math for the machine.

A little less math for the machine:

local real real1 = GetUnitFacing(GetTriggerUnit())* .017453
local real newx = x + 300
local real newy = y + 300

local real x2 = newx * Cos(real1 + 2.531)
local real y2 = newy * Sin(real1 + 2.531)

local real x3 = newx * Cos(real1 + 3.142)
local real y3 = newy * Sin(real1 + 3.142)

local real x4 = newx * Cos(real1 + 3.752)
local real y4 = newy * Sin(real1 + 3.752)

Just to be an ass I guess...mwahahahaha.

Oh, and cool looking spell, good job

 

[Flare]

local real newx = x + 300
local real newy = y + 300

local real x2 = newx * Cos(real1 + 2.531)
local real y2 = newy * Sin(real1 + 2.531)

Would that even work???
If you take the initial X value to be 10, and the result of the Cos to be 0.5 (for example)

10 + 300 = 310
310 * 0.5 = 155
BUT
10 + 300*0.5 = 10 + 150
10 + 150 = 160

the result is out a bit (would be worse if the x (or y) value was much greater)

Example 2 (with a bigger number!)

init X: 100
Cos (val) = 0.5 again

100 + 300 = 400
400*0.5 = 200
BUT
100 + 300*0.5 = 100 + 150
100 + 150 = 250

your out 50 on the X in that example, going by ur calculations

and if the original X/Y was a number >= 1000? that could put ur calculation off by about 500, i think

in the end
A + (B * C) != (A + B) * C

 

[quraji]

You caught me
I was just trying to be an ass, not really suggesting an improvement hehe.
But you're absolutely right that it wouldn't work as intended, I think you deserve rep for catching it!

 

[AdamGriffith]

Channels up elektricity to then send it out in form of a giant electricity ball towards your enemy. The electricity ball will follow the target untill it reaches it's goal. When hit the electricity ball will shock all enemies within range of the target dealing damage.

I think someone can't spell electricity consistently!

I think I already left a comment about this spell, from what I remember it was good! (Y)

 

[Kazuga]

Ye I hate that word, I always misspell it^^

 

[PureOwnage]

Nice spell. :thup:

OFFTOPIC: To many bumps

 

[Ghostwind]

Holy shit, 9-tuple post!

 

[Kazuga]

No not really, you may bump every 24 hours and the spell has been up for around a month or so.

 

[Andrewgosu]

Code seems fluent and non-leaking.

Resource approved.

 

[CaptDeath]

you know its electricity don't you?

 

[Kazuga]

you know its electricity don't you?

What do you mean by that?

 

[Trollvottel]

Channels up elektricity to then send it out in form of a giant electricity ball towards your enemy. The electricity ball will follow the target untill it reaches it's goal. When hit the electricity ball will shock all enemies within range of the target dealing damage.

->...

 

[Kazuga]

->...

It's just an example to describe what it does... If you have any better suggestions please post them here so I can change it.

 

[Larcenist]

Channels up elektricity to then send it out in form of a giant electricity ball towards your enemy. The electricity ball will follow the target untill it reaches it's goal. When hit the electricity ball will shock all enemies within range of the target dealing damage.

I'm pretty sure that's what Troll was clarifying.

 

[GetTriggerUnit-]

Broken due to TT & TimedLightnings.

 

[Sim]

Wow. My WE hraphically crashed badly when I opened this

Thanks!

Naturally, if the author is to fix these spells, they will most probably be approved once again!

 

[Weep]

Broken due to TT & TimedLightnings.

Isn't it due to HAIL, not TT nor TimedLightnings?