Need help with an easy JASS script :P

[jomik]

Hey, I'm new to coding in JASS, and I'm trying to convert my GUI triggers to JASS, and optimize them a bit, or write them in another way than the GUI converter thingy does. I just ran into a problem here in this script:

• Init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Visibility - Disable black mask
    • Player Group - Make (All players) treat (All players) as an Ally
    • Set temp_player = (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User)))
    • Player Group - Pick every player in temp_player and do (Actions)
      • Loop - Actions
        • Player Group - Add (Picked player) to farmers
        • Player - Set (Picked player) Current gold to 80
        • Player - Set (Picked player) Current lumber to 20
        • Unit - Create 1 Farmer for (Picked player) at ((Picked player) start location) facing Default building facing degrees
    • Custom script: call DestroyForce(udg_temp_player)
    • Player - Set Player 12 (Brown) Current gold to 1000

I'm writing it in JASS like this:

function setstuff takes nothing returns nothing
    call SetPlayerStateBJ(GetEnumPlayer(), PLAYER_STATE_RESOURCE_GOLD, 80)
    call SetPlayerStateBJ(GetEnumPlayer(), PLAYER_STATE_RESOURCE_LUMBER, 20)
    call CreateNUnitsAtLoc(1, 'H001', GetEnumPlayer(), GetPlayerStartLocationLoc(GetEnumPlayer()), bj_UNIT_FACING)
endfunction

function actions takes nothing returns nothing
    local force p
    call FogMaskEnable(false)
    call SetForceAllianceStateBJ(GetPlayersAll(), GetPlayersAll(), bj_ALLIANCE_ALLIED)
    set p = GetPlayersMatching(GetBooleanAnd(GetPlayerSlotState(GetFilterPlayer()) == PLAYER_SLOT_STATE_PLAYING, GetPlayerController(GetFilterPlayer()) == MAP_CONTROL_USER))        
    call ForForce(p, function setstuff)
    call DestroyForce(p)
    set p = null
    call SetPlayerStateBJ(Player(11), PLAYER_STATE_RESOURCE_GOLD, 1000)
endfunction

But there's some error in the set p = GetPlayersMatching(...)
Please help me out >.<
Thanks in advance

 

[kingkingyyk3]

scope MapInit initializer Init

    globals
        player P
    endglobals
    
    private function ActiveHumanPlayers takes nothing returns boolean
        return GetPlayerSlotState(GetFilterPlayer()) == PLAYER_SLOT_STATE_PLAYING and GetPlayerController(GetFilterPlayer()) == MAP_CONTROL_USER
    endfunction
    
    function GiveGoldAndUnit takes nothing returns nothing
        set P = GetEnumPlayer()
        call SetPlayerState(P, PLAYER_STATE_RESOURCE_GOLD, 80)
        call SetPlayerState(P, PLAYER_STATE_RESOURCE_LUMBER, 20)
        call CreateUnit(P, 'H001', GetPlayerStartLocationX(P), GetPlayerStartLocationY(P), 270.)
    endfunction

    function Init takes nothing returns nothing
        local force f = CreateForce()
        call FogMaskEnable(false)
        call ForceEnumPlayers(f,Condition(function ActiveHumanPlayers)) 
        call SetForceAllianceStateBJ(f, f, bj_ALLIANCE_ALLIED)
        call ForForce(f, function GiveGoldAndUnit)
        call DestroyForce(f)
        set f = null
        
        call SetPlayerState(Player(11), PLAYER_STATE_RESOURCE_GOLD, 1000)
    endfunction

endscope

 

[jomik]

Oh, thanks for the quick answer! Would you mind explaining it though? >.< I'm new to JASS as I said What's the scope?
And the ForceEnumPlayers?
And for the SetForceAllianceStateBJ , I wanted all players to be allied, also the computer controlled ~

 

[kingkingyyk3]

scope
vJass candy. It is hard to explain. Refer to Jasshelper's manual.

ForceEnumPlayers
This functions check all players, if the condition is true, add the player to force.

And for the SetForceAllianceStateBJ , I wanted all players to be allied, also the computer controlled
Sorry. You can use ForceEnumPlayers to add all players in force, by using return true function.

function ReturnTrue takes nothing returns boolean
    return true
endfunction

 

[jomik]

Hmm, I can just use call ForceEnumPlayers(f, true)? I have to make a function for it? And do you have a link for vJASS and how to set it up and stuff?

 

[Romek]

@ kingkingyyk3:
Giving people who don't understand vJass, random vJass code isn't going to help them or teach them anything. Explain what you're doing, and why. If you cannot do these, you might as well not post your improved code.

I'd suggest reading this if you're new to JASS.

 

[kingkingyyk3]

Hmm, I can just use call ForceEnumPlayers(f, true)?
According functions list

native ForceEnumPlayer takes force whichForce, boolexpr whichBoolexpr returns nothing

"true" is a boolean.
Condition(*A function that returns boolean*) is a boolexpr.
You can only substitute correct type into the function or the complier will give you error.

 

[jomik]

@ Romek, yeah I did read that, but I dunno how I can implement vJASS still It doesn't tell that anywhere. Got anything that can help me there?

@ kingkingyyk3, Thanks I think I get it now, and how it works, now I just need to find the vJASS thingy, I might aswell learn to use vJASS from the beginning

 

[kingkingyyk3]

Click Me to open NewGen page.
Click Me to open Jasshelper, vJass complier page.

 

[jomik]

Tyvm dude +rep to both of you for helping me out