Spellpack Nuke, Flame Storm, Blink Back, Fade Run

Prometheus

Everything is mutable; nothing is sacred
Reaction score
590
Well, care to explain please? I can't figure it out myself.
 

emjlr3

Change can be a good thing
Reaction score
395
when the caster begins some animation, create dummy units that you will use and have them display the same animation

when needed, move them to the correct spot, display them and freeze em
 

Romek

Super Moderator
Reaction score
964
Each of your spells need descriptions before this can be approved.
You need at least one screenshot for this to be approved - For the spells index.
Would be appreciated if that image was 256x256 pxls. :)

Nuke:
I suggest making DMG a configurable function instead of a global which is multiplied by the level.

JASS:
set SOUND = gg_snd_nuclear

gg_snd_nuclear is buried deep within that code.
How about:
JASS:
//constants
private constant string SOUNDPATH = "Some\\Path"

// Init Function
set Sound = CreateSoundFilenameWithLabel(SOUNDPATH, ..., ..)

Notice how Sound, a non-constant global isn't in all-caps.
You can also get rid of that timer you create at init like this.

Quit destroying the group, and make it a global group, which is created at init, and never destroyed.
I don't see you destroying the timer you create dynamically.
Infact, you shouldn't destroy timers. How about replacing AncientData with TimerUtils?

Locations are so GUI. :p

DistanceBetweenPoints could be set to a variable, as you're using it twice.
Though you could remove it by not using locations.

You don't null 't' in NukeAct.

You don't destroy your struct.

JASS:
method DmgE ...

Why?

JASS:
call UnitDamagePoint (..)

Desyncs on Macs. Get rid of realistic. It's simpler to just make them 'return true' in the filter.

Configurable?

It'd also be better if the sound was 3D.​


Flame Storm
Same DMG stuff applies here as the previous spell.

JASS:
[4]
Configurable?

Configurable?

As with before, locations are too GUI for Jass. :p
Your code will be more efficient, and you'd get rid of most of those BJs. They're all crappy, location-based ones.

Your function names suck.


Set those to variables. You're calling them each 4 times.

JASS:
.
        set a.ticker = a.ticker + TT_PERIOD * 100
        if a.ticker == TIME * 100 then

Why the *100? o_O


Desyncs.

I thought I'd mention here that basically all of these points should be repeated about 50 times. Especially the BJs and locations. They're fugly.​

I didn't bother looking at the rest, as I bet all of these points will be repeated again.
Fix these up, and I'll look over it all again.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top