cleeezzz
The Undead Ranger.
- Reaction score
- 268
SOLVED
you can skip the huge If/then/else statement but just take notice that it creates a dummy to damage the unit. using this one code, i was hoping, it would add the damage together using a struct (this has worked before in 2 separate triggers but now that its combined, it seems like the damage is too fast for the struct to be created). so when the unit takes damage from a unit with a certain item, and receives bonus damage, it happens so fast that it doesn't register that the struct has been created. do i have to keep it as 2 separate triggers? because it helps a lot to keep it in one.
EDIT: this might not even be a PUI problem, maybe its just the struct isnt' being created fast enough between the 2 damages.
EDIT2: OMFG. turns out the order was mixed up, i should have swapped the two if/then/else because damage was given to the unit before the struct was even created. alsdkldsfjk
JASS:
scope UTD initializer Init
globals
private unit Caster = null
private unit dummy = null
endglobals
private function Filter1 takes nothing returns boolean
local real x = GetUnitX(GetFilterUnit())
local real y = GetUnitY(GetFilterUnit())
return IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(Caster)) and GetWidgetLife(GetFilterUnit())>0.405 and IsTerrainPathable( x, y, PATHING_TYPE_FLOATABILITY) == false
endfunction
//=======================================================================
private struct Data
//! runtextmacro PUI()
unit u
unit d
real dmg
timer t
boolean critical
private method onDestroy takes nothing returns nothing
set .u = null
set .d = null
call ReleaseTimer(.t)
endmethod
endstruct
private function showtxt takes nothing returns nothing
local Data d = GetCSData(GetExpiredTimer())
local texttag txt = CreateTextTag()
local real x = GetUnitX(d.u)
local real y = GetUnitY(d.u)
local integer i = 0
call SetTextTagText( txt, "|c00FF0000" + "-" + I2S(R2I(d.dmg)) + "|r" , 0.023 )
call SetTextTagPos ( txt, x, y, 150)
call SetTextTagVelocity( txt, (64 * 0.071 / 128) * Cos(90 * 3.14/180 ) , (64 * 0.071 / 128) * Sin(90 * 3.14/180 ) )
call SetTextTagPermanent( txt, false )
call SetTextTagLifespan( txt, 1.70 )
call SetTextTagFadepoint( txt, 1.00 )
if (IsFoggedToPlayer( x, y, GetLocalPlayer()) or IsMaskedToPlayer( x, y, GetLocalPlayer())) and GetLocalPlayer() != GetOwningPlayer(d.d) then
call SetTextTagVisibility( txt, false)
endif
set txt = null
set d.dmg = 0
call d.release()
endfunction
private function Actions takes nothing returns nothing
local unit u = GetTriggerUnit()
local unit ds = GetEventDamageSource()
local unit c = Hero[GetPlayerId(GetOwningPlayer(ds))]
local real x = GetUnitX(u)
local real y = GetUnitY(u)
local real x1
local real y1
local real x2
local real y2
local group g = CreateGroup()
local integer i
local integer n
local Data d = Data<u> //sets data of the unit
if GetUnitTypeId(ds) != 'h00A' then //ignore this huge IF and scroll down to the next comment, this code just adds bonus dmg
set Caster = ds
set dummy = CreateUnit( GetOwningPlayer(c), 'h00A', x, y, 0 )
set n = ItemCheck( c, 'I00M')
call UnitDamageTarget( dummy, u, 75.00 * I2R(n) , false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null )
set n = ItemCheck( c, 'I005')
set n = ItemCheck( c, 'I00G') + n
set n = ItemCheck( c, 'I00J') + n
set n = ItemCheck( c, 'I00F') + n
call UnitDamageTarget( dummy, u, 25.00 * I2R(n) , false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null )
set dummy = null
if ItemCheck( ds, 'I00V') >= 1 then
set dummy = CreateUnit( GetOwningPlayer(ds), 'h00A', x, y, 0 )
call UnitDamageTarget( dummy, u, 25.00 , false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null )
call UnitAddAbility(dummy, 'A00I')
call UnitApplyTimedLife( dummy, 'BTLF', 2.00 )
call IssueTargetOrder( dummy, "frostnova", u )
if IsTerrainPathable ( x, y, PATHING_TYPE_FLOATABILITY) == false or UnitHasBuffBJ( u, 'B005') == true then
call UnitAddAbility(dummy, 'A01M')
call IssueTargetOrder( dummy, "thunderbolt", u )
endif
endif
set dummy = null
if ItemCheck( ds, 'I00X') >= 1 then
call DestroyEffect( AddSpecialEffectTarget( "Abilities\\Spells\\Other\\Monsoon\\MonsoonBoltTarget.mdl", GetTriggerUnit(),"origin"))
set dummy = CreateUnit( GetOwningPlayer(ds), 'h00A', x, y, 0 )
call UnitDamageTarget( dummy, u, 25.00, false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null )
call UnitApplyTimedLife( dummy, 'BTLF', 2.00 )
call UnitDamageTarget( dummy, u, 100.00, false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null )
if IsTerrainPathable ( x, y, PATHING_TYPE_FLOATABILITY) == false then
call GroupEnumUnitsInRect( g, bj_mapInitialPlayableArea, Condition( function Filter1))
call ForGroup( g, function CB)
endif
call DestroyGroup(g)
set g = null
endif
set dummy = null
if ItemCheck( ds, 'I00W') >= 1 then
set dummy = CreateUnit ( GetOwningPlayer(ds), 'h009', x1, y1, 18.00 * I2R(i))
call UnitDamageTarget( dummy, u, 25.00, false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null )
call UnitApplyTimedLife( dummy, 'BTLF', 4.00)
if IsTerrainPathable ( x, y, PATHING_TYPE_FLOATABILITY) == true then
set i = 1
loop
exitwhen i > 20
set x1 = PolarProjectionX( x, 200.00, 18.00 * I2R(i))
set y1 = PolarProjectionY( y, 200.00, 18.00 * I2R(i))
set x2 = PolarProjectionX( x, 250.00, 18.00 * I2R(i))
set y2 = PolarProjectionY( y, 250.00, 18.00 * I2R(i))
set dummy = CreateUnit ( GetOwningPlayer(GetEventDamageSource()), 'h009', x1, y1, 18.00 * I2R(i))
call UnitApplyTimedLife( dummy, 'BTLF', 4.00)
call IssuePointOrder( dummy, "breathoffire", x2, y2 )
set i = i + 1
endloop
endif
endif
endif
if d == 0 then // The important part starts here.
call BJDebugMsg("HI")
set d = Data.create()
set d.u = u
set d.d = GetEventDamageSource()
set d.dmg = 0
set d.t = NewTimer()
set Data<u> = d
call TimerStart(d.t, 0.10, false, function showtxt)
call SetCSData(d.t,d)
else
call BJDebugMsg("HI2")
call PauseTimer(d.t)
call TimerStart(d.t, 0.10, false, function showtxt)
endif
set d.dmg = d.dmg + GetEventDamage()
set u = null
set ds = null
set dummy = null
endfunction
private function Conditions takes nothing returns boolean
if GetEventDamage() > 0 then
return true
endif
return false
endfunction
//===========================================================================
private function Init takes nothing returns nothing
set UTD = CreateTrigger( )
call TriggerAddCondition(UTD, Condition(function Conditions))
call TriggerAddAction( UTD, function Actions )
endfunction
endscope</u></u>you can skip the huge If/then/else statement but just take notice that it creates a dummy to damage the unit. using this one code, i was hoping, it would add the damage together using a struct (this has worked before in 2 separate triggers but now that its combined, it seems like the damage is too fast for the struct to be created). so when the unit takes damage from a unit with a certain item, and receives bonus damage, it happens so fast that it doesn't register that the struct has been created. do i have to keep it as 2 separate triggers? because it helps a lot to keep it in one.
EDIT: this might not even be a PUI problem, maybe its just the struct isnt' being created fast enough between the 2 damages.
EDIT2: OMFG. turns out the order was mixed up, i should have swapped the two if/then/else because damage was given to the unit before the struct was even created. alsdkldsfjk
