Servere Lag after a few casts of my skill.

F

Fujiwari

Active Member
Reaction score
0
Trigger:
  • Frigid Grasp
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Frigid Grasp
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of Frigid Grasp for (Casting unit)) Equal to 1
        • Then - Actions
          • Unit Group - Pick every unit in (Units within 600.00 of (Position of (Casting unit))) and do (Actions)
            • Loop - Actions
              • Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
              • Unit - Add Frigid Grasp (Dummy Unit Version) to (Last created unit)
              • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
              • Unit - Set level of Frigid Grasp (Dummy Unit Version) for (Last created unit) to 1
              • Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)
        • Else - Actions
          • Do nothing
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of Frigid Grasp for (Casting unit)) Equal to 2
        • Then - Actions
          • Unit Group - Pick every unit in (Units within 600.00 of (Position of (Casting unit))) and do (Actions)
            • Loop - Actions
              • Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
              • Unit - Add Frigid Grasp (Dummy Unit Version) to (Last created unit)
              • Unit - Set level of Frigid Grasp (Dummy Unit Version) for (Last created unit) to 2
              • Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)
              • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Else - Actions
          • Do nothing
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of Frigid Grasp for (Casting unit)) Equal to 3
        • Then - Actions
          • Unit Group - Pick every unit in (Units within 600.00 of (Position of (Casting unit))) and do (Actions)
            • Loop - Actions
              • Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
              • Unit - Add Frigid Grasp (Dummy Unit Version) to (Last created unit)
              • Unit - Set level of Frigid Grasp (Dummy Unit Version) for (Last created unit) to 3
              • Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)
              • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Else - Actions
          • Do nothing
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of Frigid Grasp for (Casting unit)) Equal to 4
        • Then - Actions
          • Unit Group - Pick every unit in (Units within 600.00 of (Position of (Casting unit))) and do (Actions)
            • Loop - Actions
              • Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
              • Unit - Add Frigid Grasp (Dummy Unit Version) to (Last created unit)
              • Unit - Set level of Frigid Grasp (Dummy Unit Version) for (Last created unit) to 4
              • Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)
              • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Else - Actions
          • Do nothing


I read a guide on hiveworkshops about how to do AOE skills. The skill I made here looks fine but after 5 - 6 casts the whole game lags up really bad.

Thinking "what the heck happened?" I changed my dummy model to a little zerg to see if the dummy units dies properly. It does. I keep doing so and until the 5th cast, the models of my target and the dummy are messed up (Kind of stretched) and it lags the game everytime I view that area.

There are no longer dummy units there but I have no idea why it is still lagging. Any help?
 
Nenad

Nenad

~Choco Coronet~ Omnomnom
Reaction score
137
It's because you have a lot of memory leaks X)

Set TempPoint = Position of (Casting Unit)
Set TempGroup = Units within 600.00 of (TempPoint)
Then - Actions

* Unit Group - Pick every unit in (TempGroup) and do (Actions)

call DestroyGroup(udg_TempGroup)
call RemoveLocation(udg_TempPoint)

This is how you're trigger should look like for groups.
Someone fix the syntax in the memory leak removal if it's wrong please, been a while since i done it ^^

Also i'm unsure that units within 600 will leak as well...

Edit: Also remove all the do nothing actions, you don't need them.
 
F

Fujiwari

Active Member
Reaction score
0
Nenad said:
It's because you have a lot of memory leaks X)

Set TempPoint = Position of (Casting Unit)
Set TempGroup = Units within 600.00 of (TempPoint)
Then - Actions

* Unit Group - Pick every unit in (TempGroup) and do (Actions)

call DestroyGroup(udg_TempGroup)
call RemoveLocation(udg_TempPoint)

This is how you're trigger should look like for groups.
Someone fix the syntax in the memory leak removal if it's wrong please, been a while since i done it ^^

Also i'm unsure that units within 600 will leak as well...

Edit: Also remove all the do nothing actions, you don't need them.
Click to expand...

Thank you! I'll try it out now.
 
F

Fujiwari

Active Member
Reaction score
0
Trigger:
  • Frigid Grasp
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Frigid Grasp
    • Actions
      • Set TempPoint = (Position of (Casting unit))
      • Set TempGroup = (Units within 512.00 of TempPoint matching (((Picked unit) is A structure) Equal to False))
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of Frigid Grasp for (Casting unit)) Equal to 1
        • Then - Actions
          • Unit Group - Pick every unit in TempGroup and do (Actions)
            • Loop - Actions
              • Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at TempPoint facing Default building facing degrees
              • Unit - Add Frigid Grasp (Dummy Unit Version) to (Last created unit)
              • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
              • Unit - Set level of Frigid Grasp (Dummy Unit Version) for (Last created unit) to 1
              • Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)
              • Custom script: call DestroyGroup(udg_TempGroup)
              • Custom script: call RemoveLocation(udg_TempPoint)


Is it supposed to look like this? Now my skill won't function at all lol... Sorry I'm really a novice at this.
 
vypur85

vypur85

Hibernate
Reaction score
803
You guys and leaks again... If leaks can cause lag in 5 casts, then something must be very wrong with your computer.

The lag is caused by amounts of dummies produced. You pick ALL units without filtering them. Imagine, at first cast, you created 10 dummies. The next cast, you will produce 20 dummies... and so on. Without filtering, the unit group will pick up dead units as well, and the number goes up exponentially.


Code: 
 Frigid Grasp
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Frigid Grasp 
    Actions
        Unit Group - Pick every unit in (Units within 600.00 of (Position of (Casting unit))) matching [B](Matching unit) is alive Equal to True and (Matching unit) belongs to an enemy of (Owner of Triggering unit)) [/B]and do (Actions)
            Loop - Actions
               Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
               Unit - Add Frigid Grasp (Dummy Unit Version)  to (Last created unit)
               Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
               Unit - Set level of Frigid Grasp (Dummy Unit Version)  for (Last created unit) to [B](Level of Frigid Grasp for (Triggering unit))[/B]
               Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)

Look out for the bolded areas. Then again, I'm assuming the ability only works on enemies, otherwise, just change the 'matching' part as needed. As for the leak, just change accordingly as adviced.
 
F

Fujiwari

Active Member
Reaction score
0
vypur85 said:
You guys and leaks again... If leaks can cause lag in 5 casts, then something must be very wrong with your computer.

The lag is caused by amounts of dummies produced. You pick ALL units without filtering them. Imagine, at first cast, you created 10 dummies. The next cast, you will produce 20 dummies... and so on. Without filtering, the unit group will pick up dead units as well, and the number goes up exponentially.


Code: 
 Frigid Grasp
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Frigid Grasp 
    Actions
        Unit Group - Pick every unit in (Units within 600.00 of (Position of (Casting unit))) matching [B](Matching unit) is alive Equal to True and (Matching unit) belongs to an enemy of (Owner of Triggering unit)) [/B]and do (Actions)
            Loop - Actions
               Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
               Unit - Add Frigid Grasp (Dummy Unit Version)  to (Last created unit)
               Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
               Unit - Set level of Frigid Grasp (Dummy Unit Version)  for (Last created unit) to [B](Level of Frigid Grasp for (Triggering unit))[/B]
               Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)

Look out for the bolded areas. Then again, I'm assuming the ability only works on enemies, otherwise, just change the 'matching' part as needed. As for the leak, just change accordingly as adviced.
Click to expand...

Ignore what I posted above, I heed both your advices and my skill now works smoothly. Thank you! :thup:
 
MiddleHanded

MiddleHanded

New Member
Reaction score
1
I'll just post a quick thing to optimize the length a little...
I hope it doesn't cause more leaks :D

Trigger:
  • Frigid Grasp
    • Events
    • Unit - A unit Starts the effect of an ability
    • Conditions
    • (Ability being cast) Equal to Frigid Grasp
    • Actions
    • Set TempPoint = (Position of (Casting unit))
    • Set TempGroup = (Units within 600.00 of TempPoint matching (((Matching unit) is A structure) Equal to False))
    • Unit Group - Pick every unit in TempGroup and do (Actions)
    • Loop - Actions
    • Unit - Create 1 Dummy Spellcaster (For Skills) for (Owner of (Casting unit)) at TempPoint facing Default building facing degrees
    • Unit - Add Frigid Grasp (Dummy Unit Version) to (Last created unit)
    • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
    • Unit - Set level of Frigid Grasp (Dummy Unit Version) for (Last created unit) to (Level of Frigid Grasp for Triggering unit)
    • Unit - Order (Last created unit) to Neutral - Firebolt (Picked unit)
    • Custom script: call DestroyGroup(udg_TempGroup)
    • Custom script: call RemoveLocation(udg_TempPoint)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Staff online

      Members online

      Online now:
      68 (members: 1, guests: 67)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top