Simple Question! About ForgroupBJ and its parametes

[newtonrox]

when you call ForGroupBJ(group, function)

can your "function" have parameters? like:

call ForGroupBJ( udg_ALLMAP, Trig_Add_skill(Dummy, Item) )

 

[Komaqtion]

No, this isn't allowed... This is a shame, as it'd help ALOT !
You best way is to use globals...

 

[Narks]

the function must not take any arguments or return anything

so the function you are calling should look like this:

function A takes nothing returns nothing
endfunction

function B takes unit u returns nothing
endfunction

function C takes nothing returns boolean
endfunction

function main takes nothing returns nothing
    local group MyGroup = CreateGroup()
    call ForGroup(MyGroup, function A) // valid
    call ForGroup(MyGroup, function B) // not valid, function B has arguments
    call ForGroup(MyGroup, function C) // not valid, function C returns a value
endfunction

 

[newtonrox]

thank you guys!


i could not believe that this was the mistake i was making...
the editor did not let me compile XD

and i agree! that rly would help us alot

globals ftw -.-"


one more question:

is it better to use GetLastCreatedUnit() or a global?
the global would be overwritten if two ppl used my spell at the same time? if so, what's the point of using a global instead of GetLastCreatedUnit()?
can that lead me to an error?

 

[Komaqtion]

No, there is no chance of this happening, as triggers use the same thread, and pile up in a line, so if there is no wait in a trigger, it won't overlap with another trigger

Just set the unit to a global variable and you're good

 

[newtonrox]

thanks again komagtion!