[Spell Request] JASS

zoidbergZA · May 28, 2009

hi guys, i've got a spell made in GUI that is a channeling ability but that isn't MUI. i have just started to try and learn JASS but i still find it very difficult. If anybody can make this ability MUI i would really appreciate it.

The spell is channeling, it boosts the life of the target by 5% of the caster's max HP per second. 4 levels increases the duration per level. i used the "channel" ability as a base and dummy units to get the desired channel effect.

Trigger:

turn on
- Events
  - Unit - A unit Begins channeling an ability
- Conditions
  - (Ability being cast) Equal to Boost Life
- Actions
  - Unit - Create 1 channel dummy for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
  - Set ability_boost_life1[1] = (Last created unit)
  - Unit - Create 1 channel dummy for Player 8 (Pink) at (Position of (Target unit of ability being cast)) facing Default building facing degrees
  - Set ability_boost_life1[2] = (Last created unit)
  - Set ability_boost_life1[3] = (Casting unit)
  - Set ability_boost_life1[4] = (Target unit of ability being cast)
  - Unit - Add channel effect to ability_boost_life1[1]
  - Unit - Order ability_boost_life1[1] to Human Blood Mage - Siphon Mana ability_boost_life1[2]
  - Special Effect - Create a special effect attached to the overhead of ability_boost_life1[4] using Abilities\Spells\Other\Drain\DrainCaster.mdl
  - Set ability_boost_life2 = (Last created special effect)
  - Trigger - Turn on timed actions <gen>
  - Trigger - Turn on turn off <gen>

Trigger:

timed actions
- Events
  - Time - Every 0.10 seconds of game time
- Conditions
- Actions
  - Unit - Move ability_boost_life1[2] instantly to (Position of ability_boost_life1[4])
  - Unit - Set life of ability_boost_life1[4] to ((Life of ability_boost_life1[4]) + ((Max life of ability_boost_life1[3]) / 200.00))

Trigger:

turn off
- Events
  - Unit - A unit Stops casting an ability
- Conditions
  - ((Ability being cast) Equal to channel effect ) or ((Ability being cast) Equal to Boost Life )
- Actions
  - Trigger - Turn off timed actions <gen>
  - Unit - Remove ability_boost_life1[1] from the game
  - Unit - Remove ability_boost_life1[2] from the game
  - Unit - Order ability_boost_life1[3] to Stop
  - Special Effect - Destroy ability_boost_life2

Exide · May 28, 2009

I don't have WE or JassCraft with me, so I can't help you. But I can tell you that it's easier to help you if you convert your triggers to custom text first. (Even though GUI -> JASS = Horrible.)

zoidbergZA · May 28, 2009

JASS:

function Trig_turn_on_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == &#039;A003&#039; ) ) then
        return false
    endif
    return true
endfunction

function Trig_turn_on_Actions takes nothing returns nothing
    call CreateNUnitsAtLoc( 1, &#039;h00D&#039;, GetOwningPlayer(GetSpellAbilityUnit()), GetUnitLoc(GetSpellAbilityUnit()), bj_UNIT_FACING )
    set udg_ability_boost_life1[1] = GetLastCreatedUnit()
    call CreateNUnitsAtLoc( 1, &#039;h00D&#039;, Player(7), GetUnitLoc(GetSpellTargetUnit()), bj_UNIT_FACING )
    set udg_ability_boost_life1[2] = GetLastCreatedUnit()
    set udg_ability_boost_life1[3] = GetSpellAbilityUnit()
    set udg_ability_boost_life1[4] = GetSpellTargetUnit()
    call UnitAddAbilityBJ( &#039;A004&#039;, udg_ability_boost_life1[1] )
    call IssueTargetOrderBJ( udg_ability_boost_life1[1], &quot;drain&quot;, udg_ability_boost_life1[2] )
    call AddSpecialEffectTargetUnitBJ( &quot;overhead&quot;, udg_ability_boost_life1[4], &quot;Abilities\\Spells\\Other\\Drain\\DrainCaster.mdl&quot; )
    set udg_ability_boost_life2 = GetLastCreatedEffectBJ()
    call EnableTrigger( gg_trg_timed_actions )
    call EnableTrigger( gg_trg_turn_off )
endfunction

//===========================================================================
function InitTrig_turn_on takes nothing returns nothing
    set gg_trg_turn_on = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_turn_on, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_turn_on, Condition( function Trig_turn_on_Conditions ) )
    call TriggerAddAction( gg_trg_turn_on, function Trig_turn_on_Actions )
endfunction

JASS:

function Trig_timed_actions_Actions takes nothing returns nothing
    call SetUnitPositionLoc( udg_ability_boost_life1[2], GetUnitLoc(udg_ability_boost_life1[4]) )
    call SetUnitLifeBJ( udg_ability_boost_life1[4], ( GetUnitStateSwap(UNIT_STATE_LIFE, udg_ability_boost_life1[4]) + ( GetUnitStateSwap(UNIT_STATE_MAX_LIFE, udg_ability_boost_life1[3]) / 200.00 ) ) )
endfunction

//===========================================================================
function InitTrig_timed_actions takes nothing returns nothing
    set gg_trg_timed_actions = CreateTrigger(  )
    call DisableTrigger( gg_trg_timed_actions )
    call TriggerRegisterTimerEventPeriodic( gg_trg_timed_actions, 0.10 )
    call TriggerAddAction( gg_trg_timed_actions, function Trig_timed_actions_Actions )
endfunction

JASS:

function Trig_turn_off_Func006001 takes nothing returns boolean
    return ( GetSpellAbilityId() == &#039;A004&#039; )
endfunction

function Trig_turn_off_Func006002 takes nothing returns boolean
    return ( GetSpellAbilityId() == &#039;A003&#039; )
endfunction

function Trig_turn_off_Conditions takes nothing returns boolean
    if ( not GetBooleanOr( Trig_turn_off_Func006001(), Trig_turn_off_Func006002() ) ) then
        return false
    endif
    return true
endfunction

function Trig_turn_off_Actions takes nothing returns nothing
    call DisableTrigger( gg_trg_timed_actions )
    call RemoveUnit( udg_ability_boost_life1[1] )
    call RemoveUnit( udg_ability_boost_life1[2] )
    call IssueImmediateOrderBJ( udg_ability_boost_life1[3], &quot;stop&quot; )
    call DestroyEffectBJ( udg_ability_boost_life2 )
endfunction

//===========================================================================
function InitTrig_turn_off takes nothing returns nothing
    set gg_trg_turn_off = CreateTrigger(  )
    call DisableTrigger( gg_trg_turn_off )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_turn_off, EVENT_PLAYER_UNIT_SPELL_ENDCAST )
    call TriggerAddCondition( gg_trg_turn_off, Condition( function Trig_turn_off_Conditions ) )
    call TriggerAddAction( gg_trg_turn_off, function Trig_turn_off_Actions )
endfunction

TriggerHappy · May 28, 2009

EDIT: Nevermind, my mistake :thup:

trb92 · May 28, 2009

TriggerHappy said:
I almost -repped you for that, zoidbergZA.

Why? zoidbergZA is the original poster, Exide asked him to do that...

Exide said:
I don't have WE or JassCraft with me, so I can't help you. But I can tell you that it's easier to help you if you convert your triggers to custom text first. (Even though GUI -> JASS = Horrible.)

TriggerHappy · May 28, 2009

trb92 said:
Why? zoidbergZA is the original poster, Exide asked him to do that...

Nevermind

simonake · May 28, 2009

Start by changing Globals to Locals.
Then search for Kenny's KBS

kingkingyyk3 · May 28, 2009

>>zoidbergZA
Does him know Jass? That code is just generated by GUI world editor. Never mind, I made a MUI version.

JASS:

// MUI by kingking.
// Needs ABC

scope BoostLife initializer Init

globals
    private constant integer abil_id = &#039;A000&#039;
    private constant integer ChannelDummyId = &#039;u000&#039;
    private constant string sfx = &quot;Abilities\\Spells\\Other\\Drain\\DrainCaster.mdl&quot;
    private constant real HealFactor = 200.
    private constant integer ChannelEffect = &#039;A001&#039;
    private constant string abil_OrderID = &quot;channel&quot;
endglobals

private struct Data
    unit cs
    unit target
    unit dum1
    unit dum2
    effect fx
    
    static method Init takes nothing returns Data
        return Data.allocate()
    endmethod
endstruct

private function Cond takes nothing returns boolean
    return GetSpellAbilityId() == abil_id
endfunction

private function Heal takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local Data a = GetTimerStructA(t)
    
    if GetUnitCurrentOrder(a.cs) == String2OrderIdBJ(abil_OrderID) then
        call SetUnitPosition(a.dum2,GetUnitX(a.target),GetUnitY(a.target))
        call SetUnitState(a.target,UNIT_STATE_LIFE,GetUnitState(a.target,UNIT_STATE_LIFE) + GetUnitState(a.cs,UNIT_STATE_LIFE) / HealFactor)
    else
        call PauseTimer(t)
        call DestroyTimer(t)
        call ClearTimerStructA(t)
        call RemoveUnit(a.dum1)
        call RemoveUnit(a.dum2)
        call DestroyEffect(a.fx)
        call a.destroy()
    endif
    
    set t = null
endfunction

private function Act takes nothing returns nothing
    local unit cs = GetTriggerUnit()
    local unit target = GetSpellTargetUnit()
    local player p = GetOwningPlayer(cs)
    local real X = GetUnitX(cs)
    local real Y = GetUnitY(cs)
    local real tX = GetUnitX(target)
    local real tY = GetUnitY(target)
    local unit dum1 = CreateUnit(p,ChannelDummyId,X,Y,0.)
    local unit dum2 = CreateUnit(Player(7),ChannelDummyId,X,Y,0.)
    local Data a = Data.Init()
    local timer t = CreateTimer()
    set a.cs = cs
    set a.target = target
    set a.dum1 = dum1
    set a.dum2 = dum2
    set a.fx = AddSpecialEffectTarget(sfx,target,&quot;overhead&quot;)
    call UnitAddAbility(dum1,ChannelEffect)
    call IssueTargetOrder(dum1,&quot;drain&quot;,dum2)
    call SetTimerStructA(t,a)
    call TimerStart(t,.1,true,function Heal)
    set cs = null
    set target = null
    set p = null
    set dum1 = null
    set dum2 = null
    set t = null
endfunction

private function Init takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerAddCondition(t,Condition(function Cond))
    call TriggerAddAction(t, function Act)
    set t = null
endfunction

endscope

zoidbergZA · May 29, 2009

hey guys i know this is going to sound retarted but plz keep in mind that im totaly new and im trying hard to learn.

i copied the JASS code above that kingkingyyk3 kindly wrote for me into to a blank trigger on my map. i then changed the global constant values at the top to match those on my map.

When i try to test the map i get a vJASS compiler message telling me there was 4 compiler errors. (i downloaded the newgen pack for WE on this forum)

can anybody plz steer this newbie in the right direction?

saw792 · May 29, 2009

His attempt requires the ABC attachment system, which can be found in resources somewhere.

UndeadDragon · May 29, 2009

What are the errors?

EDIT: Above ^^

Nexor · May 29, 2009

you have to copy the ABC - struct attachment system to your map too

Faust · May 29, 2009

You really should start off with something easier.
Make a mass entangle in vJASS
Make the mass entangle deal hero-stat based damage.
Things like that.

Put this one on hold, and try again in 2 days.

kingkingyyk3 · May 29, 2009

ABC at here..
http://www.thehelper.net/forums/showthread.php?t=62846

zoidbergZA · May 29, 2009

thanks, i added the ABC system trigger and vJass no longer gives errors when saving.

however, when i cast the spell ingame only the base ability 'channel' occurs, ie no HP boost or spell effect occurs. i checked and re-checked to make sure i set the global constant values to match mine in the object editor :banghead:

[Spell Request] JASS

zoidbergZA

New Member

Exide

I am amazingly focused right now!

zoidbergZA

New Member

TriggerHappy

...

trb92

Throwing science at the wall to see what sticks

TriggerHappy

...

simonake

New Member

kingkingyyk3

Visitor (Welcome to the Jungle, Baby!)

zoidbergZA

New Member

saw792

Is known to say things. That is all.

UndeadDragon

Super Moderator

Nexor

...

Faust

You can change this now in User CP.

kingkingyyk3

Visitor (Welcome to the Jungle, Baby!)

zoidbergZA

New Member

Settings Notifications

Options

The Helper Discord

Members online

Share this page

Affiliates

Network Sponsors

[Spell Request] JASS

New Member

I am amazingly focused right now!

New Member

...

Throwing science at the wall to see what sticks

...

New Member

Visitor (Welcome to the Jungle, Baby!)

New Member

Is known to say things. That is all.

Super Moderator

...

You can change this now in User CP.

Visitor (Welcome to the Jungle, Baby!)

New Member

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors