Stat-based trigger and NewGen error message

Onnings

New Member
Reaction score
9
Right, I have a few abilities that, in addition to their normal effect, cause damage based on a picked hero stat. The trigger works perfectly and nothing's wrong really, but after I got NewGenWE, an error message keeps popping up when I fire the ability. The error message I'm getting is:

double free of group in "Trig_Ravage_Actions"

This error message only displays when the triggered abiltiy hits enemy units though - just executing the ability without hitting any enemies returns no error message.

Anybody have a clue what this means, and what causes it?

Code:
Ravage
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Ravage 
    Actions
        Set Herostat = (Strength of (Casting unit) (Include bonuses))
        Set Temp_Attack = (Position of (Triggering unit))
        Set Group = (Units within 200.00 of Temp_Attack matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True))
        Unit Group - Pick every unit in Group and do (Unit - Cause (Casting unit) to damage (Picked unit), dealing (Real(Herostat)) damage of attack type Spells and damage type Normal)
        Custom script:   call RemoveLocation (udg_Temp_Attack)
        Custom script:   call DestroyGroup(udg_Group)
 

Onnings

New Member
Reaction score
9
Cheers, I'll give that a shot once I get back from work.

Any chance you'd want to explain why that fixes the bug, and how the wantDestroyGroup function works?
 

SFilip

Gone but not forgotten
Reaction score
634
> what this means
It means that you cleaned some leak twice.
Simple example:
Code:
Actions
    Set Temp_Pos = (Position of (Triggering unit))
    Custom script:   call RemoveLocation (udg_Temp_Pos)
    Custom script:   call RemoveLocation (udg_Temp_Pos)

> how the wantDestroyGroup function works?
That's a variable actually. When you set it to true then WE will automatically destroy the next unit group you use.
Code:
Actions
    Custom script:   set bj_wantDestroyGroup = true
    Unit Group - Pick every unit in (Units within 200.00 of Temp_Attack matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))))) and do (Unit - Cause (Casting unit) to damage (Picked unit), dealing (Real(Herostat)) damage of attack type Spells and damage type Normal)
Because that variable is true, after the Unit Group action is done picking units, call DestroyGroup is done automatically and the variable revents back to false.

> why that fixes the bug
It will only fix it if you have a trigger in which you set bj_wantDestroyGroup to true, but don't use a Unit Group action - this makes the bj variable stay on true so the next group (the one you're having trouble with) gets cleaned twice (once by you and once automatically).
Generally, using bj_wantDestroyGroup should be avoided to avoid problems like this.
 

Onnings

New Member
Reaction score
9
That explains a lot, thanks. I've used the 'Custom script: set bj_wantDestroyGroup = true' on some move triggers, but thinking back on it, I don't think I arranged the triggering units into a group before ordering them to move. This might be the origin.
 

SFilip

Gone but not forgotten
Reaction score
634
Well, the best thing to do in that case is sweep your code and use the DestroyGroup method instead of those bj_wantDestroyGroup.
 

Onnings

New Member
Reaction score
9
I removed all the wantDestroyGroups from my move triggers, but now it lags a lot when spawning the waves. I am thinking of rebuilding my spawn / move system somewhat akin to this turtorial, but to me, it seems ridden with leaks. Am I wrong?
 

SFilip

Gone but not forgotten
Reaction score
634
> it seems ridden with leaks
Indeed.
Well, could you post those spawn/move triggers you removed wantDestroyGroup from?
 

Onnings

New Member
Reaction score
9
Top Middle East basic spawn

Code:
TMERandom
    Events
        Time - Every 30.00 seconds of game time
    Conditions
        Random Equal to 0
    Actions
        Set Random = (Random integer number between 1 and 9)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Conscript for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Animated Magma for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Sunbringer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Archer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Prophet for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        Random Equal to 6
                                                    Then - Actions
                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                        Unit - Create 1 Enraged Snowbear for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                        Set Random = 0
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                Random Equal to 7
                                                            Then - Actions
                                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                Unit - Create 1 Champion for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                Set Random = 0
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        Random Equal to 8
                                                                    Then - Actions
                                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                        Unit - Create 1 Tamed Lupine for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                        Set Random = 0
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                Random Equal to 9
                                                                            Then - Actions
                                                                                Set Temp_Spawn = (Center of TopFlightSpawn <gen>)
                                                                                Unit - Create 1 Skyborn Sunchild for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                                Set Random = 0
                                                                            Else - Actions
                                                                                Do nothing
        Set Random = (Random integer number between 1 and 9)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Conscript for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Animated Magma for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Sunbringer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Archer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Prophet for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        Random Equal to 6
                                                    Then - Actions
                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                        Unit - Create 1 Enraged Snowbear for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                        Set Random = 0
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                Random Equal to 7
                                                            Then - Actions
                                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                Unit - Create 1 Champion for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                Set Random = 0
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        Random Equal to 8
                                                                    Then - Actions
                                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                        Unit - Create 1 Tamed Lupine for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                        Set Random = 0
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                Random Equal to 9
                                                                            Then - Actions
                                                                                Set Temp_Spawn = (Center of TopFlightSpawn <gen>)
                                                                                Unit - Create 1 Skyborn Sunchild for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                                Set Random = 0
                                                                            Else - Actions
                                                                                Do nothing
        Set Random = (Random integer number between 1 and 9)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Conscript for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Animated Magma for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Sunbringer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Archer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Prophet for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        Random Equal to 6
                                                    Then - Actions
                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                        Unit - Create 1 Enraged Snowbear for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                        Set Random = 0
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                Random Equal to 7
                                                            Then - Actions
                                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                Unit - Create 1 Champion for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                Set Random = 0
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        Random Equal to 8
                                                                    Then - Actions
                                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                        Unit - Create 1 Tamed Lupine for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                        Set Random = 0
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                Random Equal to 9
                                                                            Then - Actions
                                                                                Set Temp_Spawn = (Center of TopFlightSpawn <gen>)
                                                                                Unit - Create 1 Skyborn Sunchild for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                                Set Random = 0
                                                                            Else - Actions
                                                                                Do nothing

Top Middle East Boss spawn

Code:
TMEBossRandom
    Events
        Time - Every 75.00 seconds of game time
    Conditions
        Random Equal to 0
    Actions
        Set Random = (Random integer number between 1 and 5)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Sergeant (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Assassin (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Rockhide Obliterator (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Deathwarden (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Drillmaster (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                Do nothing


Top Base Middle East Move trigger

Code:
TBMEMove
    Events
        Unit - A unit enters Top Base ME <gen>
    Conditions
        (Owner of (Triggering unit)) Equal to Player 6 (Orange)
    Actions
        Set Temp_Attack = (Center of Bottom Base ME <gen>)
        [COLOR="Red"]<- This area used to contain the wantDestroyGroup ->[/COLOR]
        Unit - Order (Triggering unit) to Attack-Move To Temp_Attack
        Custom script:   call RemoveLocation (udg_Temp_Attack)

There's more or less four sets of these for each side, totalling to 8 sets. They're all currently using the same Temp_Spawn and Temp_Attack variables.
 

N2o)

Retired.
Reaction score
51
Just a hint, but if you store your units in a unit type array at map init, you can minimalise your trigger actions to:
Code:
        Set Random = (Random integer number between 1 and 5
        Set Temp_Spawn = (Center of Top Base ME <gen>)
        Unit - Create 1 *Unit-Type Variable*[Random] for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
        Custom script:   call RemoveLocation (udg_Temp_Spawn)
        Unit Group - Add (Last created unit) to TCGroup
        Set Random = 0
 

Onnings

New Member
Reaction score
9
That's one of the improvements I was planning to make. I'm still working on fitting the arrays into my logic.

I also edited out the ' Unit Group - Add (Last created unit) to TCGroup'-bit, as I was in the middle of editing my triggers when I posted this, and that was a part of the change I was planning on trying.

Edit: Tried the old triggers again, and there's no lag now. I guess it was the virus software or something acting up last time.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top