Stat-based trigger and NewGen error message

Onnings

Onnings

New Member
Reaction score
9
Right, I have a few abilities that, in addition to their normal effect, cause damage based on a picked hero stat. The trigger works perfectly and nothing's wrong really, but after I got NewGenWE, an error message keeps popping up when I fire the ability. The error message I'm getting is:

double free of group in "Trig_Ravage_Actions"

This error message only displays when the triggered abiltiy hits enemy units though - just executing the ability without hitting any enemies returns no error message.

Anybody have a clue what this means, and what causes it?

Code: 
Ravage
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Ravage 
    Actions
        Set Herostat = (Strength of (Casting unit) (Include bonuses))
        Set Temp_Attack = (Position of (Triggering unit))
        Set Group = (Units within 200.00 of Temp_Attack matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True))
        Unit Group - Pick every unit in Group and do (Unit - Cause (Casting unit) to damage (Picked unit), dealing (Real(Herostat)) damage of attack type Spells and damage type Normal)
        Custom script:   call RemoveLocation (udg_Temp_Attack)
        Custom script:   call DestroyGroup(udg_Group)
 
Onnings

Onnings

New Member
Reaction score
9
Cheers, I'll give that a shot once I get back from work.

Any chance you'd want to explain why that fixes the bug, and how the wantDestroyGroup function works?
 
S

SFilip

Gone but not forgotten
Reaction score
634
> what this means
It means that you cleaned some leak twice.
Simple example:
Code: 
Actions
    Set Temp_Pos = (Position of (Triggering unit))
    Custom script:   call RemoveLocation (udg_Temp_Pos)
    Custom script:   call RemoveLocation (udg_Temp_Pos)

> how the wantDestroyGroup function works?
That's a variable actually. When you set it to true then WE will automatically destroy the next unit group you use.
Code: 
Actions
    Custom script:   set bj_wantDestroyGroup = true
    Unit Group - Pick every unit in (Units within 200.00 of Temp_Attack matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))))) and do (Unit - Cause (Casting unit) to damage (Picked unit), dealing (Real(Herostat)) damage of attack type Spells and damage type Normal)
Because that variable is true, after the Unit Group action is done picking units, call DestroyGroup is done automatically and the variable revents back to false.

> why that fixes the bug
It will only fix it if you have a trigger in which you set bj_wantDestroyGroup to true, but don't use a Unit Group action - this makes the bj variable stay on true so the next group (the one you're having trouble with) gets cleaned twice (once by you and once automatically).
Generally, using bj_wantDestroyGroup should be avoided to avoid problems like this.
 
Onnings

Onnings

New Member
Reaction score
9
That explains a lot, thanks. I've used the 'Custom script: set bj_wantDestroyGroup = true' on some move triggers, but thinking back on it, I don't think I arranged the triggering units into a group before ordering them to move. This might be the origin.
 
S

SFilip

Gone but not forgotten
Reaction score
634
Well, the best thing to do in that case is sweep your code and use the DestroyGroup method instead of those bj_wantDestroyGroup.
 
Onnings

Onnings

New Member
Reaction score
9
I removed all the wantDestroyGroups from my move triggers, but now it lags a lot when spawning the waves. I am thinking of rebuilding my spawn / move system somewhat akin to this turtorial, but to me, it seems ridden with leaks. Am I wrong?
 
S

SFilip

Gone but not forgotten
Reaction score
634
> it seems ridden with leaks
Indeed.
Well, could you post those spawn/move triggers you removed wantDestroyGroup from?
 
Onnings

Onnings

New Member
Reaction score
9
Top Middle East basic spawn

Code: 
TMERandom
    Events
        Time - Every 30.00 seconds of game time
    Conditions
        Random Equal to 0
    Actions
        Set Random = (Random integer number between 1 and 9)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Conscript for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Animated Magma for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Sunbringer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Archer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Prophet for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        Random Equal to 6
                                                    Then - Actions
                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                        Unit - Create 1 Enraged Snowbear for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                        Set Random = 0
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                Random Equal to 7
                                                            Then - Actions
                                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                Unit - Create 1 Champion for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                Set Random = 0
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        Random Equal to 8
                                                                    Then - Actions
                                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                        Unit - Create 1 Tamed Lupine for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                        Set Random = 0
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                Random Equal to 9
                                                                            Then - Actions
                                                                                Set Temp_Spawn = (Center of TopFlightSpawn <gen>)
                                                                                Unit - Create 1 Skyborn Sunchild for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                                Set Random = 0
                                                                            Else - Actions
                                                                                Do nothing
        Set Random = (Random integer number between 1 and 9)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Conscript for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Animated Magma for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Sunbringer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Archer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Prophet for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        Random Equal to 6
                                                    Then - Actions
                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                        Unit - Create 1 Enraged Snowbear for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                        Set Random = 0
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                Random Equal to 7
                                                            Then - Actions
                                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                Unit - Create 1 Champion for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                Set Random = 0
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        Random Equal to 8
                                                                    Then - Actions
                                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                        Unit - Create 1 Tamed Lupine for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                        Set Random = 0
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                Random Equal to 9
                                                                            Then - Actions
                                                                                Set Temp_Spawn = (Center of TopFlightSpawn <gen>)
                                                                                Unit - Create 1 Skyborn Sunchild for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                                Set Random = 0
                                                                            Else - Actions
                                                                                Do nothing
        Set Random = (Random integer number between 1 and 9)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Conscript for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Animated Magma for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Sunbringer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Archer for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Prophet for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        Random Equal to 6
                                                    Then - Actions
                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                        Unit - Create 1 Enraged Snowbear for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                        Set Random = 0
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                Random Equal to 7
                                                            Then - Actions
                                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                Unit - Create 1 Champion for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                Set Random = 0
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        Random Equal to 8
                                                                    Then - Actions
                                                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                                        Unit - Create 1 Tamed Lupine for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                        Set Random = 0
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                Random Equal to 9
                                                                            Then - Actions
                                                                                Set Temp_Spawn = (Center of TopFlightSpawn <gen>)
                                                                                Unit - Create 1 Skyborn Sunchild for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                                                Set Random = 0
                                                                            Else - Actions
                                                                                Do nothing

Top Middle East Boss spawn

Code: 
TMEBossRandom
    Events
        Time - Every 75.00 seconds of game time
    Conditions
        Random Equal to 0
    Actions
        Set Random = (Random integer number between 1 and 5)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Random Equal to 1
            Then - Actions
                Set Temp_Spawn = (Center of Top Base ME <gen>)
                Unit - Create 1 Sergeant (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                Set Random = 0
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Random Equal to 2
                    Then - Actions
                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                        Unit - Create 1 Assassin (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                        Set Random = 0
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                Random Equal to 3
                            Then - Actions
                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                Unit - Create 1 Rockhide Obliterator (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                Set Random = 0
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        Random Equal to 4
                                    Then - Actions
                                        Set Temp_Spawn = (Center of Top Base ME <gen>)
                                        Unit - Create 1 Deathwarden (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                        Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                        Set Random = 0
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                Random Equal to 5
                                            Then - Actions
                                                Set Temp_Spawn = (Center of Top Base ME <gen>)
                                                Unit - Create 1 Drillmaster (B) for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
                                                Custom script:   call RemoveLocation (udg_Temp_Spawn)
                                                Set Random = 0
                                            Else - Actions
                                                Do nothing


Top Base Middle East Move trigger

Code: 
TBMEMove
    Events
        Unit - A unit enters Top Base ME <gen>
    Conditions
        (Owner of (Triggering unit)) Equal to Player 6 (Orange)
    Actions
        Set Temp_Attack = (Center of Bottom Base ME <gen>)
        [COLOR="Red"]<- This area used to contain the wantDestroyGroup ->[/COLOR]
        Unit - Order (Triggering unit) to Attack-Move To Temp_Attack
        Custom script:   call RemoveLocation (udg_Temp_Attack)

There's more or less four sets of these for each side, totalling to 8 sets. They're all currently using the same Temp_Spawn and Temp_Attack variables.
 
N2o)

N2o)

Retired.
Reaction score
51
Just a hint, but if you store your units in a unit type array at map init, you can minimalise your trigger actions to:
Code: 
        Set Random = (Random integer number between 1 and 5
        Set Temp_Spawn = (Center of Top Base ME <gen>)
        Unit - Create 1 *Unit-Type Variable*[Random] for Player 6 (Orange) at Temp_Spawn facing Default building facing degrees
        Custom script:   call RemoveLocation (udg_Temp_Spawn)
        Unit Group - Add (Last created unit) to TCGroup
        Set Random = 0
 
Onnings

Onnings

New Member
Reaction score
9
That's one of the improvements I was planning to make. I'm still working on fitting the arrays into my logic.

I also edited out the ' Unit Group - Add (Last created unit) to TCGroup'-bit, as I was in the middle of editing my triggers when I posted this, and that was a part of the change I was planning on trying.

Edit: Tried the old triggers again, and there's no lag now. I guess it was the virus software or something acting up last time.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.
      Online now:
      283 (members: 2, guests: 281)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top