Trigger becomes bugged when people leave

[Xebarsis]

I have a trigger that picks a random player and kills all of their units. Later another trigger respawns them, however sometimes it ends up choosing a player that has left the game.

I'm not sure how to make my trigger not only pick a random player and kill their units, but also not pick someone who has left. Here's my trigger:

The Imploder
    Events
        Unit - A unit Uses an item
    Conditions
        (Item-type of (Item being manipulated)) Equal to The Imploder
    Actions
        Set UnluckyPlayer = (Random player from (All enemies of (Owner of (Hero manipulating item))))
        Game - Display to (All players) the text: (PlayerColors[(Player number of (Owner of (Triggering unit)))] + (((Name of (Owner of (Triggering unit))) + |R has used, "The Imploder" on ) + (PlayerColors[(Player number of UnluckyPlayer)] + ((Name of UnluckyPlayer) + ,|R INSTANT KILL!))))
        Unit Group - Pick every unit in (Units owned by UnluckyPlayer) and do (Actions)
            Loop - Actions
                Unit - Explode (Picked unit)
                Sound - Play HeroAlchemistPissed3 <gen>

 

[SilentCombat]

Use Something like this when you create the random number.

    Events
    Conditions
    Actions
        set num = 1
        For each (Integer num) from 1 to 1, do (Actions)
            Loop - Actions
                Set random = (Random integer number between 1 and 12)
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Or - Any (Conditions) are true
                            Conditions
                                ((Player(random)) slot status) Equal to Has left the game
                                ((Player(random)) slot status) Equal to Is unused
                    Then - Actions
                        Set num = (num - 1)
                    Else - Actions

 

[Don]

Set UnluckyPlayer = (Random player from (All enemies of (Owner of (Hero manipulating item))) matching (matching player controller = user) or (player slot status = is playing) = true)

should do!

 

[Xebarsis]

I wanted to do something like that Don, but I know how to make this

Set UnluckyPlayer = (Random player from (All enemies of (Owner of (Hero manipulating item))))

look like your code:

Set UnluckyPlayer = (Random player from (All enemies of (Owner of (Hero manipulating item))) matching (matching player controller = user) or (player slot status = is playing) = true)

Do you think you could walk me through the process of what functions to choose to be able to add on from what I have?

 

[Weegee]

there should be something like player matching condition and then u do what he said

 

[Xebarsis]

I believe choosing (matching player controller = user) would still cause users that aren't playing to be chosen, and as for the second suggestion with (player slot status = is playing), I don't know what option to pick to replace "player." I know there's variables and I can also choose a specific player, but I'm still setting the UnluckyPlayer so I'm not sure what to put it as.

I did find the "player matching condition," however I don't know how to get "= true)" at the end of the code.

Edit: Are (matching player controller = user) and (player slot status = is playing) supposed to be in one code, or are you suggesting I pick one?

 

[Don]

Edit: Are (matching player controller = user) and (player slot status = is playing) supposed to be in one code, or are you suggesting I pick one?

you can do it seperate or together, it depends on how you feel...

 

[Xebarsis]

Well I'd like to do them together, but I don't understand the order of functions to select in order to achieve that.

 

[Don]

use ''and'' at the borttom of conditions list.. pretty simple! Use it twice, for ennemies thing, slot status and controller.

If it doesnt work, remove slot status condition and it should work perfectly!

 

[Xebarsis]

Does this look right?

The Imploder
    Events
        Unit - A unit Uses an item
    Conditions
        (Item-type of (Item being manipulated)) Equal to The Imploder
        And - All (Conditions) are true
            Conditions
                ((Matching player) controller) Equal to User
                ((Matching player) slot status) Equal to Is playing
    Actions
        Set UnluckyPlayer = (Random player from (All enemies of (Owner of (Hero manipulating item))))
        Game - Display to (All players) the text: (PlayerColors[(Player number of (Owner of (Triggering unit)))] + (((Name of (Owner of (Triggering unit))) + |R has used, "The Imploder" on ) + (PlayerColors[(Player number of UnluckyPlayer)] + ((Name of UnluckyPlayer) + ,|R INSTANT KILL!))))
        Unit Group - Pick every unit in (Units owned by UnluckyPlayer) and do (Actions)
            Loop - Actions
                Unit - Explode (Picked unit)
        Sound - Play HeroAlchemistPissed3 <gen>

 

[Don]

perfect :thup: now, leak removal?

 

[Xebarsis]

Uhhh... turns out that "The Imploder" doesn't work AT ALL now with this new trigger.

Edit: But then again, you did say, "If it doesnt work, remove slot status condition and it should work perfectly!" So I will remove that condition and see what happens.

 

[Xebarsis]

Turns out even when removing the condition you said, it still doesn't work. It's activated by an item, when I use the item it just vanishes (since it's a charge) and nothing happens.

 

[Aphurea]

Haha, I was playing that game yesterday and someone left and we noticed the bug.

 

[Doom-Angel]

well the only way i thought about it is looping till getting the right condition or either keep track of the number of playing players in game in a player group and remove all leavers out of loop.

anyway jass solution:

The Imploder
    Events
        Unit - A unit Uses an item
    Conditions
        (Item-type of (Item being manipulated)) Equal to The Imploder
    Actions
        Custom script:   loop
        Set UnluckyPlayer = (Random player from (All enemies of (Owner of (Hero manipulating item))))
        Custom script:   exitwhen (GetPlayerSlotState(udg_UnluckyPlayer) == PLAYER_SLOT_STATE_PLAYING)
        Custom script:   endloop
        Game - Display to (All players) the text: (PlayerColors[(Player number of (Owner of (Triggering unit)))] + (((Name of (Owner of (Triggering unit))) + |R has used, "The Imploder" on ) + (PlayerColors[(Player number of UnluckyPlayer)] + ((Name of UnluckyPlayer) + ,|R INSTANT KILL!))))
        Unit Group - Pick every unit in (Units owned by UnluckyPlayer) and do (Actions)
            Loop - Actions
                Unit - Explode (Picked unit)
                Sound - Play HeroAlchemistPissed3 <gen>

try that im pretty sure it should work

 

[Renendaru]

Nice Doom, that's a good way of doing it.

 

[Xebarsis]

Success! Thank you very much for the JASS trigger.