Trigger crashes

B

Badozz

New Member
Reaction score
2
I have created a trigger which crashes the game, but I don't understand why.
Here is that trigger:
----
trigger_www.kepfeltoltes.hu_.jpg

----
and looks like this in jass:
Code: 
function Trig_ranger1_Func006Func001C takes nothing returns boolean
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I006' ) ) then
        return true
    endif
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I00T' ) ) then
        return true
    endif
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I00W' ) ) then
        return true
    endif
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I00S' ) ) then
        return true
    endif
    return false
endfunction

function Trig_ranger1_Func006C takes nothing returns boolean
    if ( not Trig_ranger1_Func006Func001C() ) then
        return false
    endif
    if ( not ( GetUnitTypeId(GetManipulatingUnit()) == 'H002' ) ) then
        return false
    endif
    return true
endfunction

function Trig_ranger1_Conditions takes nothing returns boolean
    if ( not Trig_ranger1_Func006C() ) then
        return false
    endif
    return true
endfunction

function Trig_ranger1_Actions takes nothing returns nothing
    call UnitRemoveItemSwapped( UnitItemInSlotBJ(GetManipulatingUnit(), 1), GetManipulatingUnit() )
    call RemoveItem( GetManipulatedItem() )
    call CreateItemLoc( 'I00T', GetRectCenter(GetPlayableMapRect()) )
    call UnitAddItemSwapped( GetLastCreatedItem(), GetManipulatingUnit() )
    call SetItemDroppableBJ( GetLastCreatedItem(), false )
endfunction

//===========================================================================
function InitTrig_ranger1 takes nothing returns nothing
    set gg_trg_ranger1 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_ranger1, EVENT_PLAYER_UNIT_PICKUP_ITEM )
    call TriggerAddCondition( gg_trg_ranger1, Condition( function Trig_ranger1_Conditions ) )
    call TriggerAddAction( gg_trg_ranger1, function Trig_ranger1_Actions )
endfunction
----
the memory leak calculator says that it has 2 leaks. But it doesn't say how can i fix it. :nuts: :banghead:
----
This trigger's function:
The heroes' weapon always stored in the first slot, and when you pick up a new weapon your old one will be dropped, and the new one will be exchaned for a suitable weapon for you (ranger get bow instead of sword), and you cannot move it from the first slot. So when you pick up another weapon the item in the first slot (your weapon) will be dropped.
----
Please post some solution for this trigger to don't crash. Thank you.
 
S

SFilip

Gone but not forgotten
Reaction score
634
a leak can't crash the game. not only one at least.
your problem is very simple:
when you pickup an item you add a new item again with the Hero - Give action. this makes the trigger run again and add the item again...which keeps it running in one infinite loop and crashes.
solution? disable the trigger before the give action and enable it again right after that.

also you don't need the And in conditions. its useless since they already work that way.
and btw there is an action create item for hero (under hero) which will fix the leak here. use it instead of Item - Create and Hero - Give.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      60 (members: 1, guests: 59)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top