Trigger crashes

Badozz

New Member
Reaction score
2
I have created a trigger which crashes the game, but I don't understand why.
Here is that trigger:
----
trigger_www.kepfeltoltes.hu_.jpg

----
and looks like this in jass:
Code:
function Trig_ranger1_Func006Func001C takes nothing returns boolean
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I006' ) ) then
        return true
    endif
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I00T' ) ) then
        return true
    endif
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I00W' ) ) then
        return true
    endif
    if ( ( GetItemTypeId(GetManipulatedItem()) == 'I00S' ) ) then
        return true
    endif
    return false
endfunction

function Trig_ranger1_Func006C takes nothing returns boolean
    if ( not Trig_ranger1_Func006Func001C() ) then
        return false
    endif
    if ( not ( GetUnitTypeId(GetManipulatingUnit()) == 'H002' ) ) then
        return false
    endif
    return true
endfunction

function Trig_ranger1_Conditions takes nothing returns boolean
    if ( not Trig_ranger1_Func006C() ) then
        return false
    endif
    return true
endfunction

function Trig_ranger1_Actions takes nothing returns nothing
    call UnitRemoveItemSwapped( UnitItemInSlotBJ(GetManipulatingUnit(), 1), GetManipulatingUnit() )
    call RemoveItem( GetManipulatedItem() )
    call CreateItemLoc( 'I00T', GetRectCenter(GetPlayableMapRect()) )
    call UnitAddItemSwapped( GetLastCreatedItem(), GetManipulatingUnit() )
    call SetItemDroppableBJ( GetLastCreatedItem(), false )
endfunction

//===========================================================================
function InitTrig_ranger1 takes nothing returns nothing
    set gg_trg_ranger1 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_ranger1, EVENT_PLAYER_UNIT_PICKUP_ITEM )
    call TriggerAddCondition( gg_trg_ranger1, Condition( function Trig_ranger1_Conditions ) )
    call TriggerAddAction( gg_trg_ranger1, function Trig_ranger1_Actions )
endfunction
----
the memory leak calculator says that it has 2 leaks. But it doesn't say how can i fix it. :nuts: :banghead:
----
This trigger's function:
The heroes' weapon always stored in the first slot, and when you pick up a new weapon your old one will be dropped, and the new one will be exchaned for a suitable weapon for you (ranger get bow instead of sword), and you cannot move it from the first slot. So when you pick up another weapon the item in the first slot (your weapon) will be dropped.
----
Please post some solution for this trigger to don't crash. Thank you.
 
a leak can't crash the game. not only one at least.
your problem is very simple:
when you pickup an item you add a new item again with the Hero - Give action. this makes the trigger run again and add the item again...which keeps it running in one infinite loop and crashes.
solution? disable the trigger before the give action and enable it again right after that.

also you don't need the And in conditions. its useless since they already work that way.
and btw there is an action create item for hero (under hero) which will fix the leak here. use it instead of Item - Create and Hero - Give.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    News portal has been retired. Main page of site goes to Headline News forum now
  • The Helper The Helper:
    I am working on getting access to the old news portal under a different URL for those that would rather use that for news before we get a different news view.
  • Ghan Ghan:
    Easily done
    +1
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top