vJass Struct Bug?

Dangerb0y

New Member
Reaction score
0
Maybe someone can help me understand why this is happening. It makes no freaking sense to me! :nuts:

Don't ask me how I got to this point, but say for example that you have the following script...

JASS:
scope test initializer init

private struct data
    unit u
endstruct

globals
    private data array d
endglobals

private function testactions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local data d1
    local data d2
    set d1 = data.create()
    set d1.u = u
    set d[0] = d1
    set d2 = data.create()
    set d2.u = u
    set d[1] = d2
    set d1 = d[0]
    set d2 = d[1]
    call BJDebugMsg( GetUnitName(d1.u) )
    call BJDebugMsg( GetUnitName(d2.u) )
    set d1.u = null
    call d1.destroy()
    set d2.u = null
    call d2.destroy()
    call BJDebugMsg( GetUnitName(d1.u) )
    call BJDebugMsg( GetUnitName(d2.u) )
    set d1 = data.create()
    set d1.u = u
    call BJDebugMsg( GetUnitName(d1.u) )
    call BJDebugMsg( GetUnitName(d2.u) )
endfunction

private function init takes nothing returns nothing
    // etc...
endfunction

endscope


Let's call the trigger unit "Bob". If I looked at that script I would be willing to bet my mother that when the testactions function is called, it would print:

Bob
Bob
(null)
(null)
Bob
(null)


Right? My mom sure wouldn't think so. For some reason it displays this:

Bob
Bob
(null)
(null)
Bob
Bob
<- notice the "Bob" that should be a "(null)"

Is this a bug? or is it working as it should be and I'm just not understanding exactly how structs function behind the scenes?
 

Laiev

Hey Listen!!
Reaction score
188
JASS:
private function testactions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local data d1 = data.create()
    local data d2 = data.create()

    set d1.u = u
    set d[0] = d1

    set d2.u = u
    set d[1] = d2

    set d1 = d[0] //why you set the value of the struct to the value of struct?
    set d2 = d[1] //ditto

    call BJDebugMsg( GetUnitName(d1.u) ) //should return right
    call BJDebugMsg( GetUnitName(d2.u) ) //ditto

    set d1.u = null //you don&#039;t need to null because struct member = globals
    call d1.destroy()
    set d2.u = null //ditto d1.u = null
    call d2.destroy()

    call BJDebugMsg( GetUnitName(d1.u) ) //should return null because u = null
    call BJDebugMsg( GetUnitName(d2.u) ) //ditto

    set d1 = data.create()
    set d1.u = u

    call BJDebugMsg( GetUnitName(d1.u) ) //should return right
    call BJDebugMsg( GetUnitName(d2.u) ) //should return any value because you don&#039;t create it, in other vision, it store the name of the old unit
endfunctiona
 

Dangerb0y

New Member
Reaction score
0
Ok sure, I didn't condense it to its simplest form, but that still doesn't explain why setting the 0 index of an array would affect the 1 index at all. I've just tested this phenomenon with a basic global unit array without structs, and it worked like it should.

I understand that vJASS isn't 100% perfect as you can only make JASS do so much before it becomes ASS - I am just curious as to whether this is in fact an issue/bug, or if for some reason this IS what is meant to happen in this situation. Food for thought...
 

Romek

Super Moderator
Reaction score
964
What's meant to happen? Bugs.

What happens? Bugs.

The conclusion? Don't 'use' destroyed structs.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top