Whats wrong with my code?

[ZZY]

I made the "hero revive" trigger from the tutorial on the home page and it says i have 3 errors in my script, here it is

Expects a function name :

call StartTimerDialogBJ( ourtimer, false, ( I2R(HeroWait) ))
......................................................./\ i dont know what that char is, lower case L, upper i 1 or tube (button above/below enter)???

Expects end of line :

call TimerDialogDisplayForPlayerBJ(true, WINDOW, GetOwningPlayer(OURHERO)) )

Expects Name :
call ReviveHeroLoc(MyHero,GetRectCenter(gg_rct_Red_Death), true)

If you could help me out i would appreciate it, ZZ

 

[Komaqtion]

Expects a function name :

call StartTimerDialogBJ( ourtimer, false, ( I2R(HeroWait) ))
......................................................./\ i dont know what that char is, lower case L, upper i 1 or tube (button above/below enter)???

It's an uppercase "i"

Expects end of line :

call TimerDialogDisplayForPlayerBJ(true, WINDOW, GetOwningPlayer(OURHERO)) )

Too many ")"...
Should be:

call TimerDialogDisplayForPlayerBJ(true, WINDOW, GetOwningPlayer(OURHERO))

Expects Name :
call ReviveHeroLoc(MyHero,GetRectCenter(gg_rct_Red_Death), true)

MyHero should be replaced with OURHERO

 

[ZZY]

The first one, even tho it was the right case, still gave me the error, the rest work fine

 

[Gtam]

you know you could do
Local unit bla = GetTriggerUnit()
You dont have to set it later.

 

[ZZY]

you know you could do
Local unit bla = GetTriggerUnit()
You dont have to set it later.

im sorry, i dont fully understand, were would that go or replace and what would bla =?

 

[Komaqtion]

The first one, even tho it was the right case, still gave me the error, the rest work fine

Hehe XD That's because there is nothing called [ljass]StartTimerDialogBJ[/ljass]...
It's supposed to be plain [ljass]StartTimerBJ[/ljass]

im sorry, i dont fully understand, were would that go or replace and what would bla =?

He just meant that this:

local timerdialog WINDOW
local integer HeroWait
local timer ourtimer
local unit OURHERO
// And then setting them afterwards...

Can just be this:

local unit OURHERO = GetTriggerUnit()
local integer HeroWait = GetHeroLeve( OURHERO ) * 150
local timer ourtimer = CreateTimer()
local timerdialog WINDOW

 

[ZZY]

Hehe XD That's because there is nothing called [ljass]StartTimerDialogBJ[/ljass]...
It's supposed to be plain [ljass]StartTimerBJ[/ljass]

Even with that correction..

 

[foodflare]

edit: i fail at noticing things

 

[TheTempest]

Just write it in GUI you don't need JASS for this.

 

[ZZY]

its not in jass, this is what comes up when i click enable in the trigger editor.

 

[ZZY]

bump

 

[kaboo]

forget about it and use this instead:

• hero dies
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Game - Display to (All players) the text: whatever u want
    • Unit Group - Add (Triggering unit) to dead_heroes
    • Countdown Timer - Start timer[(Player number of (Owner of (Triggering unit)))] as a One-shot timer that will expire in 30.00 seconds
    • Countdown Timer - Create a timer window for (Last started timer) with title hero resp
    • Countdown Timer - Hide (Last created timer window)
    • Countdown Timer - Show (Last created timer window) for (Owner of (Triggering unit))
    • Set timer_window[(Player number of (Owner of (Triggering unit)))] = (Last created timer window)

• hero revive
  • Events
    • Time - timer[1] expires
    • Time - timer[2] expires
    • Time - timer[3] expires
    • .......
    • Time - timer[12] expires
  • Conditions
  • Actions
    • Unit Group - Pick every unit in dead_heroes and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Remaining time for timer[(Player number of (Owner of (Picked unit)))]) Equal to 0.00
          • Then - Actions
            • Hero - Instantly revive (Picked unit) at (Random point in (Playable map area)), Show revival graphics
            • Countdown Timer - Destroy timer_window[(Player number of (Owner of (Picked unit)))]
          • Else - Actions

 

[ZZY]

thanks, that worked, + rep

 

[jomik]

What you wrote were a JASS snippet using custom codes

 

[ZZY]

so your saying that should have gone in the jass editor?