Why Doesn't This Spell Work When I Add Another Loop?

Fluffball

Well-Known Member
Reaction score
35
Ok, as the title suggests, the spell is supposed to make a 2000 by 2000 region around the caster, make him invul, no collision, all that stuff, it works fine, but when i added the 2nd and 3rd loop, he only moves to the point once, and the effects continue, and even more interestingly, he casts the spell Holy Smash. Heres the spell (With and without)


With
Code:
Charge of the Light
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Charge of Light 
    Actions
        If (MUIFix Less than 15) then do (Set MUIFix = (MUIFix + 1)) else do (Set MUIFix = 0)
        Set TempPlayer[MUIFix] = (Owner of (Triggering unit))
        Set TempBool = False
        Set TempCaster = (Casting unit)
        Unit - Change ownership of (Triggering unit) to Player 11 (Dark Green) and Retain color
        Unit - Set TempCaster movement speed to 1000.00
        Unit - Turn collision for TempCaster Off
        Unit - Add Immolation  to TempCaster
        Unit - Set level of Immolation  for TempCaster to (Level of Charge of Light  for TempCaster)
        Unit - Add Heal Aura  to TempCaster
        Unit - Set level of Immolation  for TempCaster to (Level of Charge of Light  for TempCaster)
        Unit - Make TempCaster Invulnerable
        Set TempRegion = (Region centered at (Position of TempCaster) with size (2000.00, 2000.00))
        For each (Integer A) from 1 to 10, do (Actions)
            Loop - Actions
                Set TempPoint = (Random point in TempRegion)
                Set TempRegion2 = (Region centered at TempPoint with size (250.00, 250.00))
                Unit - Order TempCaster to Move To TempPoint
                For each (Integer A) from 1 to 15, do (Actions)
                    Loop - Actions
                        Wait 1.00 seconds
                        Set TempPoint2 = (Position of (Triggering unit))
                        For each (Integer B) from 1 to 4, do (Actions)
                            Loop - Actions
                                Special Effect - Create a special effect at (TempPoint2 offset by 50.00 towards (90.00 x (Real((Integer B)))) degrees) using Abilities\Spells\Human\Resurrect\ResurrectTarget.mdl
                                Special Effect - Destroy (Last created special effect)
                Wait until ((TempRegion2 contains TempCaster) Equal to True), checking every 0.10 seconds
        Unit - Add Holy Smash  to TempCaster
        Unit - Set level of Holy Smash  for TempCaster to 1
        Unit - Order TempCaster to Human Mountain King - Thunder Clap
        Unit - Remove Holy Smash  from TempCaster
        Unit - Remove Heal Aura  from TempCaster
        Unit - Remove Immolation  from TempCaster
        Unit - Turn collision for TempCaster On
        Unit - Make TempCaster Vulnerable
        Unit - Set TempCaster movement speed to (Default movement speed of TempCaster)
        Unit - Change ownership of TempCaster to TempPlayer[MUIFix] and Change color

Without:

Code:
Charge of the Light
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Charge of Light 
    Actions
        If (MUIFix Less than 15) then do (Set MUIFix = (MUIFix + 1)) else do (Set MUIFix = 0)
        Set TempPlayer[MUIFix] = (Owner of (Triggering unit))
        Set TempBool = False
        Set TempCaster = (Casting unit)
        Unit - Change ownership of (Triggering unit) to Player 11 (Dark Green) and Retain color
        Unit - Set TempCaster movement speed to 1000.00
        Unit - Turn collision for TempCaster Off
        Unit - Add Immolation  to TempCaster
        Unit - Set level of Immolation  for TempCaster to (Level of Charge of Light  for TempCaster)
        Unit - Add Heal Aura  to TempCaster
        Unit - Set level of Immolation  for TempCaster to (Level of Charge of Light  for TempCaster)
        Unit - Make TempCaster Invulnerable
        Set TempRegion = (Region centered at (Position of TempCaster) with size (2000.00, 2000.00))
        For each (Integer A) from 1 to 10, do (Actions)
            Loop - Actions
                Set TempPoint = (Random point in TempRegion)
                Set TempRegion2 = (Region centered at TempPoint with size (250.00, 250.00))
                Unit - Order TempCaster to Move To TempPoint
                Wait until ((TempRegion2 contains TempCaster) Equal to True), checking every 0.10 seconds
        Unit - Add Holy Smash  to TempCaster
        Unit - Set level of Holy Smash  for TempCaster to 1
        Unit - Order TempCaster to Human Mountain King - Thunder Clap
        Unit - Remove Holy Smash  from TempCaster
        Unit - Remove Heal Aura  from TempCaster
        Unit - Remove Immolation  from TempCaster
        Unit - Turn collision for TempCaster On
        Unit - Make TempCaster Vulnerable
        Unit - Set TempCaster movement speed to (Default movement speed of TempCaster)
        Unit - Change ownership of TempCaster to TempPlayer[MUIFix] and Change color
 

vypur85

Hibernate
Reaction score
803
Code:
        For each [B](Integer A)[/B] from 1 to 10, do (Actions)
            Loop - Actions
                Set TempPoint = (Random point in TempRegion)
                Set TempRegion2 = (Region centered at TempPoint with size (250.00, 250.00))
                Unit - Order TempCaster to Move To TempPoint
                For each [B](Integer A)[/B] from 1 to 15, do (Actions)
                    Loop - Actions
                        Wait 1.00 seconds
                        Set TempPoint2 = (Position of (Triggering unit))
                        For each (Integer B) from 1 to 4, do (Actions)
                            Loop - Actions
                                Special Effect - Create a special effect at (TempPoint2 offset by 50.00 towards (90.00 x (Real((Integer B)))) degrees) using Abilities\Spells\Human\Resurrect\ResurrectTarget.mdl
                                Special Effect - Destroy (Last created special effect)
                Wait until ((TempRegion2 contains TempCaster) Equal to True), checking every 0.10 seconds

You're using 1 Integer A loop inside another Integer A loop. And it's not a good idea to use waits inside Integer A/B loops. Use custom integer variable loop instead.
 

Fluffball

Well-Known Member
Reaction score
35
Thanks, +rep

Btw, how do you make a custom loop? I can't find it in the Variables section. JASS?
 
A

Andy

Guest
Rather than (Integer A), you use:
For each (Integer [Variable]) from x to x, do (Actions)
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +1
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top