Help Improving this little trigger

[xoxdragonxox]

Does it leak? Can anyone help me improve it so it runs more efficiently? and thanks + Rep!

• On and Off
  • Events
    • Unit - A unit Uses an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Light
  • Actions
    • Item - Remove (Item being manipulated)
    • Set T_Angle = (Facing of (Triggering unit))
    • Set T_Loc = (Position of (Triggering unit))
    • Set T_Loc2 = (T_Loc offset by 500.00 towards T_Angle degrees)
    • Unit - Create 1 LightEffect for (Owner of (Triggering unit)) at T_Loc2 facing T_Angle degrees
    • Set T_Light = (Last created unit)
    • Unit - Turn collision for T_Light Off
    • Unit Group - Add (Triggering unit) to T_Holders
    • Hashtable - Save Handle OfT_Light as (Key light) of (Key (Triggering unit)) in T_Hashtable
    • Set T_isOn = True
    • Hashtable - Save T_isOn as (Key boolean) of (Key (Triggering unit)) in T_Hashtable
    • Custom script: call RemoveLocation (udg_T_Loc)
    • Custom script: call RemoveLocation (udg_T_Loc2)

• Move
  • Events
    • Time - Every 0.04 seconds of game time
  • Conditions
    • (Number of units in T_Holders) Greater than 0
  • Actions
    • Unit Group - Pick every unit in T_Holders and do (Actions)
      • Loop - Actions
        • Set T_Angle = (Facing of (Picked unit))
        • Set T_Loc = (Position of (Picked unit))
        • Set T_Loc2 = (T_Loc offset by 500.00 towards T_Angle degrees)
        • Set T_Light = (Load (Key light) of (Key (Picked unit)) in T_Hashtable)
        • Unit - Move T_Light instantly to T_Loc2
        • Custom script: call RemoveLocation (udg_T_Loc)
        • Custom script: call RemoveLocation (udg_T_Loc2)

 

[Chaos_Knight]

• Unit - Create 1 LightEffect for (Owner of (Triggering unit)) at T_Loc2 facing T_Angle degrees

(Owner of (Triggering unit))
Leak. But MUI.

 

[tommerbob]

As far as I know, it does not leak.

@Chaos Knight: Since when does (owner of Triggering Unit) leak? I could be wrong, but I have never heard that before.

 

[Exide]

You're going to have a hard time improving this trigger with GUI.
-With JASS and vJASS you can improve it lots, though.

(Owner of (Triggering unit)) does not leak.

 

[R 3 T R O]

Could anyone kindly convert it to JASS, I tried to convert a simple When a unit dies with like 5 actions to JASS lol i had only 13 lines in the code and it said i had over 30 syntax errors

+rep n Credit xD to whom ever helps convert to jass. Note, I dont use newgen just regular WE

 

[canons200]

Owner of (Triggering unit) doesn't leak, i am very sure and i also can't find any leak in above trigger.

what do you mean by more efficient? any problem you encounter? Or in short, what do you expect from us to help you in????

 

[DuelPlayer]

• Unit - Create 1 LightEffect for (Owner of (Triggering unit)) at T_Loc2 facing T_Angle degrees

Special Effect leaked?

 

[canons200]

Unit - Create 1 LightEffect for (Owner of (Triggering unit)) at T_Loc2 facing T_Angle degrees

look at this action is obviously UNIT ACTION, not special effect.

 

[DuelPlayer]

look at this action is obviously unit action, not special effect.

yeah i missed it