Syntax problem

N

Nerfpl

New Member
Reaction score
53
on way of learning JASS with try&fail method i have another problem. this time weird because i thought its ok.

i have syntax error here
JASS:
function FrostWaveMissileHit takes nothing returns nothing
    if IsUnitEnemy(GetTriggerUnit(), GetOwningPlayer(FrostWaveCaster)) == true then
    call UnitDamageTargetBJ( FrostWaveCaster, GetTriggerUnit(), ( 0.50 * I2R(FrostWaveInt) ) * I2R(GetHeroStatBJ(bj_HEROSTAT_INT, FrostWaveCaster, true)), ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    endif
endfunction

function Trig_Frost_Wave_Actions takes nothing returns nothing
    local unit FrostWaveCaster = GetSpellAbilityUnit()
    local integer FrostWaveInt = GetUnitAbilityLevelSwapped('A00U', GetSpellAbilityUnit())
    local location FrostWavePos = GetUnitLoc(FrostWaveCaster)
    local location FrostWavePos2 = GetSpellTargetLoc()
    local integer x = 1
    local real value = 0
    local integer help = 1
    if ModuloInteger(FrostWaveInt, 2)==1 then
    call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, (AngleBetweenPoints(FrostWavePos, FrostWavePos2), 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
    loop exitwhen x > FrostWaveInt
        set value = value + help * 9 * x
        set help = 0 - help
        call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, (AngleBetweenPoints(FrostWavePos, FrostWavePos2) + value, 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
        set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
        set x = x + 1
    endloop
    else
    loop exitwhen x > FrostWaveInt
        set value = value + help * 11.25 * x
        set help = 0 - help
        call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, (AngleBetweenPoints(FrostWavePos, FrostWavePos2) + value, 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
        set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
        set x = x + 1
    endloop
    endif
    call RemoveLocation(FrostWavePos)
    call RemoveLocation(FrostWavePos2)
    set FrostWavePos = null
    set FrostWavePos2 = null
    set FrostWaveCaster = null
endfunction


also i want to ask if my func "FrostWaveMissileHit" can be under actions trigger? or it dosent matter? (because i use it in actions but event of hit which calls it happen after actions)

and last question is if i need to really use I2R here?
set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
 
K

Kenny

Back for now.
Reaction score
202
also i want to ask if my func "FrostWaveMissileHit" can be under actions trigger? or it dosent matter? (because i use it in actions but event of hit which calls it happen after actions)
Click to expand...

It still has to be above.

and last question is if i need to really use I2R here?
set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
Click to expand...

No not really, integer and real comparisons are okay for most circumstances. In your case it is fine.

JASS:
function FrostWaveMissileHit takes nothing returns nothing
    if IsUnitEnemy(GetTriggerUnit(), GetOwningPlayer(FrostWaveCaster)) == true then
    call UnitDamageTargetBJ( FrostWaveCaster, GetTriggerUnit(), ( 0.50 * I2R(FrostWaveInt) ) * I2R(GetHeroStatBJ(bj_HEROSTAT_INT, FrostWaveCaster, true)), ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    endif
endfunction


FrostWaveCaster does not exist in that function, you will probably need to trasnfer it using a global unit. Also that UnitDamageTargetBJ() can become UnitDamageTarget() and that GetheroStatBJ() can become GetHeroInt(Hero,true).
 
N

Nerfpl

New Member
Reaction score
53
ok thanks for tips, but i still have syntax error :/ i think something with if, because syntax error always point 1 line after

about caster:
so can i simply use wait now about 5 seconds, and then null caster? or local keeps info per function?
(i baicly converted whole spell from global to local just to make it MUI -_-)
 
K

Kenny

Back for now.
Reaction score
202
so can i simply use wait now about 5 seconds, and then null caster? or local keeps info per function?
Click to expand...

Local variables can only be accessed in the function they were created, therefore FrostWaveCaster does not exist at all, and never will, unless you use a global unit.

Do you have NewGen?
 
B

Builder Bob

Live free or don't
Reaction score
249
Nerfpl said:
so what with the if? or wheres syntax error? everything seems fine for me
Click to expand...

all your CollisionMissile_CreateLoc have a ( which doesn't belong before AngleBetweenPoints.
exitwhen must be placed on a line below loop

Fixed:
JASS:
function FrostWaveMissileHit takes nothing returns nothing
    if IsUnitEnemy(GetTriggerUnit(), GetOwningPlayer(FrostWaveCaster)) == true then
    call UnitDamageTargetBJ( FrostWaveCaster, GetTriggerUnit(), ( 0.50 * I2R(FrostWaveInt) ) * I2R(GetHeroStatBJ(bj_HEROSTAT_INT, FrostWaveCaster, true)), ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    endif
endfunction

function Trig_Frost_Wave_Actions takes nothing returns nothing
    local unit FrostWaveCaster = GetSpellAbilityUnit()
    local integer FrostWaveInt = GetUnitAbilityLevelSwapped('A00U', GetSpellAbilityUnit())
    local location FrostWavePos = GetUnitLoc(FrostWaveCaster)
    local location FrostWavePos2 = GetSpellTargetLoc()
    local integer x = 1
    local real value = 0
    local integer help = 1
    if ModuloInteger(FrostWaveInt, 2)==1 then
    call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, AngleBetweenPoints(FrostWavePos, FrostWavePos2), 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
    loop
	    exitwhen x > FrostWaveInt
        set value = value + help * 9 * x
        set help = 0 - help
        call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, AngleBetweenPoints(FrostWavePos, FrostWavePos2) + value, 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
        set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
        set x = x + 1
    endloop
    else
    loop
	    exitwhen x > FrostWaveInt
        set value = value + help * 11.25 * x
        set help = 0 - help
        call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, AngleBetweenPoints(FrostWavePos, FrostWavePos2) + value, 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
        set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
        set x = x + 1
    endloop
    endif
    call RemoveLocation(FrostWavePos)
    call RemoveLocation(FrostWavePos2)
    set FrostWavePos = null
    set FrostWavePos2 = null
    set FrostWaveCaster = null
endfunction
 
N

Nerfpl

New Member
Reaction score
53
exactly this code have somewhere syntax error. after i delete it, Jhelper dont report errors
JASS:
if ModuloInteger(FrostWaveInt, 2) == 1 
    then
        call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, AngleBetweenPoints(FrostWavePos, FrostWavePos2), 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
        loop exitwhen x > FrostWaveInt
            set value = value + help * 9 * x
            set help = 0 - help
            call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, AngleBetweenPoints(FrostWavePos, FrostWavePos2) + value, 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
            set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
            set x = x + 1
        endloop
    else
        loop exitwhen x > FrostWaveInt
            set value = value + help * 11.25 * x
            set help = 0 - help
            call CollisionMissile_CreateLoc("war3mapImported\\FrozenOrb.MDX", FrostWavePos, AngleBetweenPoints(FrostWavePos, FrostWavePos2) + value, 800, 0, ( 200 + (FrostWaveInt * 80)), 30, false, 50, function FrostWaveMissileHit)
            set FrostWaveReal = ( FrostWaveReal + ( 90.00 / I2R(FrostWaveInt) ) )
            set x = x + 1
        endloop
    endif

btw. is there way to store global variable of type code?

edit: ok i removed brackets but still have error syntax... even if i make "IF 1 == 1"
 
B

Builder Bob

Live free or don't
Reaction score
249
Nerfpl said:
yes i did now it works. what you did? i thought like it dosent matter if exitwhen is at begining or even at end :/
Click to expand...

exitwhen can be anywhere within the loop, that is correct. Just not on the same line as loop or endloop.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    New recipe is Cheeseburger Pie! https://www.thehelper.net/threads/recipe-cheeseburger-pie.194191/

      The Helper Discord

      Staff online

      Members online

      Online now:
      201 (members: 3, guests: 198)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top