First Jass script laggy.

Chewbalka

Chewbalka

New Member
Reaction score
14
This is my first JASS Script, also it is a JASS version of a GUI system i created, Cone Vision.

Firstly i used "Convert to Custom Text" as a starting point so i didint have to actuall re-write everything. I then reduced it from about 50 functions to 3 and I put all loops into local variables. other then that its almost exactly the same as after conversion.

The problem with this code is that it has more lag then the GUI version. Meaning I can run less units (in the unit group) before lag starts appearing. In the original (GUI) I had 24 units before lag starts with this one I have 18 and its already slightly noticeable.

What can be changed to reduce the lag/performance?

If your to test this script you will need to create the same varaibles as the GUI version needs, these variables are not local.

  • VISCount int
  • VISGroup UnitGroup
  • VISLocation Point
  • VISTest Visibility Modifier (Array)


JASS:
function Trig_Vision_pathing takes nothing returns boolean
    if ( IsTerrainPathableBJ(udg_VISLocation, PATHING_TYPE_WALKABILITY) == true ) then
    	if ( IsTerrainPathableBJ(udg_VISLocation, PATHING_TYPE_FLOATABILITY) == true ) then
        	return true
    	endif
    endif
    return false
endfunction

function Trig_Vision_main takes nothing returns nothing
    local integer forLoopAIndex = 0
    local integer forLoopAIndexEnd = 0
    if ( IsUnitDeadBJ(GetEnumUnit()) == true ) then
        return
    else
    endif
    set udg_VISCount = ( udg_VISCount + 1 )
    // 1
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 50.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 150.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
    set forLoopAIndex = 50
    set forLoopAIndexEnd = 100
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
  	 if ( Trig_Vision_pathing () ) then
            set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), I2R(forLoopAIndex), GetUnitFacing(GetEnumUnit()))
        	call RemoveLocation (udg_VISLocation)
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
            else
                return
            endif
        else
        endif
        set forLoopAIndex = forLoopAIndex + 2
    endloop
    // 2
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 100.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 225.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
    set forLoopAIndex = 100
    set forLoopAIndexEnd = 200
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
  	 if ( Trig_Vision_pathing () ) then
            set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), I2R(forLoopAIndex), GetUnitFacing(GetEnumUnit()))
        	call RemoveLocation (udg_VISLocation)
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
            else
                return
            endif
        else
        endif
        set forLoopAIndex = forLoopAIndex + 2
    endloop
    // 3
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 200.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 300.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
    set forLoopAIndex = 200
    set forLoopAIndexEnd = 310
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
  	 if ( Trig_Vision_pathing () ) then
            set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), I2R(forLoopAIndex), GetUnitFacing(GetEnumUnit()))
        	call RemoveLocation (udg_VISLocation)
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
            else
                return
            endif
        else
        endif
        set forLoopAIndex = forLoopAIndex + 2
    endloop
    // 4
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 310.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 400.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
    call RemoveLocation (udg_VISLocation)
    set forLoopAIndex = 310
    set forLoopAIndexEnd = 475
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
  	 if ( Trig_Vision_pathing () ) then
            set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), I2R(forLoopAIndex), GetUnitFacing(GetEnumUnit()))
        	call RemoveLocation (udg_VISLocation)
            if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
            else
                return
            endif
        else
        endif
        set forLoopAIndex = forLoopAIndex + 2
    endloop
    // 5
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 475.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 400.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
    call RemoveLocation (udg_VISLocation)
    set forLoopAIndex = 475
    set forLoopAIndexEnd = 600
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
  	 if ( Trig_Vision_pathing () ) then
            set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), I2R(forLoopAIndex), GetUnitFacing(GetEnumUnit()))
        	call RemoveLocation (udg_VISLocation)
            if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
            else
                return
            endif
        else
        endif
        set forLoopAIndex = forLoopAIndex + 2
    endloop
    // 6
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 600.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 480.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
    call RemoveLocation (udg_VISLocation)
    set forLoopAIndex = 600
    set forLoopAIndexEnd = 850
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
  	 if ( Trig_Vision_pathing () ) then
            set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), I2R(forLoopAIndex), GetUnitFacing(GetEnumUnit()))
        	call RemoveLocation (udg_VISLocation)
            if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
            else
                return
            endif
        else
        endif
        set forLoopAIndex = forLoopAIndex + 2
    endloop
    // 7
    call RemoveLocation (udg_VISLocation)
    set udg_VISLocation = PolarProjectionBJ(GetUnitLoc(GetEnumUnit()), 750.00, GetUnitFacing(GetEnumUnit()))
   if ( Trig_Vision_pathing () ) then
        	if ( ( GetTerrainCliffLevelBJ(udg_VISLocation) <= GetTerrainCliffLevelBJ(GetUnitLoc(GetEnumUnit())) ) )then
        else
            return
        endif
    else
        call CreateFogModifierRadiusLocBJ( true, GetOwningPlayer(GetEnumUnit()), FOG_OF_WAR_VISIBLE, udg_VISLocation, 550.00 )
        set udg_VISTest[udg_VISCount] = GetLastCreatedFogModifier()
        set udg_VISCount = ( udg_VISCount + 1 )
    endif
endfunction

function Trig_ConeVision_Actions takes nothing returns nothing
    local integer forLoopAIndex = 0
    local integer forLoopAIndexEnd = 0
    set forLoopAIndex = 1
    set forLoopAIndexEnd = ( CountUnitsInGroup(GetUnitsOfPlayerAll(Player(0))) * 7 )
    loop
        exitwhen forLoopAIndex > forLoopAIndexEnd
        call FogModifierStop( udg_VISTest[forLoopAIndex] )
        call DestroyFogModifier( udg_VISTest[forLoopAIndex] )
        set forLoopAIndex = forLoopAIndex + 1
    endloop
    call RemoveLocation (udg_VISLocation)
    call DestroyGroup (udg_VISGroup)
    set udg_VISGroup = GetUnitsOfPlayerAll(Player(0))
    call ForGroupBJ( udg_VISGroup, function Trig_Vision_main )
    set udg_VISCount = 1
endfunction

//===========================================================================
function InitTrig_ConeVision takes nothing returns nothing
    set gg_trg_ConeVision = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_ConeVision, 0.50 )
    call TriggerAddAction( gg_trg_ConeVision, function Trig_ConeVision_Actions )
endfunction
 
tommerbob

tommerbob

Minecraft. :D
Reaction score
110
I recommend reading up on how to use vJass and structs and such. It is a longer fix to your problem than maybe you want, but once you start using vJass, your scripting life will dramatically improve. This is coming from someone who was a staunch GUI user, and now I am a happy vJass user. Just my two cents. :)
 
Dirac

Dirac

22710180
Reaction score
147
I used to be a very unhappy GUI user who couldn't move up to JASS becuase I had a Mac (newgen only runs on windows), but now i'm god.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Members online

      No members online now.
      Online now:
      301 (members: 0, guests: 301)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top