Need big help to optimize this spell

[Sgqvur]

test it with 100 instead: if GetRandomInt(1, 100) <= 100 then
Edit:
in this function where do you set
private function Actions takes nothing returns boolean

local integer level
to some value?

Edit2:
That's curious....for it to display 1 but not 2 :/

 

[Immolation]

test it with 100 instead: if GetRandomInt(1, 100) <= 100 then

Doesn't work.

~Immolation

 

[GetTriggerUnit-]

From what I see, your "level" local isn't set anywhere so it simply does not work.

Condition are faster than actions.

#1 Everyone says it.

#2 It's logical. WarcraftIII must pass conditions before actions, to see if the condition was respected...

 

[Azlier]

>From what I see, your "level" local isn't set anywhere so it simply does not work.

I spent so much time looking for uninitialized locals. Guess I missed that one.

>Condition are faster than actions.

Let's not forget that conditions don't need to start a whole new thread to run on. Actions do that so TriggerSleepAction can be used.

 

[GetTriggerUnit-]

I wish of TriggerSleepCondition <3

 

[Azlier]

Yes. And TriggerSleepCondition shall be accurate, efficient, and overall magical.

 

[Immolation]

Thanks alot both of you.

~Immolation

 

[Viikuna]

Yea, Conditions are fatser because of this.

Let's not forget that conditions don't need to start a whole new thread to run on. Actions do that so TriggerSleepAction can be used.

And TriggerSleepAction sucks anyways. At least when used for waiting. Its supposed to be used when you do loads of shit at once, not for waiting like GUI users use it.

Timers do that stuff much more smoother and nicer.

 

[SanKakU]

so are you guys saying that a condition and an action can be combined into a condition that is also an action?

i already knew you could put in if instead of using a condition, not sure if that's preferred or what...but i hadn't thought of making it take or return boolean or whatever to make it a formal condition and not have a normal action. isn't that what's suggested here?

 

[saw792]

Yep. Instead of:

function Cond takes nothing returns boolean
  return <something>
endfunction

You have:

function Cond takes nothing returns boolean
  if <something> then
    call KillUnit(GetTriggerUnit())
  endif
  return false
endfunction