Problem with attaching to Unit and Timer (together)

[Faust]

Hey. I'm creating a small, damage over time system for a race in my map.
Using PUI and ABC.
I'm trying to test it with an archer, that has Poison Arrows -like ability (so I can check for buff).
When I damage a unit with an attack, it should create a struct for it, if the struct already exists, modify some of its components (lastAttacker and FlameLevel).

The problem is, it always creates a new struct, so instead of having a value of the struct increase on each attack, it just has multiple struct instances with unchanged variable values.

This is the struct with the methods:

scope Burn// initializer I

struct Burn
    //! runtextmacro PUI()
    unit victim
    unit lastAttacker
    timer clock = CreateTimer()
    real FlameLevel = 0
    effect array FlameEffect [2]
    
    method DestroyEffects takes nothing returns nothing
        call DestroyEffect(.FlameEffect[0])
        call DestroyEffect(.FlameEffect[1])
    endmethod
    
    method CalculateEffect takes unit u, real r returns nothing
    local integer i = 0
    call .DestroyEffects()
    if r >= 66 then
     set .FlameEffect[0] = CreateEffectOnUnit("Environment\\LargeBuildingFire\\LargeBuildingFire1.mdl", u, "origin")
     set .FlameEffect[1] = CreateEffectOnUnit("Environment\\LargeBuildingFire\\LargeBuildingFire1.mdl", u, "chest")
    elseif r >= 33 and r < 66 then
     set .FlameEffect[0] = CreateEffectOnUnit("Environment\\LargeBuildingFire\\LargeBuildingFire2.mdl", u, "origin")
     set .FlameEffect[1] = CreateEffectOnUnit("Environment\\LargeBuildingFire\\LargeBuildingFire2.mdl", u, "chest")
    elseif r < 33 then
     set .FlameEffect[0] = CreateEffectOnUnit("Environment\\SmallBuildingFire\\SmallBuildingFire2.mdl", u, "origin")
     set .FlameEffect[1] = CreateEffectOnUnit("Environment\\SmallBuildingFire\\SmallBuildingFire2.mdl", u, "chest")
    endif
    endmethod
    
    method onDestroy takes nothing returns nothing
        call PauseTimer(.clock)
        call ClearTimerStructA(.clock)
        call DestroyTimer(.clock)
        call DestroyEffect(.FlameEffect[0])
        call DestroyEffect(.FlameEffect[1])
    endmethod
    
static method Burning takes nothing returns nothing
    local Burn dat = GetTimerStructA(GetExpiredTimer())
    local real r
    if dat.FlameLevel > 100 then
     set dat.FlameLevel = 100
    endif
    set r = dat.FlameLevel + ((dat.FlameLevel / 2000) * GetUnitState(dat.victim, UNIT_STATE_MAX_LIFE))
    call DisableTrigger(GetTriggeringTrigger())
    call DamageTarget(dat.lastAttacker, dat.victim, r, false, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MAGIC, WEAPON_TYPE_WHOKNOWS)
    call EnableTrigger(GetTriggeringTrigger())
    call BJDebugMsg("Flamelevel: " + R2S(dat.FlameLevel))
    call dat.CalculateEffect(dat.victim, dat.FlameLevel)
    if dat.FlameLevel < 1 or GetWidgetLife(dat.victim) < 1 or dat.victim == null then
      call UnitRemoveAbility(dat.victim, 'A02F')
      call dat.release()
    endif
    if dat.FlameLevel < 33 then
     set dat.FlameLevel = dat.FlameLevel - 5
    endif
endmethod

static method create takes unit Victim, unit LastAttacker returns Burn
    local Burn dat = Burn.allocate()
    set dat.victim = Victim
    set dat.lastAttacker = LastAttacker
    call UnitAddAbility(Victim, 'A02F')
    set Burn[dat.victim] = dat
    call SetTimerStructA(dat.clock, dat)
    call TimerStart(dat.clock, 1, true, function Burn.Burning)
    return dat
endmethod

endstruct
endscope

This is the trigger for using the ability (ignore the item conditions and actions, not relevant):

scope FlamingArrows initializer I

private function C1 takes nothing returns boolean
    return GetUnitAbilityLevel(GetTriggerUnit(), 'B00S') > 0
endfunction

private function C2 takes nothing returns boolean
    return GetItemTypeId(GetSoldItem()) == 'I00B'
endfunction

private function A2 takes nothing returns nothing
    set TempItem = GetSoldItem()
    call RemoveItemFromStock(GetSellingUnit(), 'I00B')
    call UnitRemoveItem(GetTriggerUnit(), TempItem)
    call RemoveItem(TempItem)
    call UnitAddAbility(GetSellingUnit(), 'A02E')
endfunction

private function A1 takes nothing returns nothing
    local Burn dat = GetTriggerUnit():Burn
    call UnitRemoveAbility(GetTriggerUnit(), 'B00S')
    if dat == null then
     set dat = Burn.create(GetTriggerUnit(), GetEventDamageSource())
    endif
    set dat.lastAttacker = GetEventDamageSource()
    set dat.FlameLevel = dat.FlameLevel + GetUnitPointValue(dat.lastAttacker)
    call dat.CalculateEffect(dat.victim, dat.FlameLevel)    
endfunction

//===========================================================================
private function I takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitDamaged(t)
    call TriggerAddCondition(t, Condition(function C1))
    call TriggerAddAction(t, function A1)
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEvent(t,  EVENT_PLAYER_UNIT_SELL_ITEM)
    call TriggerAddCondition(t, Condition(function C2))
    call TriggerAddAction(t, function A2)
endfunction

endscope

So, what should I do?

 

[Faust]

Important bump

 

[Faust]

Anybody here?

 

[Troll-Brain]

I don't use PUI and neither ABC, so i don't look your code, maybe it's the same for many others.

 

[Faust]

That's bullshit and you know it.

 

[cleeezzz]

from my experience from PUI, what is this?

    local Burn dat = GetTriggerUnit():Burn

shouldn't it be

    local Burn dat = Burn[GetTriggerUnit()]

?

 

[Troll-Brain]

That's exactly the same (colon operator), read the jasshelper documentation.

 

[cleeezzz]

oh and also, if theres no stuct attached the the trig unit, shouldn't dat == 0? not null? but since you said it creates the struct every time, then i dont know

 

[Faust]

Hmmm, odd. I always used dat == null, but dat == 0 indeed fixied it Thank you!

 

[cleeezzz]

O_O *baffled*

thats weird because, it create the struct when dat == null.. when it was really 0

wonder how it passed the condition