Questions regarding the 1.24 patch disaster and how to fix a map

[Ouguiya]

Hello everyone!

As almost all of you may know, the 1.24 patch was a complete disaster on many maps.

Now, in a desperate effort to fix mine, I would like to ask a few questions, which I hope some of you can answer.

1. GUI-Editability: The first question concerns editing the map with the GUI-Trigger-editor. The map I am trying to save from oblivion is almost completely GUI, with a few small exceptions. Supposed that I remove ALL custom JASS code, would the map work completely or is even GUI messed up and a danger?
2. JASS question: I have a few things which are JASS, unfortunatly. I cannot really delete them or substitute them for other things. What I need to know is: What things in JASS cause the map to become unplayable, and how can I fix it
3. Can anything else besides the triggers cause the map to become unplayable, provided that it worked before the patch was out. (Things like custom models, object editor negative values etc.)
4. Does JASS Newgen pack still work, or will it automatically cause it the map to become unplayable?
5. Does vJASS still work, or has Blizzard screwed this up as well?

Thanks and +rep for a good answer to any of the questions.

Yours,

Ouguiya

 

[Renendaru]

Question what, if any, systems in v/Jass are you using. Pure GUI will work aside from shadowing global variables.

 

[Larcenist]

The things to look out for when it comes to JASS is basically returns now. If you have something like this:

function H2I takes handle h returns integer
    return h
    return 0
endfunction

Or something like this:

if (Conditions) then
    return x
elseif (conditions) then
    return y
else
    return z
endif

You would have to replace them.

> Note: I think it's quite wierd that so many people have been affected by this patch, and I haven't seen any problems, at all, with any of my maps :S That's kinda wierd I think, lol XD

Same here. I patched and NewGen and whatnot worked just as planned. Only thing I had to do was replace a single H2I function.

 

[Komaqtion]

1. As far as I know, GUI should be working completely as normal Though if you're using EGUI, that won't work

2. Check out the many threads about this in the JASS Forum, there you should find your answer
Though there are some things I know of, for example that "elseif"s doesn't work always anymore, and the "return bug" H2I won't work either Though if there aren't that much JASS in your map, maybe post it and I might be able to help

3. Don't think so... Have you imported anything after the patch ?

4. Yepp, should be working as normal

5. Yes, same here

Note: I think it's quite wierd that so many people have been affected by this patch, and I haven't seen any problems, at all, with any of my maps :S That's kinda wierd I think, lol XD

 

[Ouguiya]

Hello there!

Thanks for the quick reply.

I am using (in vJASS) the system "Table", which can be found on WC3C, and I have been using 2.0, but will be using 3.0 now, since this is the version released for the new patch. (http://www.wc3c.net/showthread.php?t=101246)

Aside from that, I am using Troll-Brain's system for resource trading detectiong (http://www.wc3c.net/showthread.php?t=101590).

And finally, but I am not certain that this is vJASS (I am a complete newbie when it comes to JASS), a trigger provided to me by trb92, found in: http://www.thehelper.net/forums/showthread.php?t=131685&highlight=resource


I have one question also: What does "shadowing global variables" mean? (Again, I am not really a pro when it comes to these things...)

Thanks again.

Yours,

Ouguiya

 

[Renendaru]

Not so sure, but I've heard it's psedo-local vars in GUI, I think.

• Custom Script: local unit u = GetTriggerUnit()

 

[Ouguiya]

Ok, but this would entail using a "custom script", thus using JASS again.

However, if I use GUI, there is no problem at all, even if the map is loaded with "If/then/else" functions?

Sry for asking this again, but I want to make sure that if I start working on that (which will be a huge amount of work), that it will not be in vain.

Thanks,

Yours,

Ouguiya

 

[Scary Nachos]

I THINK you should be finem that is GUI again.... and custom script should be fine, besides the one above?

 

[Troll-Brain]

Meh i won't wait for a new patch so, i will update my code, at least one actually have the need.

 

[Rainther]

GUI doesn't use return. (Of course they do with conditions etc. unnoticeable but not in a customized way like returning in an else if) So don't worry about if then else in GUI.

 

[Ouguiya]

Hello everyone!

I wanted to say a big thanks to all the ones who posted replies, and also, a big thanks to Troll-Brain for posting and (maybe) updating his system, this could just be what saves me map from oblivion.


One last question: Does anyone know if the WEU-Functions (which are automatically imbedded in the map header when a map is generated with WEU), conflict with the new patch, or not?

The bits and pieces from what I could understand from the JASS-code, it uses a lot of if then else functions, but I don't really know if they return something.

Thanks again.

Yours,

Ouguiya

 

[UndeadDragon]

I am not too sure whether WEU uses H2I, but I would avoid using WEU anyway. It is outdated.

 

[Ouguiya]

Easier said than done, especially for someone who has no clue about how to program the functions which WEU provides, or have any alternatives (EGUI has also been blown out of the sky by 1.24 I believe, and I currently have no alternatives to for example only play sound to one specific player etc.)

However, no, it does not use the H2I, I already checked the entire syntax.

What it does use plentiful is If then Else functions (naturally), but I don't know if these are "good" or "bad"

Thanks again.

Yours,

Ouguiya

 

[cleeezzz]

look up sevion's 1.24 conversion tutorial, it will tell you what to look out for.