Simple Sum problem with jass

[exge]

im just starting JASS and i ran into problems even with a simple script like this :banghead: :banghead: :banghead: :banghead: :banghead:

function Trig_SumOfInt_Actions takes nothing returns integer
local integer firstNum
    local integer secondNum
    local integer sum = firstNum + secondNum
return sum
   
endfunction

function Trig_ShowSum takes integer sum_Actions returns string
    call DisplayTextToForce(GetPlayersAll(),"sum is " + sum)
endfunction

//===========================================================================
function InitTrig_SumOfInt takes nothing returns nothing
    set gg_trg_SumOfInt = CreateTrigger(  )
    call TriggerRegisterPlayerEventEndCinematic( gg_trg_SumOfInt, Player(0) )
    call TriggerAddAction( gg_trg_SumOfInt, function Trig_SumOfInt_Actions )
endfunction

I know this code has no real use in WE but i want to know why doesnt it compile

 

[SFilip]

this code is confusing. first of all trigger actions can't take anything.
second it seems that you never used Trig_ShowSum.
it seems Trig_ShowSum is supposed to return a string, but never does - you just call a function in it. also you never defined variable sum in it, the one it should take is called sum_Actions for you.
besides...

local integer firstNum
    local integer secondNum
    local integer sum = firstNum + secondNum

these numbers aren't set...it will probably just return 0.

 

[exge]

hmm .. well .. ok then ..... this is my 2nd script , 1st being the classic hello world ... can you show me how to fix this assume that the 2 ints have values

 

[Chocobo]

function Trig_SumOfInt_Actions takes integer a, takes integer b returns integer
local integer firstNum = a
    local integer secondNum = b
    local integer sum = firstNum + secondNum
return sum
   
endfunction

To use it : Trig_SumOfInt_Actions( the integer a, the intger b)
Example : Trig_SumOfInt_Actions( 1, 3)
Returns : 4

 

[exge]

thx ... +rep to all

 

[SFilip]

function Trig_SumOfInt_Actions takes integer a, takes integer b returns integer
local integer firstNum = a
    local integer secondNum = b
    local integer sum = firstNum + secondNum
return sum
   
endfunction

To use it : Trig_SumOfInt_Actions( the integer a, the intger b)
Example : Trig_SumOfInt_Actions( 1, 3)
Returns : 4

can be simply...

function Trig_SumOfInt_Actions takes integer a, takes integer b returns integer
    return a + b   
endfunction

 

[AceHart]

Or just display
"Sum is: " + I2S(a + b)


But, well, it's a bit of playing around with functions...

 

[Chocobo]

can be simply...

function Trig_SumOfInt_Actions takes integer a, takes integer b returns integer
    return a + b   
endfunction

I would say Integer to String because it is a message.

function Trig_SumOfInt_Actions takes integer a, takes integer b returns [B]string[/B]
    return I2S(a + b )
endfunction

Edit : 0 Reputation member gives 1 Reputation point?

 

[SFilip]

> Edit : 0 Reputation member gives 1 Reputation point?
yeah

 

[AceHart]

While on the subject of testing, locals and weird functions:

Assuming the following trigger:

TryMe
    Events
        Player - Player 1 (Red) skips a cinematic sequence
    Conditions
    Actions
        Custom script:   call TryMe()

and this function:

function TryMe takes nothing returns nothing
    local integer a = 0
    local integer b = 0
    local integer c = 1
    local integer count = 0

    loop
        set count = count + 1
        set a = b
        set b = c
        set c = a + b
        exitwhen c < a
    endloop

    call DisplayTextToForce( GetPlayersAll(), "Result: " + I2S(count))
endfunction

Would this function stop? Or run an endless loop, before it hits the trigger execution time limit?

In case it would finish, what result do you expect? What do you get?


Think about it first, before trying it if you want or need to...

 

[exge]

> Edit : 0 Reputation member gives 1 Reputation point?
yeah

is it ? i didn't know that .. lol
i have 3 rep but its not said ....
o well .. thats life

 

[Chocobo]

> Edit : 0 Reputation member gives 1 Reputation point?
yeah

Sometimes with 0 reputation people, they +rep me but I gain 0 rep points ^^

Edit : There is people with 0 reputation who has red boxes, green boxes, or grey boxes? Is it normal?

 

[dArKzEr0]

Nice one Ace. I'm guessing it loops until the maximum value for an integer is reached, then c become negative and less than a?

-darkz

Edit://
I just tested it in java with the following program:

public class integers
{
    public static void main (String[ ] args)
    {
        int a=0, b=0, c=1, count=0;
        do
        {
            a=b; b=c; c=a+b;
            count++;
            if(count%5==1)
            System.out.println("a = "+a+"; b = "+b+"; c = "+c+"; count = "+ count);
        }
        while(c>a);
        System.out.println("final count = "+ count);
    }
}

And got:

a = 0; b = 1; c = 1; count = 1
a = 5; b = 8; c = 13; count = 6
a = 55; b = 89; c = 144; count = 11
a = 610; b = 987; c = 1597; count = 16
a = 6765; b = 10946; c = 17711; count = 21
a = 75025; b = 121393; c = 196418; count = 26
a = 832040; b = 1346269; c = 2178309; count = 31
a = 9227465; b = 14930352; c = 24157817; count = 36
a = 102334155; b = 165580141; c = 267914296; count = 41
a = 1134903170; b = 1836311903; c = -1323752223; count = 46
final count = 46

Is it the same for JASS?

 

[SFilip]

Sometimes with 0 reputation people, they +rep me but I gain 0 rep points ^^

Edit : There is people with 0 reputation who has red boxes, green boxes, or grey boxes? Is it normal?

only the ones with a gray box actually have 0 rep. people with green boxes have reputation lower than 5 (since the first "title" is 5+ i think) and people with red boxes have -1 reputation (since the first negative title is -2).

 

[Chocobo]

only the ones with a gray box actually have 0 rep. people with green boxes have reputation lower than 5 (since the first "title" is 5+ i think) and people with red boxes have -1 reputation (since the first negative title is -2).

Some of them have 0 rep and have red/green boxes. (<whatever> has zero reputation)

 

[exge]

i did the code in java too ..
looks like another java programmer .... btw do you know jass, and if so, did knowing java help ??
i just checked , now i know why, iqchicken gave my -rep for NO Reason ...

 no reason, just like you gave me...

although he nv posted in my threads ??? :nuts: :nuts: