Is there a better way to do this trigger? will it even work?

[a j j bones]

im making a dungeon system for my map so when a player enters a cave he is sent to the dungeon and when he gets to a certain point in the dungeon waves of creeps will spawn. the difficulty depends on how many players are in the cave.

cave 1 enter
    Events
        Unit - A unit enters cave 1 enter <gen>
    Conditions
        ((Entering unit) is A Hero) Equal to True
    Actions
        Set Cave2_enter = cave 2 enter <gen>
        Unit - Move (Entering unit) instantly to (Center of Cave2_enter)
        Camera - Pan camera for (Owner of (Entering unit)) to (Center of Cave1Exit) over 0.00 seconds
        Set Players_Entering_Dungeon = (Players_Entering_Dungeon + 1)
        Player Group - Add (Owner of (Entering unit)) to Dungeon_1_player_group
        Custom script:   call RemoveLocation (udg_Cave2_enter)

dungeon 1 start
    Events
        Unit - A unit enters Dungeon 1 Start <gen>
    Conditions
        ((Entering unit) is A Hero) Equal to True
    Actions
        Game - Display to Dungeon_1_player_group for 30.00 seconds the text: |CFFFF0000Hahaha|R,...
        Wait 15.00 seconds
        Game - Display to Dungeon_1_player_group for 5.00 seconds the text: |CFFFF000045|R Seco...
        Wait 15.00 seconds
        Game - Display to Dungeon_1_player_group for 5.00 seconds the text: |CFFFF000030|R Seco...
        Wait 15.00 seconds
        Game - Display to Dungeon_1_player_group for 5.00 seconds the text: |CFFFF000015|R Seco...
        Wait 15.00 seconds
        Game - Display to Dungeon_1_player_group for 3.00 seconds the text: The Battle will now...
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Players_Entering_Dungeon Less than or equal to 2
            Then - Actions
                Set R_Dungeon1_Creep_Spawn = (Center of Dungeon1 Creep Spawn <gen>)
                Unit - Create 1 Crystal Arachnathid for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                Unit - Create 1 Crystal Arachnathid for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                Unit - Create 1 Crystal Arachnathid for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                Game - Display to Dungeon_1_player_group the text: |CFFFF00003Wave 1
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Number of units in (Units in Dungeon 1 Fog <gen>)) Less than or equal to 2
                    Then - Actions
                        Game - Display to Dungeon_1_player_group the text: |CFF18BE00Congradul...
                        Wait 10.00 seconds
                        Game - Display to Dungeon_1_player_group the text: Beginning |CFFFF000...
                        Unit - Create 1 Blue Dragonspawn Meddler for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                        Unit - Create 1 Blue Dragonspawn Meddler for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Number of units in (Units in Dungeon 1 Fog <gen>)) Less than or equal to 2
                            Then - Actions
                                Game - Display to Dungeon_1_player_group the text: |CFF18BE00Congradul...
                                Wait 10.00 seconds
                                Game - Display to Dungeon_1_player_group the text: Beginning |CFFFF000...
                                Unit - Create 1 Blue Dragonspawn Apprentice for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                                Unit - Create 1 Blue Dragonspawn Apprentice for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        (Number of units in (Units in Dungeon 1 Fog <gen>)) Less than or equal to 2
                                    Then - Actions
                                        Game - Display to Dungeon_1_player_group the text: |CFF18BE00Congradul...
                                        Wait 10.00 seconds
                                        Game - Display to Dungeon_1_player_group the text: Beginning Final rou...
                                        Unit - Create 1 Tuskarr Chieftain for Neutral Hostile at (Random point in Dungeon1 Creep Spawn <gen>) facing Default building facing degrees
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                (Number of units in (Units in Dungeon 1 Fog <gen>)) Less than or equal to 2
                                            Then - Actions
                                                Game - Display to Dungeon_1_player_group the text: |CFF18BE00Nooooo!|R...
                                            Else - Actions
                                    Else - Actions
                            Else - Actions
                    Else - Actions
            Else - Actions

 

[Exide]

Looks like it works.
It also looks a bit messy, though.
The spawning in the second trigger. You should break it up into 2 triggers. One to start and one to spawn.
You could also use a spawn index.

spawn index
    Events
    Conditions
    Actions
        If (Level Equal to 1) then do (Set spawn_unit = Footman) else do (Do nothing)
        If (Level Equal to 2) then do (Set spawn_unit = Knight) else do (Do nothing)
        If (Level Equal to 3) then do (Set spawn_unit = Gryphon Rider) else do (Do nothing)

So that every time the players beats a wave, the level increases by 1 and the spawn index is run. Then you spawn 'x amount spawn_unit' with your spawn trigger. Ought to make it less messy.

 

[Bluewind]

        Custom script:   call RemoveLocation (udg_Cave2_enter)

Doesn't that remove the real location? (cave 2 enter <gen>)

 

[Exide]

Nope, it removes the point in the variable.

 

[a j j bones]

for some reason the jasschecker is saying that that first trigger is wrong the remove location part, does anyone see somthing wrong with it?

 

[AceHart]

> Nope, it removes the point in the variable.

Well, no, it doesn't.

Cave2_enter should be a variable of type "point", not "region".
Set it to "center of <region>".
Once done, it works as it should, including the custom script line.