System Custom Cooldown System

Narks

Vastly intelligent whale-like being from the stars
Reaction score
90
The term magic number or magic constant also refers to the programming practice of using numbers directly in source code. This has been referred to as breaking one of the oldest rules of programming, dating back to the COBOL, FORTRAN and PL/1 manuals of the 1960s. The use of unnamed magic numbers in code obscures the developers' intent in choosing that number, increases opportunities for subtle errors (e.g. is every digit correct in 3.14159265358979323846 and is this equal to 3.14159?) and makes it more difficult for the program to be adapted and extended in the future. Replacing all significant magic numbers with named constants makes programs easier to read, understand and maintain.
http://en.wikipedia.org/wiki/Magic_number_(programming)

JASS:
call StartCooldown(GetEnumUnit(), READABLE_CODE_ABILID, COOLDOWN_HOTKEY_Q, READABLE_CODE_ABILID_COOLDOWN)
 

Nestharus

o-o
Reaction score
84
Narks.. they aren't magic numbers.. he is generating them and he'd be generating the JASS code for them -.-.


What you said isn't even applicable to what we're talking about.
 

Narks

Vastly intelligent whale-like being from the stars
Reaction score
90
I'm saying that the only reason you are creating those constants is to store them into an array, which seems pointless. It makes more sense to just store the ids directly into the array and avoid the constants altogether considering that those constants are being generated to access the ids.

and how is this not bad programming practice
 

Nestharus

o-o
Reaction score
84
Because you don't seem to understand that he is generating the constants with Lua when he could just generate the array with Lua... he is not using magic numbers anywhere... that is why I'm saying your thing isn't even relevant.

writejass into onInit code (Lua script generates the below 5 lines, ids replaces with numbers as ids are vars in Lua)
set array[ID_1]=id1
set array[ID_2]=id2
set array[ID_3]=id3
set array[ID_4]=id4
set array[ID_5]=id5

vs
--------------------------------------------
writejass (lua script generates the below 5 lines, ids replaced with numbers as ids are vars in Lua)
constant integer ID_1=id1
constant integer ID_2=id2
constant integer ID_3=id3
constant integer ID_4=id4
constant integer ID_5=id5

in jass onInit code
set array[ID_1_1]=ID_1
set array[ID_2_1]=ID_2
set array[ID_3_1]=ID_3
set array[ID_4_1]=ID_4
set array[ID_5_1]=ID_5


Do you now see the pointlessness of his constants?

I'm asking him to do the first thing instead of the second thing because he is just generating the constants to generate the array... he could just generate the array in Lua and avoid the constants altogether and there would be no magic numbers used anywhere.. all of those things I used up there are variables.


I believe I've explained myself very clearly now.
 

Laiev

Hey Listen!!
Reaction score
188
Nest, you don't need to make my thread a thread of discussion about Lua loll

I just don't change it yet because I don't know how to do it... This is the reason why I asked you on THW if I make some mistake using GetVarObjects


I'll try to learn it from some script and then, I'll update it... Probably is just a little bit of code in the installing, but I really don't know Lua :)
 

Laiev

Hey Listen!!
Reaction score
188
Updated.

No lua anymore.

You just need to copy one ability, and then, paste it 6 times (and change the field of icon position and globals, of course).
 

tooltiperror

Super Moderator
Reaction score
231
Your documentation should be above the settings.

In addition to the "[LJASS]Cooldown.$method$[/LJASS]" you need a common JASS one too. Something like "StartCustomCooldown".
 

Laiev

Hey Listen!!
Reaction score
188
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    I think we need to add something to the bottom of the front page that shows the Headline News forum that has a link to go to the News Forum Index so people can see there is more news. Do you guys see what I am saying, lets say you read all the articles on the front page and you get to the end and it just ends, no kind of link for MOAR!
  • The Helper The Helper:
    Happy Wednesday!
    +1

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top