System Custom Cooldown System

[Narks]

The term magic number or magic constant also refers to the programming practice of using numbers directly in source code. This has been referred to as breaking one of the oldest rules of programming, dating back to the COBOL, FORTRAN and PL/1 manuals of the 1960s. The use of unnamed magic numbers in code obscures the developers' intent in choosing that number, increases opportunities for subtle errors (e.g. is every digit correct in 3.14159265358979323846 and is this equal to 3.14159?) and makes it more difficult for the program to be adapted and extended in the future. Replacing all significant magic numbers with named constants makes programs easier to read, understand and maintain.
http://en.wikipedia.org/wiki/Magic_number_(programming)

call StartCooldown(GetEnumUnit(), READABLE_CODE_ABILID, COOLDOWN_HOTKEY_Q, READABLE_CODE_ABILID_COOLDOWN)

 

[Nestharus]

Narks.. they aren't magic numbers.. he is generating them and he'd be generating the JASS code for them -.-.


What you said isn't even applicable to what we're talking about.

 

[Narks]

I'm saying that the only reason you are creating those constants is to store them into an array, which seems pointless. It makes more sense to just store the ids directly into the array and avoid the constants altogether considering that those constants are being generated to access the ids.

and how is this not bad programming practice

 

[Nestharus]

Because you don't seem to understand that he is generating the constants with Lua when he could just generate the array with Lua... he is not using magic numbers anywhere... that is why I'm saying your thing isn't even relevant.

writejass into onInit code (Lua script generates the below 5 lines, ids replaces with numbers as ids are vars in Lua)
set array[ID_1]=id1
set array[ID_2]=id2
set array[ID_3]=id3
set array[ID_4]=id4
set array[ID_5]=id5

vs
--------------------------------------------
writejass (lua script generates the below 5 lines, ids replaced with numbers as ids are vars in Lua)
constant integer ID_1=id1
constant integer ID_2=id2
constant integer ID_3=id3
constant integer ID_4=id4
constant integer ID_5=id5

in jass onInit code
set array[ID_1_1]=ID_1
set array[ID_2_1]=ID_2
set array[ID_3_1]=ID_3
set array[ID_4_1]=ID_4
set array[ID_5_1]=ID_5


Do you now see the pointlessness of his constants?

I'm asking him to do the first thing instead of the second thing because he is just generating the constants to generate the array... he could just generate the array in Lua and avoid the constants altogether and there would be no magic numbers used anywhere.. all of those things I used up there are variables.


I believe I've explained myself very clearly now.

 

[Laiev]

Nest, you don't need to make my thread a thread of discussion about Lua loll

I just don't change it yet because I don't know how to do it... This is the reason why I asked you on THW if I make some mistake using GetVarObjects


I'll try to learn it from some script and then, I'll update it... Probably is just a little bit of code in the installing, but I really don't know Lua

 

[Laiev]

Updated.

No lua anymore.

You just need to copy one ability, and then, paste it 6 times (and change the field of icon position and globals, of course).

 

[tooltiperror]

Your documentation should be above the settings.

In addition to the "[LJASS]Cooldown.$method$[/LJASS]" you need a common JASS one too. Something like "StartCustomCooldown".

 

[Laiev]

Your documentation should be above the settings.

Done

In addition to the "[LJASS]Cooldown.$method$[/LJASS]" you need a common JASS one too. Something like "StartCustomCooldown".

I'm unsure what this mean, in the API, there's a easy access for it:

*    Functions
*    ¯¯¯¯¯¯¯¯¯
*       - Basic
*         ¯¯¯¯¯
*           function StartCooldown takes unit whichUnit, integer abilId, integer hotkey, real duration returns nothing