Gates and armies

[Xonora]

lol. Check my trigger again. Its extremely simple. There is no leak. Only a condition. The only action is open/close gate

 

[Hot]

lol. Check my trigger again. Its extremely simple. There is no leak. Only a condition. The only action is open/close gate

u have to destroy the unit group (dont know the correct script)

 

[Xonora]

Event
Unit leaves (your region)

Condition


Action

If, then multiple functions, else. (something like that)
Conditions (interger comparison) - Number of units in (your region) = 0 is true

Then - Close gate

Else - Do nothing

Where leak?

Anyway, the command is ' call DestroyGroup (udg_yourgroup) ' (exact spacing)

 

[Rainther]

If it's a global unit group, which seems to be the case you better clear it then destroying it, since destroying it, from what I've heard leaks.

PS: I don't see where is leaks either.

 

[Hacklefellar]

Anyway, the command is ' call DestroyGroup (udg_yourgroup) ' (exact spacing)

you've lost me. is this done with worldbuilder or something i don't get? xD

 

[Rainther]

We're just messing with your brain

call DestroyGroup is used in order to "kill" a unit group so that it in theory doesn't store memory any longer.

 

[Xonora]

just go under action - custom script and paste the code in.

I know how u feel. not long ago i had problems with variables too

 

[Hacklefellar]

it isn't working. i did what you said but now it says : expected 'endif' should i just stick that on the end of the line or do i have to do something else?

 

[Xonora]

ok try - call DestroyGroup(udg_tempgroup) Where tempgroup is your group name. Must be exact spelling.

 

[Hacklefellar]

i haven't used unitgroups. i just used the if/then/else command with
if number of units in open door region is equal to 0 (in short)
then close door
else do nothing

what would that make the name of the unit group?

 

[Rainther]

number of units creates a Unit Group, which should be set to a variable before running the if and then handle it with Destroy for instance.

 

[Hacklefellar]

how does that thing work that u can post a trigger screen in a reply? then i can show you how i did it.

this is how i did it:

Trigger 1 (for opening)

• Trigger
  • Events
    • Unit - A unit enters open door <gen>
  • Conditions
    • ((Triggering unit) is a flying unit) Equal to False
  • Actions
    • Destructible - Open Gate (Horizontal) 0004 <gen>

Trigger 2 (for closing)

• Trigger
  • Events
    • Unit - Leaves Open Door <gen>
  • Conditions
  • Actions
    • If ((Number of units in (Units in Open Door <gen>)) Equal to 0) then do (Destructible - Close Gate (Horizontal) 0004 <gen>) Else (Do Nothing)

 

[Rainther]

Make a unit group variable and before calling the "if" set the group variable to "Units in Open Door", refer to the group insetad in the If

and when you're done use a custom script:
call GroupClear(udg_<Unit Group Variable Name>)

 

[Xonora]

I tot it was DestroyGroup? But i didnt know checking a region has a leak? Its a condition

 

[Hacklefellar]

this is how it is now:

Trigger 1 (for opening)

• Trigger
  • Events
    • Unit - A unit enters open door &lt;gen&gt;
  • Conditions
    • ((Triggering unit) is a flying unit) Equal to False
  • Actions
    • Unit Group - Add all units of (Units in Open Door &lt;gen&gt;) to Opendoorgrp
    • Destructible - Open Gate (Horizontal) 0004 &lt;gen&gt;

Trigger 2 (for closing)

• Trigger
  • Events
    • Unit - Leaves Open Door &lt;gen&gt;
  • Conditions
  • Actions
    • Unit Group - Remove (Triggering unit) from Opendoorgrp
    • If ((Number of units in (Units in Opendoorgrp) Equal to 0) then do (Destructible - Close Gate (Horizontal) 0004 &lt;gen&gt;) Else (Do Nothing)
  • Custom script - call GroupClear(udg_Opendoorgrp)

is it now leak free?

also i have 4 doors with each different regions. can i still use only 1 group? or does that cause problems if multiple doors are opened at the same time?

 

[Rainther]

Use 4 seperate groups.

And what it comes to clear or destroying from what I believe it's that destroying does leaks a small amount (from what I've heard), which makes reusing the unit group better. And sorry for messing with you, but on second thoughs you don't need the custom script and you only need to add entering unit to Unit Group in Trigger 1.

 

[Hacklefellar]

so what should it look like then?

 

[Samael88]

I just want to add something here that the others seem to have overlooked

It's more of a suggestion really.

Use the "if/then/else multiple conditions" instead of the standard one and leave the the else empty.

The "Do nothing" function is a function that really does absolutely nothing good except adding two unnecessary function calls

Edit: Oh, and I might aswell contribute to the solution while I'm at it

I would go for having one region for the open trigger, probably as you have it now.
And then a second region that is two or three times larger for the other trigger, hence you won't be as likely to get the problem of unit's being closed out.

 

[Hacklefellar]

so u say that if i don't put in anything in the else part, it doesn't leak?
i thought it would just BECAUSE there is a piece of code expected :S but i'm new to this so thats just my logic

anyway if this is to be leak-free i thank-thee haha

 

[bOb666777]

• Trigger
  • Events
    • Unit - Leaves Open Door &lt;gen&gt;
  • Conditions
  • Actions
    • Set Opendoorgrp = Units in Open Door &lt;gen&gt;
    • If ((Number of units in (Units in Opendoorgrp) Equal to 0) then do (Destructible - Close Gate (Horizontal) 0004 &lt;gen&gt;) Else (Do Nothing)
    • Custom script: call DestroyGroup(udg_Opendoorgrp)

There. And remove the group thing in first trigger ^^.