Help needed with a spell..

[The_Reaping]

Okay. so i'm creating a spell that deals damage every second for 3 seconds, in an AoE, and heals the hero for 5% of all damage dealt. I have the triggers set up and everything, but for some reason. When I first use the spell it only hits and heals twice and the second time I cast it, it only hits and heals once.. Getting irritating. I just can't seem to find out the problem.

Here's the trigger info.

• Nerubian Plague
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Nerubian Plague
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Nerubian Plague for (Triggering unit)) Equal to 1
      • Then - Actions
        • For each (Integer A) from 1 to 3, do (Actions)
          • Loop - Actions
            • Set TempGroup = (Units within 275.00 of (Target point of ability being cast) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True)))
            • Unit Group - Pick every unit in TempGroup and do (Actions)
              • Loop - Actions
                • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
                • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 75.00 damage of attack type Magic and damage type Disease
                • Special Effect - Destroy (Last created special effect)
            • Special Effect - Create a special effect attached to the chest of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
            • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) + (0.05 x (75.00 x (Real((Number of units in TempGroup))))))
            • Special Effect - Destroy (Last created special effect)
            • Custom script: call DestroyGroup(udg_TempGroup)
            • Wait 1.00 seconds
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Nerubian Plague for (Triggering unit)) Equal to 2
          • Then - Actions
            • For each (Integer A) from 1 to 3, do (Actions)
              • Loop - Actions
                • Set TempGroup = (Units within 275.00 of (Target point of ability being cast) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True)))
                • Unit Group - Pick every unit in TempGroup and do (Actions)
                  • Loop - Actions
                    • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
                    • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 150.00 damage of attack type Magic and damage type Disease
                    • Special Effect - Destroy (Last created special effect)
                • Special Effect - Create a special effect attached to the chest of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) + (0.05 x (150.00 x (Real((Number of units in TempGroup))))))
                • Special Effect - Destroy (Last created special effect)
                • Custom script: call DestroyGroup(udg_TempGroup)
                • Wait 1.00 seconds
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Nerubian Plague for (Triggering unit)) Equal to 3
              • Then - Actions
                • For each (Integer A) from 1 to 3, do (Actions)
                  • Loop - Actions
                    • Set TempGroup = (Units within 275.00 of (Target point of ability being cast) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True)))
                    • Unit Group - Pick every unit in TempGroup and do (Actions)
                      • Loop - Actions
                        • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
                        • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 225.00 damage of attack type Magic and damage type Disease
                        • Special Effect - Destroy (Last created special effect)
                    • Special Effect - Create a special effect attached to the chest of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                    • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) + (0.05 x (225.00 x (Real((Number of units in TempGroup))))))
                    • Custom script: call DestroyGroup(udg_TempGroup)
                    • Special Effect - Destroy (Last created special effect)
                    • Wait 1.00 seconds
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Level of Nerubian Plague for (Triggering unit)) Equal to 4
                  • Then - Actions
                    • For each (Integer A) from 1 to 3, do (Actions)
                      • Loop - Actions
                        • Set TempGroup = (Units within 275.00 of (Target point of ability being cast) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True)))
                        • Unit Group - Pick every unit in TempGroup and do (Actions)
                          • Loop - Actions
                            • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
                            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 300.00 damage of attack type Magic and damage type Disease
                            • Special Effect - Destroy (Last created special effect)
                        • Special Effect - Create a special effect attached to the chest of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                        • Unit - Set life of (Triggering unit) to ((Life of (Triggering unit)) + (0.05 x (300.00 x (Real((Number of units in TempGroup))))))
                        • Custom script: call DestroyGroup(udg_TempGroup)
                        • Special Effect - Destroy (Last created special effect)
                        • Wait 1.00 seconds
                  • Else - Actions

Thanks in advance.

 

[vypur85]

Haven't read through the trigger but waits do not work well in Integer A/B loops. Replace the Integer A loops in your trigger with Custom Variable Integer.

 

[keychup]

have a unit with a blizzard dummy spell cause the damage and let it last 3 waves. when the damage is dealt you can use a GDD (found somewhere in this site) to detect the amount of damage dealt then you have to search for the real caster some way and heal it. most effective way to do that is use hashtables.

 

[KaerfNomekop]

There's no need to have so many If/Then/Else blocks. You can just use ((Level of Ability for (Triggering unit)) x 75) as the damage.

 

[The_Reaping]

Thanks for the advice guys. I've managed to fix it. Went with two triggers. I'll post em here, you guys might have some ways of increasing reliability of it. :3

• Nerubian Plague Cast
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Nerubian Plague
  • Actions
    • Trigger - Turn on Nerubian Plague effects <gen>
    • Set NPCaster = (Triggering unit)
    • Set NPTarget = (Target unit of ability being cast)
    • Wait 3.20 seconds
    • Trigger - Turn off Nerubian Plague effects <gen>

• Nerubian Plague effects
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set TempGroup = (Units within 275.00 of (Position of NPTarget) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of NPCaster)) Equal to True)))
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
        • Unit - Cause NPCaster to damage (Picked unit), dealing (35.00 x (Real((Level of Nerubian Plague for NPCaster)))) damage of attack type Magic and damage type Disease
        • Special Effect - Destroy (Last created special effect)
    • Special Effect - Create a special effect attached to the chest of NPCaster using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
    • Unit - Set life of NPCaster to ((Life of NPCaster) + ((((35.00 x (Real((Level of Nerubian Plague for NPCaster)))) x (Real((Number of units in TempGroup)))) x 0.05) x 0.75))
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call DestroyGroup(udg_TempGroup)

 

[KaerfNomekop]

Do you intend it to work for only one unit, or many at a time? If two units cast the spell now, the second will overwrite the first.