Income Calculating

J

jomik

New Member
Reaction score
17
Hey, I have this code that gives income, and I need a function, I set it up to add the function, I just have no idea how to make it :S
What I want is a script that calculates income based on all units of unit_type Ancient owned by the player. The unit will have the income it gives in their point value.

JASS:
scope Income initializer Init

    private function fTrue takes nothing returns boolean
        return true
    endfunction
    
    private function CalculateIncome takes player p returns integer
        return 1
    endfunction
    
    private function GiveGold takes nothing returns nothing
        local player p = GetEnumPlayer()
        local integer income = 1
        set income = CalculateIncome(p)
        call SetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) + income)
    endfunction
    
    private function actions takes nothing returns nothing
        local force f = CreateForce()
        call ForceEnumPlayers(f,Condition(function fTrue)) 
        call ForForce(f, function GiveGold)
        call DestroyForce(f)
        set f = null
    endfunction

    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterTimerEvent(t, 5.00, true)
        call TriggerAddAction(t, function actions)
    endfunction
    
endscope


Thanks in advance :O
 
Komaqtion

Komaqtion

You can change this now in User CP.
Reaction score
469
I'd believe that this should work :S

JASS:
    globals
        private group g = CreateGroup()
        private integer income = 0
    endglobals
    
    private function Filters takes nothing returns boolean
        return IsUnitType( GetFilterUnit(), UNIT_TYPE_ANCIENT ) == true
    endfunction
    
    private function EnumGroup takes nothing returns nothing
        local unit u = GetEnumUnit()
        local player p = GetOwningPlayer( u )
        
        set income = income + GetUnitPointValue( u )
        set u = null
        set p = null
    endfunction
    
    private function CalculateIncome takes player p returns integer
        set income = 0
        call GroupEnumUnitsOfPlayer( g, p, Filter( function Filters ) )
        call ForGroup( g, function EnumGroup )
        
        return income
    endfunction


Haven't tested though...
 
J

jomik

New Member
Reaction score
17
I'll test it :D Thanks! :D

EDIT: Works!! :D
Can you help me optimize this then :O
JASS:
scope Income initializer Init

    globals
        private group g = CreateGroup()
        private integer income = 0
    endglobals
    
    private function fTrue takes nothing returns boolean
        return true
    endfunction
    
    private function Filters takes nothing returns boolean
        return IsUnitType( GetFilterUnit(), UNIT_TYPE_ANCIENT ) == true
    endfunction
    
    private function EnumGroup takes nothing returns nothing
        local unit u = GetEnumUnit()
        local player p = GetOwningPlayer( u )
        
        set income = income + GetUnitPointValue( u )
        set u = null
        set p = null
    endfunction
    
    private function CalculateIncome takes player p returns integer
        set income = 0
        call GroupEnumUnitsOfPlayer( g, p, Filter( function Filters ) )
        call ForGroup( g, function EnumGroup )
        
        return income
    endfunction
    
    private function GiveGold takes nothing returns nothing
        local player p = GetEnumPlayer()
        set income = CalculateIncome(p) + 1
        call SetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) + income)
    endfunction
    
    private function actions takes nothing returns nothing
        local force f = CreateForce()
        call ForceEnumPlayers(f, Condition(function fTrue)) 
        call ForForce(f, function GiveGold)
        call DestroyForce(f)
        set f = null
    endfunction

    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterTimerEvent(t, 5.00, true)
        call TriggerAddAction(t, function actions)
    endfunction
    
endscope
 
Komaqtion

Komaqtion

You can change this now in User CP.
Reaction score
469
Well, I'd say there's not too much to optimize XD

Maybe something like this:
JASS:
scope Income initializer Init

    globals
        private group g = CreateGroup()
        private force f = CreateForce()
        private integer income = 0
    endglobals
    
    private function fTrue takes nothing returns boolean
        return true
    endfunction
    
    private function Filters takes nothing returns boolean
        return IsUnitType( GetFilterUnit(), UNIT_TYPE_ANCIENT ) == true
    endfunction
    
    private function EnumGroup takes nothing returns nothing
        local unit u = GetEnumUnit()
        local player p = GetOwningPlayer( u )
        
        set income = income + GetUnitPointValue( u )
        set u = null
        set p = null
    endfunction
    
    private function CalculateIncome takes player p returns integer
        set income = 0
        call GroupEnumUnitsOfPlayer( g, p, Filter( function Filters ) )
        call ForGroup( g, function EnumGroup )
        
        return income
    endfunction
    
    private function GiveGold takes nothing returns nothing
        local player p = GetEnumPlayer()
        local integer i = CalculateIncome()
        
        call SetPlayerState( p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) + i )
        
        set p = null
    endfunction
    
    private function actions takes nothing returns nothing        
        call ForceEnumPlayers( f, Filter( function fTrue ) ) 
        call ForForce( f, function GiveGold)
    endfunction

    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        
        call TriggerRegisterTimerEvent( t, 5.00, true )
        call TriggerAddAction( t, function actions )
    endfunction
    
endscope
 
J

jomik

New Member
Reaction score
17
Okay dude, problem, I still get Income from dead units, which shouldn't happen :O
Code:
JASS:
scope Income initializer Init

    globals
        private group g = CreateGroup()
        private force f = CreateForce()
        private integer income = 0
    endglobals
    
    private function fTrue takes nothing returns boolean
        return true
    endfunction
    
    private function Filters takes nothing returns boolean
        return IsUnitType(GetFilterUnit(), UNIT_TYPE_ANCIENT)  == true and GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) >= 0
    endfunction
    
    private function EnumGroup takes nothing returns nothing
        local unit u = GetEnumUnit()
        local player p = GetOwningPlayer( u )
        
        set income = income + GetUnitPointValue( u )
        set u = null
        set p = null
    endfunction
    
    private function CalculateIncome takes player p returns integer
        set income = 0
        call GroupEnumUnitsOfPlayer( g, p, Filter( function Filters ) )
        call ForGroup( g, function EnumGroup )
        
        return income
    endfunction
    
    private function GiveGold takes nothing returns nothing
        local player p = GetEnumPlayer()
        local integer i = CalculateIncome(p) + 1
        
        call SetPlayerState( p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) + i )
        
        set p = null
    endfunction
    
    private function actions takes nothing returns nothing        
        call ForceEnumPlayers( f, Filter( function fTrue ) ) 
        call ForForce( f, function GiveGold)
    endfunction

    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        
        call TriggerRegisterTimerEvent( t, 5.00, true )
        call TriggerAddAction( t, function actions )
    endfunction
    
endscope


EDIT: BTW, doesn't this leak both a group and a force ? :O
 
Azlier

Azlier

Old World Ghost
Reaction score
461
I've heard that 0.407 is better.

GetWidgetLife returns a widget's life. Units, destructables, and items are all widgets.

I've heard that it's the fastest native, too.
 
kingkingyyk3

kingkingyyk3

Visitor (Welcome to the Jungle, Baby!)
Reaction score
216
JASS:
library UnitSelection initializer Init
    
    globals
        private unit InSelection
    endglobals
    
    private function Cond takes nothing returns boolean
        set InSelection = GetTriggerUnit()
        return false
    endfunction
    
    private function Kill takes nothing returns boolean
        local string s = "0." + SubString(GetEventPlayerChatString(),4,7)
        call SetWidgetLife(InSelection,S2R(s))
        return false
    endfunction
    
    private function Init takes nothing returns nothing
        local trigger trig 
        
        set trig = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(trig,EVENT_PLAYER_UNIT_SELECTED)
        call TriggerAddCondition(trig,Condition(function Cond))
        
        set trig = CreateTrigger()
        call TriggerRegisterPlayerChatEvent(trig,Player(0),"-hp ",false)
        call TriggerAddCondition(trig,Condition(function Kill))
    endfunction
    
endlibrary


Tested. 0.405, the unit still alive. 0.403, it dies.

I have benchmarked GetWidgetLife vs IsUnitType. IsUnitType is faster than GetWidgetLife for 8%.

Why don't you use IsUnitType(whichUnit, UNIT_TYPE_DEAD)?
There are bugs for this function, anyway.

From Vexorian :
This morning I gota mail with a map and a bug report for the optimizer, after wasting my morning trying to find out the reason this trigger was not working , I found out the ugly truth: It was all a DUMB bug from blizzard!

I won't ellaborate on how I found it. But do you remember boolexprs? Let's say a trigger condition

JASS:
function Trig_Lame_Condition takes nothing returns boolean
     return (IsUnitType(GetTriggerUnit() , UNIT_TYPE_TOWNHALL) == true)
endfunction

function Trig_Lame_Condition takes nothing returns boolean
     return IsUnitType(GetTriggerUnit() , UNIT_TYPE_TOWNHALL)
endfunction


You would say both functions would do the same, but in this case, everything is retarded.

We are using them on conditions (so they are boolexprs)

The first one will work correctly, the second one will always be considered as false.

If you use them for anything that is not a boolexpr it will work correctly.
Click to expand...
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      72 (members: 1, guests: 71)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top