Leash system, not detecting range?

NeuroToxin · Jan 19, 2011

I made a leash system, and so far, it works except, it doesnt detect when the unit in question, leaves the range. heres the part of the trigger for that.

JASS:


private function IfIsElse takes nothing returns nothing
    local real X = GetUnitX(GetEnumUnit())
    local real Y = GetUnitY(GetEnumUnit())
    local real dx = GetUnitX(GetEnumUnit()) - GetUnitX(GetTriggerUnit())
    local real dy = GetUnitY(GetEnumUnit()) - GetUnitY(GetTriggerUnit())
    set TempReal = SquareRoot(dx * dx + dy * dy)
        if TempReal &gt;= range then
            if DoesDamage == true then
                call SetUnitState(GetEnumUnit(), UNIT_STATE_LIFE, GetWidgetLife(GetEnumUnit()) - Damage )
                call SetUnitX(GetEnumUnit(), X - 20)
                call SetUnitY(GetEnumUnit(), Y - 20)
                call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
            else
        call SetUnitX(GetEnumUnit(), X - 20)
        call SetUnitY(GetEnumUnit(), Y - 20)
        call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
    endif
endif
endfunction

Bribe · Jan 21, 2011

JASS:

private function IfIsElse takes nothing returns nothing
    local unit u = GetEnumUnit()
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local real dx = x - GetUnitX(GetTriggerUnit())
    local real dy = y - GetUnitY(GetTriggerUnit())
    if SquareRoot(dx * dx + dy * dy) &gt;= range then
        if DoesDamage then
            call SetWidgetLife(u, GetWidgetLife(u) - Damage)
        endif
        call SetUnitPosition(u, x - 20, y - 20)
    endif
    set u = null
endfunction

What is the unit in question? What is the triggering unit? Where are DoesDamage and Damage set? What group is enumerating these things and how are they even added? Things to know.

NeuroToxin · Jan 21, 2011

Heres the full trigger and by the way, once you read it, it stops at "Acquired Unit" And by the way, this is a system to put in when a spell is cast, to leash a certain unit.

JASS:

library LeashSystem
//===========================================================================
//==================================SETUP====================================
//===========================================================================
globals

real range = 1000//This is the range of the leash.
unit LeashedUnit//LeashedUnit
group LeashedUnits//The leashed units.
boolean DoesDamage = false//Deals Damage to the unit for everytime it goes out, initially set to false, can be set to true.
real Damage = 30//If DoesDamage = true, then it will do This damage everytime it goes out.
real TempReal//Don&#039;t Touch

endglobals
//===========================================================================
//=================================ENDSETUP==================================
//===========================================================================

private function IfIsElse takes nothing returns nothing
    local real X = GetUnitX(GetEnumUnit())
    local real Y = GetUnitY(GetEnumUnit())
    local real dx = GetUnitX(GetEnumUnit()) - GetUnitX(GetTriggerUnit())
    local real dy = GetUnitY(GetEnumUnit()) - GetUnitY(GetTriggerUnit())
    set TempReal = SquareRoot(dx * dx + dy * dy)
    call BJDebugMsg(&quot;IfIsElse function&quot;)
        if TempReal &gt;= range then
            if DoesDamage == true then
                call BJDebugMsg(&quot;Damaging Unit/Moving&quot;)
                call SetUnitState(GetEnumUnit(), UNIT_STATE_LIFE, GetWidgetLife(GetEnumUnit()) - Damage )
                call SetUnitX(GetEnumUnit(), X - 20)
                call SetUnitY(GetEnumUnit(), Y - 20)
                call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
            else
        call BJDebugMsg(&quot;Moving Unit&quot;)
        call SetUnitX(GetEnumUnit(), X - 20)
        call SetUnitY(GetEnumUnit(), Y - 20)
        call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
    endif
endif
endfunction

private function ForFun takes nothing returns nothing
       call ForGroup(LeashedUnits, function IfIsElse)
       call BJDebugMsg(&quot;Starting Group&quot;)
endfunction

function Leashocity takes nothing returns nothing
        set LeashedUnit = GetSpellTargetUnit()
            call BJDebugMsg(&quot;Acquired Unit&quot;)
            call GroupAddUnit(LeashedUnits, LeashedUnit)
            call BJDebugMsg(&quot;Added Unit&quot;)
            call ForFun()
        set LeashedUnit = null
endfunction
            
        
//===========================================================================
//=================================INIT======================================
//===========================================================================
function InitTrig_Leash_System takes nothing returns nothing
    set gg_trg_Leash_System = CreateTrigger(  )
    call TriggerRegisterTimerEvent(gg_trg_Leash_System, .03, true)
endfunction

endlibrary

hgkjfhfdsj · Jan 21, 2011

- no timer expire action is attached
eg. call TimerStart(CreateTimer(), 0.03, true, function ForFun)
or TriggerAddAction(...)
- GetTriggerUnit() returns nulls > function IfIsElse compares LeashedUnit and null's position.
- also unit will always travel south westly and not towards the caster

NeuroToxin · Jan 21, 2011

Heres what I have, at least what I changed it to, and it's not doing anything after the GroupAddUnit(LeashedUnits, LeashedUnit) And im not sure what you mean when you say Function IfIsElse compares leashed unit and null's position...

JASS:

library LeashSystem
//===========================================================================
//==================================SETUP====================================
//===========================================================================
globals

timer t = CreateTimer()
real range = 1000//This is the range of the leash.
unit LeashedUnit//LeashedUnit
group LeashedUnits//The leashed units.
boolean DoesDamage = false//Deals Damage to the unit for everytime it goes out, initially set to false, can be set to true.
real Damage = 30//If DoesDamage = true, then it will do This damage everytime it goes out.
real TempReal//Don&#039;t Touch

endglobals
//===========================================================================
//=================================ENDSETUP==================================
//===========================================================================

private function IfIsElse takes nothing returns nothing
    local real X = GetUnitX(GetEnumUnit())
    local real Y = GetUnitY(GetEnumUnit())
    local real dx = GetUnitX(GetEnumUnit()) - GetUnitX(GetTriggerUnit())
    local real dy = GetUnitY(GetEnumUnit()) - GetUnitY(GetTriggerUnit())
    set TempReal = SquareRoot(dx * dx + dy * dy)
    call BJDebugMsg(&quot;IfIsElse function&quot;)
        if TempReal &gt;= range then
            if DoesDamage == true then
                call BJDebugMsg(&quot;Damaging Unit/Moving&quot;)
                call SetUnitState(GetEnumUnit(), UNIT_STATE_LIFE, GetWidgetLife(GetEnumUnit()) - Damage )
                call SetUnitX(GetEnumUnit(), X - 20)
                call SetUnitY(GetEnumUnit(), Y - 20)
                call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
            else
        call BJDebugMsg(&quot;Moving Unit&quot;)
        call SetUnitX(GetEnumUnit(), X - 20)
        call SetUnitY(GetEnumUnit(), Y - 20)
        call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
    endif
endif
endfunction

private function ForFun takes nothing returns nothing
       call ForGroup(LeashedUnits, function IfIsElse)
       call BJDebugMsg(&quot;Starting Group&quot;)
endfunction

function Leashocity takes nothing returns nothing
        set LeashedUnit = GetSpellTargetUnit()
            call BJDebugMsg(&quot;Acquired Unit&quot;)
            call GroupAddUnit(LeashedUnits, LeashedUnit)
            call BJDebugMsg(&quot;Added Unit&quot;)
            call ForFun()
            call TimerStart(t, 0.03, true, function ForFun)
        set LeashedUnit = null
endfunction
            
        
//===========================================================================
//=================================INIT======================================
//===========================================================================
function InitTrig_Leash_System takes nothing returns nothing
endfunction

endlibrary

tooltiperror · Jan 21, 2011

1) Give your functions proper names.
2) Where are you starting the timer for this one? I don't see why anything should run at all.

NeuroToxin · Jan 21, 2011

I need a timer to check whenever a unit leaves, in order to properly detect it.

NeuroToxin · Jan 21, 2011

tooltiperror said:
1) Give your functions proper names.
I will, after I get it working.
2) Where are you starting the timer for this one? I don't see why anything should run at all.

The timer is so the unit can be detected properly.

Sorry for double post, IDK How to remove the post I had.

tooltiperror · Jan 21, 2011

Just edit your first post.

JASS:

function InitTrig_Leash_System takes nothing returns nothing
endfunction

It's empty, why do you think anything will start?

NeuroToxin · Jan 21, 2011

library LeashSystem
//===========================================================================
//==================================SETUP====================================
//===========================================================================
globals

timer t = CreateTimer()
real range = 1000//This is the range of the leash.
unit LeashedUnit//LeashedUnit
group LeashedUnits//The leashed units.
boolean DoesDamage = false//Deals Damage to the unit for everytime it goes out, initially set to false, can be set to true.
real Damage = 30//If DoesDamage = true, then it will do This damage everytime it goes out.
real TempReal//Don't Touch

endglobals
//===========================================================================
//=================================ENDSETUP==================================
//===========================================================================

private function IfIsElse takes nothing returns nothing
local real X = GetUnitX(GetEnumUnit())
local real Y = GetUnitY(GetEnumUnit())
local real dx = GetUnitX(GetEnumUnit()) - GetUnitX(GetTriggerUnit())
local real dy = GetUnitY(GetEnumUnit()) - GetUnitY(GetTriggerUnit())
set TempReal = SquareRoot(dx * dx + dy * dy)
call BJDebugMsg("IfIsElse function")
if TempReal >= range then
if DoesDamage == true then
call BJDebugMsg("Damaging Unit/Moving")
call SetUnitState(GetEnumUnit(), UNIT_STATE_LIFE, GetWidgetLife(GetEnumUnit()) - Damage )
call SetUnitX(GetEnumUnit(), X - 20)
call SetUnitY(GetEnumUnit(), Y - 20)
call IssueImmediateOrder(GetEnumUnit(), "Stop")
else
call BJDebugMsg("Moving Unit")
call SetUnitX(GetEnumUnit(), X - 20)
call SetUnitY(GetEnumUnit(), Y - 20)
call IssueImmediateOrder(GetEnumUnit(), "Stop")
endif
endif
endfunction

private function ForFun takes nothing returns nothing
call ForGroup(LeashedUnits, function IfIsElse)
call BJDebugMsg("Starting Group")
endfunction

function Leashocity takes nothing returns nothing
set LeashedUnit = GetSpellTargetUnit()
call BJDebugMsg("Acquired Unit")
call GroupAddUnit(LeashedUnits, LeashedUnit)
call BJDebugMsg("Added Unit")
call ForFun()
call TimerStart(t, 0.03, true, function ForFun)
set LeashedUnit = null
endfunction

//===========================================================================
//=================================INIT======================================
//===========================================================================
function InitTrig_Leash_System takes nothing returns nothing
endfunction

endlibrary

tooltiperror · Jan 21, 2011

And why will that function run? What is running Leashocity? I don't see it being called ...

Edit: Why the fuck are you writing half the code the way you are? This isn't the 2005 JASS stone age, we're not in midst of discovering return bug.

EditEdit: Shouldn't you also be using a different interface? Right now this is a complete mess.

EditEditEdit: I cleaned up a bit for you (untested) and it's still leaking with [LJASS]ForGroup[/LJASS]. You also make some useless code I don't understand.

JASS:

library Leash initializer onInit

	// Configuration
	globals
		// The Range of the Leash
		private constant real LEASH_RANGE=1000
		// If True, deals damage to a unit that tries to break its leash
		private constant boolean ENABLE_DAMAGE=false
		// Damage to deal if ENABLE_DAMAGE is true
		private constant real DAMAGE=30
	endglobals

	// System Core
	globals
		private timer t=CreateTimer()
		private unit LeashedUnit
		private group LeashedUnits
		private real TempReal
	endglobals
	
	private function IfIsElse takes nothing returns nothing
		local real X = GetUnitX(GetEnumUnit()) // Don&#039;t use GetEnumUnit() so much, too many function calls,
		local real Y = GetUnitY(GetEnumUnit()) // just use a variable (quicker).
		local real dx = GetUnitX(GetEnumUnit()) - GetUnitX(GetTriggerUnit())
		local real dy = GetUnitY(GetEnumUnit()) - GetUnitY(GetTriggerUnit())
		set TempReal = SquareRoot(dx * dx + dy * dy) // Are you trying to get distance here? This could all be one or two lines.
		call BJDebugMsg(&quot;IfIsElse function&quot;)
		if (TempReal&gt;=range) then
			static if ENABLE_DAMAGE then
				call SetUnitState(GetEnumUnit(),UNIT_STATE_LIFE,GetWidgetLife(GetEnumUnit())-DAMAGE)
			endif
			call BJDebugMsg(&quot;Moving Unit&quot;)
			call SetUnitX(GetEnumUnit(), X - 20)
			call SetUnitY(GetEnumUnit(), Y - 20)
			call IssueImmediateOrder(GetEnumUnit(),&quot;Stop&quot;)
		endif
	endfunction
	
	private function ForFun takes nothing returns nothing
		call ForGroup(LeashedUnits, function IfIsElse)
		call BJDebugMsg(&quot;Starting Group&quot;)
	endfunction

	function Leashocity takes nothing returns nothing
		set LeashedUnit = GetSpellTargetUnit()
		call BJDebugMsg(&quot;Acquired Unit&quot;)
		call GroupAddUnit(LeashedUnits, LeashedUnit)	
		call BJDebugMsg(&quot;Added Unit&quot;)	
		call ForFun()
		call TimerStart(t, 0.03, true, function ForFun)
		set LeashedUnit = null
	endfunction

	function onInit takes nothing returns nothing
		// Useless function?
	endfunction

endlibrary

EditEditEdit: I'm hoping for something like this: [LJASS]UnitAddLeash takes unit which, real leashX, real leashY, real leashLength[/LJASS].

hgkjfhfdsj · Jan 22, 2011

>What is running Leashocity?
i think how this system is used is actually by calling Leashocity() in a starts effect Event. eg

[GUI]Event
A Unit Starts the Effect of an Ability
--
Action
call Leashocity()[/GUI]

Ayanami · Jan 22, 2011

hgkjfhfdsj said:
>What is running Leashocity?
i think how this system is used is actually by calling Leashocity() in a starts effect Event. eg

[GUI]Event
A Unit Starts the Effect of an Ability
--
Action
call Leashocity()[/GUI]

But wouldn't that cause "GetSpellTargetUnit()" in function "Leashocity" to be null?

Bribe · Jan 22, 2011

> But wouldn't that cause "GetSpellTargetUnit()" in function "Leashocity" to be null?

No. Calling a function does not cause any problems. ExecuteFunc("FuncName") will not cause any, either. Calling TriggerEvaluate() or TriggerExecute() will obviously cause GetTriggeringTrigger() to return that trigger instead of the original event trigger, which is just one more reason why function interfaces are poor.

I don't know why any one has the idea to clean up the IfElseThen function when it's clear I did that in the first reply because no one optimizes like I do.

Jedi · Jan 22, 2011

You can check distance with IsUnitInRange easily.

Bribe · Jan 22, 2011

Indeed, but it factors in collision size

(which has pros and cons)

hgkjfhfdsj · Jan 22, 2011

>function ifiselse compares getenumunit with null unit's position

JASS:

//showing you on your code since you might be more familiar with it..
private function IfIsElse takes nothing returns nothing
    local real X = GetUnitX(GetEnumUnit())
    local real Y = GetUnitY(GetEnumUnit())
    local real dx = GetUnitX(GetEnumUnit()) - GetUnitX(GetTriggerUnit()) //if this function is executed on timer expire, there isnt a gettriggerunit. its the incorrect event response. in other words, your not minusing the getenumunit&#039;s position with the caster..
    local real dy = GetUnitY(GetEnumUnit()) - GetUnitY(GetTriggerUnit()) //you would need to attach the caster to theenumunit, or otherwise an index/array (and not having to worry about leaks)
    set TempReal = SquareRoot(dx * dx + dy * dy)
    call BJDebugMsg(&quot;IfIsElse function&quot;)
        if TempReal &gt;= range then
            if DoesDamage == true then
                call BJDebugMsg(&quot;Damaging Unit/Moving&quot;)
                call SetUnitState(GetEnumUnit(), UNIT_STATE_LIFE, GetWidgetLife(GetEnumUnit()) - Damage )
                call SetUnitX(GetEnumUnit(), X - 20)
                call SetUnitY(GetEnumUnit(), Y - 20)
                call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
            else
        call BJDebugMsg(&quot;Moving Unit&quot;)
        call SetUnitX(GetEnumUnit(), X - 20)
        call SetUnitY(GetEnumUnit(), Y - 20)
        call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
    endif
endif
endfunction

NeuroToxin · Jan 22, 2011

So, how would I do this? Hashtable?

EDIT: After staring at my code, heres what I came up with
EDIT:EDIT: If I have it taking a unit u, a unit t, and a range, will writing call UnitAddLeash(GetSpellTargetUnit(), GetTriggerUnit(), 1000) bug?

JASS:

library LeashSystem
//===========================================================================
//==================================SETUP====================================
//===========================================================================
globals
//These values are indented as priority, ones that aren&#039;t indented require no touching.
timer time = CreateTimer()
        real range = 1000//This is the range of the leash.
unit LeashedUnit//LeashedUnit
unit Caster//Caster
group LeashedUnits//The leashed units.
    boolean DoesDamage = false//Deals Damage to the unit for everytime it goes out, initially set to false, can be set to true.
        real Damage = 30//If DoesDamage = true, then it will do This damage everytime it goes out.
real TempReal//Don&#039;t Touch

endglobals
//===========================================================================
//=================================ENDSETUP==================================
//===========================================================================

private function IfIsElse takes nothing returns nothing
    local real tx
    local real ty
    local real X
    local real Y
    local real dx
    local real dy
        set Caster = GetTriggerUnit()
        set LeashedUnit = GetEnumUnit()
        set tx = GetUnitX(LeashedUnit)
        set ty = GetUnitY(LeashedUnit)
        set X = GetUnitX(Caster)
        set Y = GetUnitY(Caster)
        set dx = X - tx
        set dy = Y - ty
        set TempReal = SquareRoot(dx * dx + dy * dy)
            if TempReal &gt;= range then
                if DoesDamage == true then
                    call SetUnitState(GetEnumUnit(), UNIT_STATE_LIFE, GetWidgetLife(GetEnumUnit()) - Damage )
                    call SetUnitX(GetEnumUnit(), X - 20)
                    call SetUnitY(GetEnumUnit(), Y - 20)
                    call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
                else
            call SetUnitX(GetEnumUnit(), X - 20)
            call SetUnitY(GetEnumUnit(), Y - 20)
            call IssueImmediateOrder(GetEnumUnit(), &quot;Stop&quot;)
        endif
    endif
endfunction

private function ForFun takes nothing returns nothing
       call ForGroup(LeashedUnits, function IfIsElse)
endfunction

function UnitAddLeash takes unit u, unit t, real r returns nothing
        set LeashedUnit = u
        set Caster = t
        set range = r
            call GroupAddUnit(LeashedUnits, LeashedUnit)
        set LeashedUnit = null
        set Caster = null
            call TimerStart(time, .03, true, function ForFun)
endfunction


//===========================================================================
//=================================INIT======================================
//===========================================================================
private function InitTrig_Leash_System takes nothing returns nothing
endfunction

endlibrary

Laiev · Jan 22, 2011

you can remove this:

JASS:

//===========================================================================
//=================================INIT======================================
//===========================================================================
private function InitTrig_Leash_System takes nothing returns nothing
endfunction

NeuroToxin · Jan 25, 2011

Leash system, not detecting range?

New Member

vJass errors are legion

New Member

Active Member

New Member

Super Moderator

New Member

New Member

Super Moderator

New Member

Super Moderator

Active Member

칼리

vJass errors are legion

New Member

vJass errors are legion

Active Member

New Member

Hey Listen!!

New Member

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors