Trigger in JASS-->Crash

Erkki2 · Aug 10, 2008

I created my first trigger in JASS. Actually I converted it from GUI trigger, but I added local variables and used timer instead of wait. At first there were of course some errors, but I fixed them. Then I thought to make that trigger local instead of local, well, then the WE crashed. I can't find any mistakes from my code, so I don't know what's wrong. Here's the code

Code:

function Cond takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A039' ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Func004Func001Func005C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) >= 60 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Func004Func001Func006C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) >= 80 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Func004Func002Func005C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) >= 60 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Func004Func002Func006C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) >= 80 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Func004Func003Func005C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) >= 60 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Func004Func003Func006C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) >= 80 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Actions takes nothing returns nothing
    local unit u
    set u = GetTriggerUnit()
        set bj_forLoopBIndex = 1
        set bj_forLoopBIndexEnd = 10
        loop
            exitwhen bj_forLoopBIndex > bj_forLoopBIndexEnd
            call CreateNUnitsAtLoc( 1, 'n000', GetOwningPlayer(u), PolarProjectionBJ(GetUnitLoc(u), ( 400.00 - ( 40.00 * I2R(GetForLoopIndexB()) ) ), ( 0.00 + ( 10.00 * I2R(GetForLoopIndexA()) ) )), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 5.00, 'BTLF', GetLastCreatedUnit() )
            call ShowUnitHide( GetLastCreatedUnit() )
            call UnitAddAbilityBJ( 'A03E', GetLastCreatedUnit() )
            if ( Trig_Tri_Attack_Func004Func001Func005C() ) then
                call IncUnitAbilityLevelSwapped( 'A03E', GetLastCreatedUnit() )
            else
            endif
            if ( Trig_Tri_Attack_Func004Func001Func006C() ) then
                call IncUnitAbilityLevelSwapped( 'A03E', GetLastCreatedUnit() )
            else
            endif
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), "fanofknives" )
            set bj_forLoopBIndex = bj_forLoopBIndex + 1
        endloop
        set bj_forLoopBIndex = 1
        set bj_forLoopBIndexEnd = 10
        loop
            exitwhen bj_forLoopBIndex > bj_forLoopBIndexEnd
            call CreateNUnitsAtLoc( 1, 'n000', GetOwningPlayer(u), PolarProjectionBJ(GetUnitLoc(u), ( 400.00 - ( 40.00 * I2R(GetForLoopIndexB()) ) ), ( 120.00 + ( 10.00 * I2R(GetForLoopIndexA()) ) )), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 5.00, 'BTLF', GetLastCreatedUnit() )
            call ShowUnitHide( GetLastCreatedUnit() )
            call UnitAddAbilityBJ( 'A03F', GetLastCreatedUnit() )
            if ( Trig_Tri_Attack_Func004Func002Func005C() ) then
                call IncUnitAbilityLevelSwapped( 'A03F', GetLastCreatedUnit() )
            else
            endif
            if ( Trig_Tri_Attack_Func004Func002Func006C() ) then
                call IncUnitAbilityLevelSwapped( 'A03F', GetLastCreatedUnit() )
            else
            endif
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), "fanofknives" )
            set bj_forLoopBIndex = bj_forLoopBIndex + 1
        endloop
        set bj_forLoopBIndex = 1
        set bj_forLoopBIndexEnd = 10
        loop
            exitwhen bj_forLoopBIndex > bj_forLoopBIndexEnd
            call CreateNUnitsAtLoc( 1, 'n000', GetOwningPlayer(u), PolarProjectionBJ(GetUnitLoc(u), ( 400.00 - ( 40.00 * I2R(GetForLoopIndexB()) ) ), ( 240.00 + ( 10.00 * I2R(GetForLoopIndexA()) ) )), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 5.00, 'BTLF', GetLastCreatedUnit() )
            call ShowUnitHide( GetLastCreatedUnit() )
            call UnitAddAbilityBJ( 'A03D', GetLastCreatedUnit() )
            if ( Trig_Tri_Attack_Func004Func003Func005C() ) then
                call IncUnitAbilityLevelSwapped( 'A03D', GetLastCreatedUnit() )
            else
            endif
            if ( Trig_Tri_Attack_Func004Func003Func006C() ) then
                call IncUnitAbilityLevelSwapped( 'A03D', GetLastCreatedUnit() )
            else
            endif
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), "fanofknives" )
            set bj_forLoopBIndex = bj_forLoopBIndex + 1
        endloop
    set u = null
endfunction

function Timer takes nothing returns nothing
    local timer t
    set t = CreateTimer()
    call TimerStart(t,0.01,true,function Trig_Tri_Attack_Actions)
    call TriggerSleepAction(10.00)
    call DestroyTimer(t)
    [B]set t = null[/B] *
andfunction

function InitTrig_trigger takes nothing returns nothing
    local trigger t
    set t= CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Cond))
    call TriggerAddAction(t, function Timer)
endfunction

Inside the loops everything is allright. *Before it crashed, it said there was an error. Why does WE crash?

Exide · Aug 10, 2008

You should use JASS-tags for JASS code.
Also you should post this in the JASS forum.

JASS:


function Timer takes nothing returns nothing
    local timer t
    set t = CreateTimer()
    call TimerStart(t,0.01,true,function Trig_Tri_Attack_Actions)
    call TriggerSleepAction(10.00)
    call DestroyTimer(t)
    set t = null *      //Remove the star.
andfunction      //Typo.

Has a typo, says andfunction. Change it to endfunction, and see what happens.
Also, remove the star from set t = null *

EDIT:
All these functions:

JASS:


function Trig_Tri_Attack_Func004Func001Func005C takes nothing returns boolean
    if ( not ( GetHeroLevel(GetTriggerUnit()) &gt;= 60 ) ) then
        return false
    endif
    return true
endfunction

Could be this:

JASS:


function Trig_Tri_Attack_Func004Func001Func005C takes nothing returns boolean
    return ( GetHeroLevel(GetTriggerUnit()) &gt;= 60 )
endfunction

To make it even shorter, you could do this:

JASS:


    if ( Trig_Tri_Attack_Func004Func001Func005C() ) then

==

JASS:


    if ( GetHeroLevel(GetTriggerUnit()) &gt;= 60 ) then

and remove the:

JASS:


function Trig_Tri_Attack_Func004Func001Func005C takes nothing returns boolean
    return ( GetHeroLevel(GetTriggerUnit()) &gt;= 60 )
endfunction

completely.

Erkki2 · Aug 10, 2008

I fixed the typo, and WE doesn't crash anymore. I made the code simplier by removing if structures. Now there's just one problem: it doesn't create any unit. Here's the fixed code:

JASS:

function Cond takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == &#039;A039&#039; ) ) then
        return false
    endif
    return true
endfunction

function Trig_Tri_Attack_Actions takes nothing returns nothing
    local unit u
    local integer i
    set u = GetTriggerUnit()
        set bj_forLoopBIndex = 1
        set bj_forLoopBIndexEnd = 10
        loop
            exitwhen bj_forLoopBIndex &gt; bj_forLoopBIndexEnd
            call CreateNUnitsAtLoc( 1, &#039;n000&#039;, GetOwningPlayer(u), PolarProjectionBJ(GetUnitLoc(u), ( 400.00 - ( 40.00 * I2R(GetForLoopIndexB()) ) ), ( 0.00 + ( 10.00 * i ) )), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 5.00, &#039;BTLF&#039;, GetLastCreatedUnit() )
            call UnitAddAbilityBJ( &#039;A03E&#039;, GetLastCreatedUnit() )
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), &quot;fanofknives&quot; )
            set bj_forLoopBIndex = bj_forLoopBIndex + 1
        endloop
        set bj_forLoopBIndex = 1
        set bj_forLoopBIndexEnd = 10
        loop
            exitwhen bj_forLoopBIndex &gt; bj_forLoopBIndexEnd
            call CreateNUnitsAtLoc( 1, &#039;n000&#039;, GetOwningPlayer(u), PolarProjectionBJ(GetUnitLoc(u), ( 400.00 - ( 40.00 * I2R(GetForLoopIndexB()) ) ), ( 120.00 + ( 10.00 * i ) )), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 5.00, &#039;BTLF&#039;, GetLastCreatedUnit() )
            call UnitAddAbilityBJ( &#039;A03F&#039;, GetLastCreatedUnit() )
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), &quot;fanofknives&quot; )
            set bj_forLoopBIndex = bj_forLoopBIndex + 1
        endloop
        set bj_forLoopBIndex = 1
        set bj_forLoopBIndexEnd = 10
        loop
            exitwhen bj_forLoopBIndex &gt; bj_forLoopBIndexEnd
            call CreateNUnitsAtLoc( 1, &#039;n000&#039;, GetOwningPlayer(u), PolarProjectionBJ(GetUnitLoc(u), ( 400.00 - ( 40.00 * I2R(GetForLoopIndexB()) ) ), ( 240.00 + ( 10.00 * i ) )), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 5.00, &#039;BTLF&#039;, GetLastCreatedUnit() )
            call UnitAddAbilityBJ( &#039;A03D&#039;, GetLastCreatedUnit() )
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), &quot;fanofknives&quot; )
            set bj_forLoopBIndex = bj_forLoopBIndex + 1
        endloop
    set i = i + 1
    set u = null
endfunction

function Timer takes nothing returns nothing
    local timer t
    set t = CreateTimer()
    call TimerStart(t,0.01,true,function Trig_Tri_Attack_Actions)
    call TriggerSleepAction(10.00)
    call DestroyTimer(t)
    set t = null
endfunction

function InitTrig_Tri_Attack takes nothing returns nothing
    local trigger t
    set t= CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Cond))
    call TriggerAddAction(t, function Timer)
endfunction

Exide · Aug 10, 2008

Your trigger is full of BJ's and leaks.
Why have you converted it to JASS?

You should do this in GUI, it might be easier to read as well..
Why are you looping the same thing 3 times over?

Erkki2 · Aug 10, 2008

Actually, it's not the same thing. They create units 120 degrees to different directions, so they are like in a triangle. Also, The abilities are different, one with fire, one with ice and one with lightning effect. I thought to make this in JASS because it's impossible to make this MUI in GUI. And I'll try to remove leak if I get it work first.

Viikuna · Aug 10, 2008

If you are non mac user, you should get NewGen, it really helps. You can search non BJ functions from NewGens function list, to eplace those BJs in your code.

EDIT. Expect this one:

JASS:

    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT)

Its cool

Erkki2 · Aug 10, 2008

Ok, I'll download that. There's still one question: I guess I won't need it in this trigger, but it's important to know. So, Where should I copy the script when I'm using Kattana's local handle vars?

Exide · Aug 10, 2008

Here's how I would've done it:

JASS:


function Cond takes nothing returns boolean
    return ( GetSpellAbilityId() == &#039;A039&#039; )
endfunction

function Trig_Tri_Attack_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local integer loopnr = 1
    local location loc
    local real angle
    local integer i
    local integer whatability
    
    loop
        exitwhen loopnr &gt; 30
        
        if (loopnr &gt; 0) then
            set angle = 0.00
            set whatability = &#039;A03E&#039;
        elseif (loopnr &gt; 10) then
            set angle = 120.00
            set whatability = &#039;A03F&#039;
        elseif (loopnr &gt; 20) then
            set angle = 240.00
            set whatability = &#039;A03D&#039;
        endif
        
        set loc = GetUnitLoc(u)        
        call CreateNUnitsAtLoc( 1, &#039;n000&#039;, GetOwningPlayer(u), PolarProjectionBJ(loc, ( 400.00 - ( 40.00 * I2R(loopnr) ) ), ( angle + ( 10.00 * i ) )), 270.00 )
        call UnitApplyTimedLife( GetLastCreatedUnit(), &#039;BTLF&#039;, 5.00 )
        call UnitAddAbility( GetLastCreatedUnit(), whatability )
        call IssueImmediateOrder( GetLastCreatedUnit(), &quot;fanofknives&quot; )
        
        set i = i + 1
        set loopnr = loopnr + 1
    endloop
    
    set u = null
endfunction

function Timer takes nothing returns nothing
    local timer t
    set t = CreateTimer()
    call TimerStart(t,0.01,true,function Trig_Tri_Attack_Actions)
    call TriggerSleepAction(10.00)
    call DestroyTimer(t)
    set t = null
endfunction

function InitTrig_Tri_Attack takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Cond))
    call TriggerAddAction(t, function Timer)
endfunction

Didn't test it, so it might not work. But I'm sure you can work that out.

EDIT: If those three different abilities are the same, but with different damage, AoE, whatever. You should use the same ability with three different levels.

> So, Where should I copy the script when I'm using Kattana's local handle vars?
-I'm guessing in the "trigger", in the trigger editor, that is at the very top of your list. -The one with the same name as your map, and that has a different icon than all the other triggers.

Viikuna · Aug 10, 2008

Im not sure if Handle Vars is a good option anymore.. I personally have never used it. There is a lot of gamecache based systems, maybe you should try Table (link) ?

Also, if you are using NewGen and vJass, you should learn how tu use structs, they are really good way store your data.

Erkki2 · Aug 10, 2008

I downloaded NewGen, but I get error when I try to run the editor. It says I should check that Warcraft is not running and that I have the CD in the drive.
Edit: And how to use Table?
Edit2: NewGen works with warcraft version 1.21b, but not with the newer version. Problem is fixed if I use old version for making maps and new version for playing.

Trigger in JASS-->Crash

Erkki2

New Member

Exide

I am amazingly focused right now!

Erkki2

New Member

Exide

I am amazingly focused right now!

Erkki2

New Member

Viikuna

No Marlo no game.

Erkki2

New Member

Exide

I am amazingly focused right now!

Viikuna

No Marlo no game.

Erkki2

New Member

Settings Notifications

Options

Technology - Companies needs to stop using our personal data to train AI

The Helper Discord

Members online

Share this page

Affiliates

Network Sponsors

Trigger in JASS-->Crash

New Member

I am amazingly focused right now!

New Member

I am amazingly focused right now!

New Member

No Marlo no game.

New Member

I am amazingly focused right now!

No Marlo no game.

New Member

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors