Trigger Question

[NapaHero]

My question is:
Does this trigger has its leaks removed?
I'm not sure if I'm setting the Unit Group variable right

And I know it's not MUI

GroundSlam
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Ground Slam 
    Actions
        Set Groundslam_Caster = (Triggering unit)
        Set Groundslam_CasterPoint = (Position of Groundslam_Caster)
        Set Groundslam_Group = (Units within 600.00 of Groundslam_CasterPoint matching ((Level of Dummy Shockwave  for (Matching unit)) Greater than or equal to 1))
        Destructible - Pick every destructible within 450.00 of Groundslam_CasterPoint and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        ((Picked destructible) is alive) Equal to True
                    Then - Actions
                        Destructible - Kill (Picked destructible)
                    Else - Actions
        Wait 0.05 seconds
        Unit - Pause Groundslam_Caster
        For each (Integer A) from 1 to 3, do (Actions)
            Loop - Actions
                Set Groundslam_Point[(Integer A)] = (Groundslam_CasterPoint offset by 600.00 towards (120.00 x (Real((Integer A)))) degrees)
                Unit - Create 1 dummy for (Owner of Groundslam_Caster) at Groundslam_Point[(Integer A)] facing Default building facing degrees
                Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
                Unit - Add Dummy Clap  to (Last created unit)
                Unit - Add Dummy Shockwave  to (Last created unit)
                Unit - Set level of Dummy Clap  for (Last created unit) to (Level of Ground Slam  for Groundslam_Caster)
                Special Effect - Create a special effect at Groundslam_Point[(Integer A)] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
                Unit - Order (Last created unit) to Human Mountain King - Thunder Clap
                Destructible - Pick every destructible within 450.00 of Groundslam_Point[(Integer A)] and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked destructible) is alive) Equal to True
                            Then - Actions
                                Destructible - Kill (Picked destructible)
                            Else - Actions
                Special Effect - Destroy (Last created special effect)
                Unit Group - Add (Last created unit) to Groundslam_Group
                Custom script:   call RemoveLocation (udg_Groundslam_Point[bj_forLoopAIndex])
        Wait 0.50 seconds
        Animation - Play Groundslam_Caster's attack slam animation
        Wait 0.40 seconds
        Special Effect - Create a special effect at Groundslam_CasterPoint using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
        Special Effect - Destroy (Last created special effect)
        Unit Group - Pick every unit in Groundslam_Group and do (Actions)
            Loop - Actions
                Unit - Set level of Dummy Shockwave  for (Picked unit) to (Level of Ground Slam  for Groundslam_Caster)
                Unit - Order (Picked unit) to Orc Tauren Chieftain - Shockwave Groundslam_CasterPoint
                Unit Group - Remove (Picked unit) from Groundslam_Group
        Custom script:   call DestroyGroup (udg_Groundslam_Group)
        Custom script:   call RemoveLocation (udg_Groundslam_CasterPoint)
        Animation - Reset Groundslam_Caster's animation
        Wait 0.50 seconds
        Unit - Unpause Groundslam_Caster

 

[Naminator]

I don't see any leaks Napa .

 

[Tinki3]

That trigger does not leak.

 

[Volkof]

You can check for leaks with this program, but I dont know if the program can still be downloaded

Leak Check Program

Good luck

 

[waaaks!]

or u could read about memory leaks
here
also here

 

[NapaHero]

Thanks

Still, something really is letting me crazy from waaaks 1st suggested tutorial and I really liked that all of you told that there's no leaks, but:

- Groups: Also a common leak, whenever you use "Unit-Group - Pick every unit..." (Also Player and Destructible etc) and you do not use a variable as the group, it will leak.

''Destructible - Pick Every Destructible...'' leaks?

 

[AceHart]

> ''Destructible - Pick Every Destructible...'' leaks?

It would. If there were destructible groups.
There aren't any though, so it doesn't.

Same with "Pick every item in <region>".

 

[NapaHero]

Thanks.