Snippet UnitAlive Fix

Sickle

New Member
Reaction score
13
The common.ai UnitAlive native shares one flaw with the rest of the IsUnitAlive methods. This flaw is that removed units are not recognised as dead immediately after removal. This incredibly short script takes care of that for you.

Yes, it makes RemoveUnit slightly slower. But what sort of psychopath calls RemoveUnit a thousand times a second? The sort that tries to be funny.

Requires vJass. Tested and confirmed to work.
JASS:
function UnitAlive_Fix_Hook takes unit u returns nothing
    call KillUnit(u)
endfunction

hook RemoveUnit UnitAlive_Fix_Hook
 

Weep

Godspeed to the sound of the pounding
Reaction score
400
This keeps you from being able to remove a unit without firing death events.

But you probably knew that.
 

Jesus4Lyf

Good Idea™
Reaction score
397
This breaks things, and has no benefits.

Let me explain. If a unit has [LJASS]RemoveUnit[/LJASS] called on it, then it is being removed. Anything firing before the call completes (such as undefend) should detect that the unit is alive, if it is alive. This would break those things. It also fires death events at a point at which the unit is not dieing, as Weep said.

It also has no benefits. 0 seconds after a unit is removed, it counts as dead under that native anyway. Anything that fires from [LJASS]RemoveUnit[/LJASS] should see it as alive. A unit (as far as I know) cannot fire events after [LJASS]RemoveUnit[/LJASS] has completed. So generally speaking, any code written after [LJASS]RemoveUnit[/LJASS] will be code written with the knowledge that that the unit has just been removed. Now personally, I'd prefer the functionality of knowing whether or not the unit was alive before it was removed to the unhelpful nothingness of the unit being dead, regardless.

In light of that, what's the purpose of this? May I ask what even made you think the unit should count as dead, if it has not died?
 

Weep

Godspeed to the sound of the pounding
Reaction score
400
May I ask what even made you think the unit should count as dead, if it has not died?
Well, if it's not in the game, it's not alive, is it?

He's not the only one who feels that way...
...or is he? *whistles innocently*
 

Sickle

New Member
Reaction score
13
Oh, I have encountered bugs which this has fixed. Removed units counting as alive for 0 seconds (while not really 0 seconds) has caused me some annoyance. If you have not, well then. There is nothing I can do about that. The death event is unfortunate.

If you feel this belongs in the mausoleum, then send it there if this is how you feel.
 

Viikuna

No Marlo no game.
Reaction score
265
You rarely need to remove units at all. When you remove unit, it means that you dont need it anymore and want to get rid of it.

Once its gone, it wont bother you no more. Its just that some timer thingies, or maybe periodic actions might try to do stuff to your unit, even after its removed.

So the simple solution is to code your stuff properly: Have some buff system, so you can easily remove all buffs and timed effects related to your unit, before removing it.

The old good [lJASS]GetWidgetLife( unit ) > .405[/lJASS] has never failed me. Its perfect, if you do your stuff properly.

If you dont do your stuff properly, you most likely get buggs, even if you use some of these "better" death checks. If not with unit being death checks, then at least with some other stuff.
 

Jesus4Lyf

Good Idea™
Reaction score
397
Its just that some timer thingies, or maybe periodic actions might try to do stuff to your unit, even after its removed.
For which [LJASS]UnitAlive[/LJASS] will always return false. This fix is for things that fire before even a 0 second timer would pass (ie. are called directly from the function that removed the unit, or through an event that is fired from that function).
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top