Vision

[Darkonight]

• Shared Vision
  • Events
    • Player - Player 1 (Red) types a chat message containing -vision as A substring
    • Player - Player 2 (Blue) types a chat message containing -vision as A substring
    • Player - Player 3 (Teal) types a chat message containing -vision as A substring
    • Player - Player 4 (Purple) types a chat message containing -vision as A substring
    • Player - Player 5 (Yellow) types a chat message containing -vision as A substring
    • Player - Player 6 (Orange) types a chat message containing -vision as A substring
    • Player - Player 7 (Green) types a chat message containing -vision as A substring
    • Player - Player 8 (Pink) types a chat message containing -vision as A substring
  • Conditions
    • (Substring((Entered chat string), 1, 7)) Equal to -vision
  • Actions
    • Player - Make (Triggering player) treat (Player((Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))))) as an Ally with shared vision

When someone just writes -vision the game crashes

 

[KaerfNomekop]

You should have another condition to check if the relevant substring is an integer, as well as whether Player(Integer) is valid player.

 

[Darkonight]

What does that look like? :O

 

[inevit4ble]

You have to check with which player the triggering player is wanting to share vision with

 

[MP®]

What does that look like? :O

dont have WE here, but its an integer condition:

And (both conditions are true)
- Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))) is greater than 0
- Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))) is less than or equal to 12

if a player just types -vision, the substring will be seen as 0

 

[KaerfNomekop]

• (Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))) Greater than 0 (Integer Comparison)
  • ((Player((Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))))) slot status) Equal to Is playing (Player Slot Status Comparison)

You need these two conditions.

 

[Darkonight]

Made it hapen, Just gotta ask... Why 9? Why (Integer((Substring((Entered chat string), 9, (Length of (Entered chat string))))))? Is 9 the lengt or? Cause i have 7 player max on my :O

 

[KaerfNomekop]

The reason you put 9 is because that's how the substring function works - String, StartInt and EndInt. String is the base string, in this case the entered chat string, and the Substring function lets you draw characters from it. StartInt and EndInt define the range of characters.

Because the string has to start with "-vision ", which has 8 characters, you would take the rest of the entered string, which is whatever comes after "-vision ".

For example, you type "-vision 8". The substring returned would be "8".

 

[Darkonight]

This is what I'm using right now.

• Shared Vision
  • Events
    • Player - Player 1 (Red) types a chat message containing -vision as A substring
    • Player - Player 2 (Blue) types a chat message containing -vision as A substring
    • Player - Player 3 (Teal) types a chat message containing -vision as A substring
    • Player - Player 4 (Purple) types a chat message containing -vision as A substring
    • Player - Player 5 (Yellow) types a chat message containing -vision as A substring
    • Player - Player 6 (Orange) types a chat message containing -vision as A substring
    • Player - Player 7 (Green) types a chat message containing -vision as A substring
    • Player - Player 8 (Pink) types a chat message containing -vision as A substring
  • Conditions
    • (Substring((Entered chat string), 1, 7)) Equal to -vision
    • (Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))) Greater than 0
    • ((Player((Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))))) slot status) Equal to Is playing
  • Actions
    • Player - Make (Triggering player) treat (Player((Integer((Substring((Entered chat string), 9, (Length of (Entered chat string)))))))) as an Ally with shared vision

And its working perfectly, thanks. But i want to have so if you write "-vision all" you do the same thing but to all... How can I make that hapen?

 

[BRUTAL]

This should be what you are looking for.

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) types a chat message containing -vision all as An exact match
  • Conditions
    • (Substring((Entered chat string), 1, 11)) Equal to -vision all
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Make (Triggering player) treat (Picked player) as an Ally with shared vision

 

[Darkonight]

where u have 1-11 i still have 1-7 ?

 

[BRUTAL]

...?
"-vision" contains 7 characters (0-6), while "-vision all" contains 11 characters (0-10).

 

[GFreak45]

incorrect brutal that counts as 1-11, iv used substrings a lot the very first character is #1, ie: Substring (blue,1,1) = b; substring (blue,2,4) = lue so on and so forth

 

[BRUTAL]

I see, looks like my memory has decayed too much in the string area.
Thanks for reminding me anyway.

 

[GFreak45]

i cant say i wouldnt do the same, i only remember that cuz im making a save/load system >.< FML

and your method is correct as long as a condition is added for that length of string, didnt read every post completely sorry

 

[Darkonight]

Alright, so do you say about this? xDDDD

• Shared Vision All
  • Events
    • Player - Player 1 (Red) types a chat message containing -vision all as A substring
    • Player - Player 2 (Blue) types a chat message containing -vision all as A substring
    • Player - Player 3 (Teal) types a chat message containing -vision all as A substring
    • Player - Player 4 (Purple) types a chat message containing -vision all as A substring
    • Player - Player 5 (Yellow) types a chat message containing -vision all as A substring
    • Player - Player 6 (Orange) types a chat message containing -vision all as A substring
    • Player - Player 7 (Green) types a chat message containing -vision all as A substring
    • Player - Player 8 (Pink) types a chat message containing -vision all as A substring
  • Conditions
    • (Substring((Entered chat string), 1, 9)) Equal to -vision all
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Make (Triggering player) treat (Picked player) as an Ally with shared vision

 

[Squeekems]

Don't strings in other high level programming languages usually start with 0?

A string refers to a bunch of characters. Each character can be referred to using an integer.

String: Grunt

Substring(2,4): run

 

[inevit4ble]

ye starts at 0

 

[Squeekems]

• Conditions
  • (Substring((Entered chat string), 1, 9)) Equal to -vision all

String: -vision all

Substring(1,9): -vision a

 

[BRUTAL]

Alright, so do you say about this? xDDDD

Have you tested it? By the looks of it, it is fine.

ye starts at 0

Unfortunately, it seems that it doesn't. I could have sworn it used to be at 0, but when someone brought up that it starts at 1, I quickly made a sample trigger to display the substring from 0-11, and the game displayed this:
"o-vision all"
No idea where the "o" came from, though when i converted the the trigger to custom text and changed the BJ to a native (the SubString function that is; thinking only GUI strings started at 1), and using the native function, what was displayed as:
"-vision all"

Edit:

function SubStringBJ takes string source, integer start, integer end returns string
    return SubString(source, start-1, end)
endfunction

tl;dr GUI strings start at 1, and jass starts at 0.
Looks like my string knowledge remained intact, as a jass user.