Would these functions work?

[D.V.D]

I can't extract my new gen on my laptop and I coded some VERY simple stuff in vjass to have fun and I want to know, would these functions work?

scope Dummy_Functions initalizer init

///////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////
//                                                                           //
// Dummy Functions by D.V.D                                                  //
//                                                                           //
///////////////////////////////////////////////////////////////////////////////
//                                                                           //
// Functions:                                                                //
//                                                                           //
// 1.CreateDummyTarget1( unit,player,point,point,real,ability,order,unit )   //
// 2.CreateDummyTarget2( unit,player,point,real,real,ability,order,unit )    //
// 3.CreateDummyPoint1( unit,player,point,point,real,ability,order,point )   //
// 4.CreateDummyPoint2( unit,player,point,real,real,ability,order,point )    //
// 5.CreateDummyNoTarget( unit,player,point,point,real,ability,order )       //
//                                                                           //
///////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////

globals

struct Spells
ability           a
real              r
real          angle
order          cast
player        owner
location             p
location          face
location   spelltarget
unit              u
unit         target
endstruct

endglobals

private function CreateDummyTarget1 takes unit u, player owner, location p, location face, real r, ability a, order cast, unit target  returns unit
    call CreateNUnitsAtLocFacingLocBJ( 1, u, owner, p, face )
    call UnitAddAbilityBJ( a, u )
    call IssueTargetOrderBJ( u, cast, target )
    call UnitApplyTimedLifeBJ( r, 'BTLF', u )
endfunction

private function CreateDummyTarget2 takes unit u, player owner, location p, real angle, real r, ability a, order cast, unit target returns unit
    call CreateNUnitsAtLocFacingLocBJ( 1, u, owner, p, angle )
    call UnitAddAbilityBJ( a, u
    call IssueTargetOrderBJ( u, cast, target )
    call UnitApplyTimedLifeBJ( r, 'BTLF', u )
endfunction

private function CreateDummyPoint1 takes unit u, player owner, location p, location face, real r, ability a, order cast, location spelltarget returns unit
    call CreateNUnitsAtLocFacingLocBJ( 1, u, owner, p, face )
    call UnitAddAbilityBJ( a, u )
    call IssuePointOrderLocBJ( u, cast, spelltarget )
    call UnitApplyTimedLifeBJ( r, 'BTLF', u )
endfunction

private function CreateDummyPoint2 takes unit u, player owner, location p, real angle, real r, ability a, order cast, location spelltarget returns unit
    call CreateNUnitsAtLoc( 1, u, owner, p, angle )
    call UnitAddAbilityBJ( a, u )
    call IssuePointOrderLocBJ( u, cast, spelltarget )
    call UnitApplyTimedLifeBJ( r, 'BTLF', u )
endfunction

private function CreateDummyNoTarget takes unit u, player owner, location p, location face, real r, ability a, order cast returns unit
    call CreateNUnitsAtLocFacingLocBJ( 1, u, owner, p, face )
    call UnitAddAbilityBJ( a, u )
    call IssueImmediateOrderBJ( u, cast )
    call UnitApplyTimedLifeBJ( r, 'BTLF', u )
endfunction

//===========================================================================
private function InitTrig_Dummy_Functions takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerAddAction( t, function CreateDummyTarget1 )
    call TriggerAddAction( t, function CreateDummyTarget2 )
    call TriggerAddAction( t, function CreateDummyPoint1 )
    call TriggerAddAction( t, function CreateDummyPoint2 )
    call TriggerAddAction( t, function CreateDummyNoTarget )
endfunction

endscope

 

[Azlier]

First, line 1. Initializer, not initalizer.

Second, there is no such type as 'order'.

Third, it would be wise for that struct to be private.

Fourth, your initializer function needs to be called 'init', as defined at the top.

Fifth, how is this useful? We cannot easily use private functions from another scope.

Sixth, why do you even need an initializer?

Seventh, why in the world is there a struct in a globals block there?

Eigth, why are the function set to return units, but are not doing so?

 

[D.V.D]

First, line 1. Initializer, not initalizer.

Second, there is no such type as 'order'.

Third, it would be wise for that struct to be private.

Fourth, your initializer function needs to be called 'init', as defined at the top.

Fifth, how is this useful? We cannot easily use private functions from another scope.

Sixth, why do you even need an initializer?

Seventh, why in the world is there a struct in a globals block there?

Eigth, why are the function set to return units, but are not doing so?

1. Ill change that.

2. What is the variable for orders called then? Like order unit to entangling roots.

3. I'll change that.

4. ?

5. This is just something personal I made that really was made to get better. No this won't be posted on the website and it helps me take out like 5 lines with one function so for me its useful.

6. Never knew if you need it or not. From the tutorial, they never said if you need a initalizer or not. I'll take that out then.

7. I'll take that out. Just a mistake.

8. Well, I thought it returns a unit. What does it return then? never actually got that part of a function so I need help there.

 

[WolfieeifloW]

For initiazlier;
It is "i", not "I".

 

[D.V.D]

Thanks. Still need to know how the return works .

 

[DrEvil]

you return the unit you created :

local unit u = CreateDummyTarget1(....)

plus order is string the string turns to "which order"

 

[D.V.D]

Ah thanks. But, I am creating a unit. Im giving the unit a expiration timer, a ability and ordering him to cast it. That means it should return a unit.

 

[AceHart]

> That means it should return a unit.

Why would it?
It does what you tell it to do. Nothing more, nothing less.
Without a return statement, it won't return anything of interest.

 

[Romek]

You're missing a few brackets at the end of some lines.

Also, in "CreateNUnitsAtLocFacingLocBJ", the final argument should be a location, not a real, like you have in some of your functions.

Why don't you try compiling the code before asking us if it doesn't work? =|

 

[TriggerHappy]

why don't you try compiling the code before asking us if it doesn't work? =|

i can't extract my new gen on my laptop

.

 

[Frozenhelfir]

Your trigger has no events so it wont do anything unless you're executing it from somewhere else.