Snippet Advanced Strings

[SerraAvenger]

And you know, I'm sure its avoidable. I think you only use GetHandleId from 1.24, and only use it to associate things with player colours? You could replace this with a loop... It's only up to 16 colours or whatever, I don't think the efficiency matters... Maybe you could have a flavour for compatability.

12 colors, 12 players that can change their color...
12 * 12 =144 ? It's only once anyway, but still...

On a slightly related note: Gotta mark this day as the day J4L said "I don't think the efficiency matters" (even if totally out of context)

 

[Jesus4Lyf]

12*(average of numbers between 1 and 12 inclusive)=78.

I only press efficiency hard where optimisations are simple or where it's periodic effects.

Anyway, I'm happy to reconstruct this for myself...

 

[Jesus4Lyf]

Bump. This needs some serious updates.

You expose global variables named:

constant string start =      "|c"
constant string end =        "|r"

Your constants are not capitalised, your isX functions are camel cased (should be IsX), and your player string functions break if colours are changed with triggers mid map.

Also "start" there is redundant, it's more logical to type "|cXXXXXX".

 

[Darthfett]

Updated to version 1.65​

Probably an artifact left over from him designing this function for his "Multikick" system.

Correct. Fixed in the new version 1.65

May I be honest?
I don't like that this requires 1.24.

I'd like to use this in my map, but I want my map to work on both 1.23 and 1.24 (for randoms on LAN).

Honest.

And you know, I'm sure its avoidable. I think you only use GetHandleId from 1.24, and only use it to associate things with player colours? You could replace this with a loop... It's only up to 16 colours or whatever, I don't think the efficiency matters... Maybe you could have a flavour for compatability.

I will consider adding a version that works on old versions of warcraft, but the inefficient double loop will be hard to avoid, especially now that it now uses GetHandleId on run-time in order to support dynamic player-color changing systems.

Bump. This needs some serious updates.

You expose global variables named:

constant string start =      "|c"
constant string end =        "|r"

Your constants are not capitalised, your isX functions are camel cased (should be IsX), and your player string functions break if colours are changed with triggers mid map.

Also "start" there is redundant, it's more logical to type "|cXXXXXX".

Honestly hadn't even thought about those. I originally made this for me, so I guess the conventions should be slightly different for submitted work. Updated naming conventions in newest version: Capitalized constants, privatized the string arrays, no more camel-cased function names, removed start string (add it in again if you use it in your map. The "Commonly used strings" sections is meant to give ideas, and give a few common examples).

Unfortunately the Player functions will be slightly slower since they now support dynamic player-colors. Player gray can no longer be initialized as Player(8), and I had to add in a second loop for "red", "blue", "teal", etc strings.

 

[SerraAvenger]

Could start not actually be "|cff" ? I think alpha isn't used in JASS-string formatting anyway.

call BJDebugMsg(red + "Error: "+ end + green + "This is " + end + blue + "super simple!" + end)

AFAIK, end shouldn't be needed till the end of the string.

call BJDebugMsg(red + "Error: "+ green + "This is " + blue + "super simple!" + end)

greetings, Serra

 

[Jesus4Lyf]

Updates are good. You completely lack documentation. Function list, please! :thup:

Also, please apply this method ([LJASS]hook SetPlayerColor OnSetPlayerColor[/LJASS] thing).

 

[Jesus4Lyf]

Graveyarded until this gets some kind of documentation. It's terribly difficult to find what functions this exports as is.

 

[quraji]

One bug I found, in the S2PI (and S2P) function:

    if "gray" == s then //simplest comparisons first is the most efficient way, as it means less calculations in some cases.
        loop
            exitwhen temp >= 12
            if GetPlayerColor(Player(12)) == PLAYER_COLOR_LIGHT_GRAY then
                return temp
            endif
            set temp = temp + 1
        endloop
    endif

I think by the first iteration you'd know whether or not Player 12's color was gray, eh?

There were a couple more things I noticed but I forgot them..

 

[Darthfett]

I think by the first iteration you'd know whether or not Player 12's color was gray, eh?

There were a couple more things I noticed but I forgot them..

Yeah, I found this about 15 minutes before you posted this (while I was breaking it up), haha. I'm glad this is in the graveyard for now.

I'm working on it, and pretty soon I'll release an update. However, you can temporarily replace that '12' with 'temp'.

 

[SerraAvenger]

mind hashing strings for constant tme lookups instead of iterative search in S2P and S2PI?

cya, Serra

EDIT: Fixed missing h in hashing.
Here is a simple hashtable string attacher

///// VER 00 01 - StringAttacher

library StringValue
globals
    private hashtable Default   = InitHashtable()
    private hashtable UseCheck  = InitHashtable()
    private hashtable Value     = InitHashtable()
endglobals

function SetDefaultStringValue takes integer key, integer value returns nothing
    call SaveInteger( Default, key, 0, value )
endfunction

function GetDefaultStringValue takes integer key returns integer 
    return LoadInteger( Default, key, 0 )
endfunction

function HasStringValue takes integer key, string id returns boolean
    return LoadBoolean( UseCheck, key, StringHash( id ) )
endfunction

private function SaveUsed takes integer key, string id, boolean inUse returns nothing
    call SaveBoolean( UseCheck, key, StringHash( id ), inUse )
endfunction

function SetStringValue takes integer key, string id, integer value returns nothing
    if value == GetDefaultStringValue( key ) then
        call SaveUsed( key, id, false )
    else 
        call SaveUsed( key, id, true )
        call SaveInteger( Value, key, StringHash( id ), value )
    endif    
endfunction


function GetStringValue takes integer key, string id returns integer
    local integer result =  GetDefaultStringValue( key )
    if HasStringValue( key, id ) then
        set result = LoadInteger( Value, key, StringHash( id ) )
    endif
    return result
endfunction

struct StringValue extends array
    method operator [] takes string id returns integer
        return GetStringValue( this, id )
    endmethod
    method operator []= takes string id, integer value returns nothing
        call SetStringValue( this, id, value )
    endmethod
endstruct
endlibrary

Allows you to basically do

globals
  private key PLAYER_ID_BY_NAME_KEY 
  StringValue PlayerIdByName = StringValue( PLAYER_ID_BY_NAME_KEY )
endglobals

//...
   local integer i = 0
   loop
       exitwhen i >= 12
       set PlayerIdByName[ GetPlayerName( Player( i ) ) ] = i + 1 // Ofcourse you should make the string lowercase. i+1 required to distinguish between player 1 (0) and no player at all (0, too)
       set i = i + 1
   endloop
// ...
   set temp = PlayerIdByName[ s ]
   if temp != 0 then
       return temp - 1
   endif
// ...

Or you can do....

globals
   key PLAYER_ID_BY_NAME
endglobals

//...
   local integer i = 0
   loop
       exitwhen i >= 12
       call SetStringValue( PLAYER_ID_BY_NAME, GetPlayerName( Player( i ) ), i + 1 ) // Ofcourse you should make the string lowercase. i+1 required to distinguish between player 1 (0) and no player at all (0, too)
       set i = i + 1
   endloop
// ...
   set temp = GetStringValue( PLAYER_ID_BY_NAME, GetPlayerName( Player( i ) ) )
   if temp != 0 then
       return temp - 1
   endif
// ...

Of course, just an inspiration. Feel free to use your own string hashing system.

 

[Darthfett]

mind hasing strings for constant tme lookups instead of iterative search in S2P and S2PI?

cya, Serra

Good idea, thanks!

I've been working hard on the interface, layout, and documentation. Currently, I've split it up into many libraries, so as to allow people to split them up. I'm still not sure if I will be posting them in one thread, or splitting them into several resources. (Most likely the former).

Expect a big update within a week!

 

[bLu3_eYeS]

Look at the error

The Trigger 'AdvStrings' must have an initalization function called 'InitTrig_AdvStrings'

what's wrong ....? it needs a variable or something ?

 

[Komaqtion]

Nah, don't mind that
It's a pop-up error, right ? When you enable the trigger ?

That's just because in vJASS you don't have to specify the initializinf function with a name, you just put [ljass]initializer Init // Or something[/ljass] and you make the function called "Init" the initializer, which really should be called InitTrig_AdvStrings, but you can name it anything in vJASS

 

[bLu3_eYeS]

well...im noob in jass and i need this for multi kick system... ... i don't know how to make it and yes its when i save map / enable the trigger

EDIT: Didn't had JASS Newgen works perfectly now

 

[Darthfett]

This system has received a major update, and has been split into several sub-systems:

• stringColor
• stringType
• stringFilter
• stringFind
• stringPlayer

Thanks everyone for your support in creating this system!