Attaching to unit type ids

Zalinian · Nov 16, 2009

Sorry I couldn't be more descriptive in the title, but I wasn't sure how to word it.
edit: thanks for changing the title to a more appropriate wording.

Anyway here's the issue:
I originally had multiple arrays used to store units/heroes, the file path for their custom icons(used for my multiboard), bounty from killing them, and several other bits of data. I wanted to change this into a structure, since it will look more organized and make adding new units/heroes into the system, or even entire new branches of data easier. All of the data is set in the code and doesn't change.

For Example:

Instead of

unit array unit_list[2]
integer array unit_bounty[2]

set unit_list[1] = Peasant
set unit_list[2] = Footman
set unit_bounty[1] = 10
set unit_bounty[2] = 15

I would set up a struct:

JASS:

globals
   unit_data Peasant_Data
   unit_data Footman_Data
endglobals

struct unit_data
   integer unit (the unit&#039;s integer code)
   integer bounty
endstruct

Then in a function triggered on map initialization:

JASS:

// Peasant
set Peasant_Data.unit = (Peasant&#039;s unit integer code)
set Peasant_Data.bounty = 10
// Footman
set Footman_Data.unit = (Footman&#039;s unit integer code)
set Footman_Data.bounty = 15

I just need a way to look up the correct struct to obtain the data once I have the unit in question.

Is there a way to return data from a struct using its name in a variable? I can get the name of struct, but I can't get to the data if that makes any sense.
IE: A unit dies. {say the unit is a peon}
set name = GetUnitName(GetDyingUnit()) {this would return the string "Peon"}
The data I need I would have stored in Peon_Data. Is there a way to make that jump?

If anyone has any better ideas for storing my data, I'm open to suggestions.

kingkingyyk3 · Nov 16, 2009

Use hashtable. Store the unit's code.

Sevion · Nov 16, 2009

Why don't you just store the unit type name in the struct.

JASS:

globals
   unit_data Peasant_Data
   unit_data Footman_Data
endglobals

struct unit_data
   integer unit (the unit&#039;s integer code)
   integer bounty
   string name
endstruct

JASS:

// Peasant
set Peasant_Data.unit = (Peasant&#039;s unit integer code)
set Peasant_Data.bounty = 10
set Peasant_Data.name = &quot;Peasant&quot;//GetUnitName(someunit)
// Footman
set Footman_Data.unit = (Footman&#039;s unit integer code)
set Footman_Data.bounty = 15
set Footman_Data.name = &quot;Footman&quot;//GetUnitName(someunit)

Zalinian · Nov 16, 2009

Sevion said:

Why don't you just store the unit type name in the struct.

JASS:

globals
   unit_data Peasant_Data
   unit_data Footman_Data
endglobals

struct unit_data
   integer unit (the unit&#039;s integer code)
   integer bounty
   string name
endstruct

JASS:

// Peasant
set Peasant_Data.unit = (Peasant&#039;s unit integer code)
set Peasant_Data.bounty = 10
set Peasant_Data.name = &quot;Peasant&quot;//GetUnitName(someunit)
// Footman
set Footman_Data.unit = (Footman&#039;s unit integer code)
set Footman_Data.bounty = 15
set Footman_Data.name = &quot;Footman&quot;//GetUnitName(someunit)

I'm confused at how this is supposed to fix the problem

kingkingyyk3 said:
Use hashtable. Store the unit's code.

I've never used hashtables, or know anything about them. Would you happen to have a link to a tutorial or something please?

Sevion · Nov 16, 2009

Hold on a second. Let me read again. I was distracted >_>

Edit: Yeah. I have no idea wtf I was thinking. Use a Hashtable with keys or a StringHash of the unit names. [ljass]StoreInteger(HASHTABLE, StringHash(GetUnitName(UNIT)), 0, BOUNTY)[/ljass]

Or maybe I'm just being stupid again. I'm really tired >_> And my contacts are raping my eyes.

Jesus4Lyf · Nov 16, 2009

Based off this:

JASS:

struct TypeData extends array
    integer bounty
    
    //===================================
    // Jesus4Lyf&#039;s Hash function.
    private static constant integer HASH_NEXT=53
    private static constant integer MAX_HASH_VALUE=8191
    private static integer array HashedInt
    static method operator [] takes integer int returns thistype
        local integer hash=int-(int/thistype.MAX_HASH_VALUE)*thistype.MAX_HASH_VALUE
        loop
            exitwhen thistype.HashedInt[hash]==int
            if thistype.HashedInt[hash]==0 then
                set thistype.HashedInt[hash]=int
                return thistype(hash)
            endif
            set hash=hash+thistype.HASH_NEXT
            if hash&gt;=thistype.MAX_HASH_VALUE then
                set hash=hash-thistype.MAX_HASH_VALUE
            endif
        endloop
        return thistype(hash)
    endmethod
endstruct

// Example:
local TypeData d=TypeData[&#039;hfoo&#039;]
set d.bounty=50

local TypeData d=TypeData[GetUnitTypeId(GetTriggerUnit())]
call BJDebugMsg(I2S(d.bounty))

I don't know if it compiles, but this should be about what you want.
If the extending array thing is a problem, I can solve it. But hopefully, it isn't.

Zalinian · Nov 16, 2009

Jesus4Lyf said:

Based off this:

JASS:

struct TypeData extends array
    integer bounty
    
    //===================================
    // Jesus4Lyf&#039;s Hash function.
    private static constant integer HASH_NEXT=53
    private static constant integer MAX_HASH_VALUE=8191
    private static integer array HashedInt
    static method operator [] takes integer type returns thistype
        local integer hash=int-(int/thistype.MAX_HASH_VALUE)*thistype.MAX_HASH_VALUE
        loop
            exitwhen thistype.HashedInt[hash]==int
            if thistype.HashedInt[hash]==0 then
                set thistype.HashedInt[hash]=int
                return thistype(hash)
            endif
            set hash=hash+thistype.HASH_NEXT
            if hash&gt;=thistype.MAX_HASH_VALUE then
                set hash=hash-thistype.MAX_HASH_VALUE
            endif
        endloop
        return thistype(hash)
    endfunction
endstruct

// Example:
local TypeData d=TypeData[&#039;hfoo&#039;]
set d.bounty=50

local TypeData d=TypeData[GetUnitTypeId(GetTriggerUnit())]
call BJDebugMsg(I2S(d.bounty))

I don't know if it compiles, but this should be about what you want.
If the extending array thing is a problem, I can solve it. But hopefully, it isn't.

I'm not totally sure if that does it since I've never dealt with hashtables before. Would someone know a good guide/tutorial for it?

Sevion · Nov 16, 2009

What Jesus is doing is giving you a struct array that is indexed by the unit's ID. So the struct instance for a Footman is [ljass]TypeData['hfoo'][/ljass]

Jesus4Lyf · Nov 16, 2009

>I'm not totally sure if that does it since I've never dealt with hashtables before
It doesn't use hashtables...
Just refer to the example code I posted?

If you follow this link all your problems should be solved, either way...
It allows you to call [LJASS]Hash(unitID)[/LJASS] to convert it to a valid array index that won't clash, and then you can attach a struct using an array...
You can do it with hashtables if you prefer.

Edit: Don't get me wrong, it is exactly what you're after if it compiles, and the code is well tested and works (if it compiles). You don't need to check it.

Zalinian · Nov 16, 2009

Ah sry, I read it too fast. I'll look into it more.

edit: Alright. I don't totally understand it all just yet, but I'm figuring it out. Thanks for the help.

edit:
compile errors. I think I caught them.

JASS:

struct TypeData extends array
    integer bounty
    
    //===================================
    // Jesus4Lyf&#039;s Hash function.
    private static constant integer HASH_NEXT=53
    private static constant integer MAX_HASH_VALUE=8191
    private static integer array HashedInt
    static method operator [] takes integer type returns thistype // &lt;-- takes integer int
        local integer hash=int-(int/thistype.MAX_HASH_VALUE)*thistype.MAX_HASH_VALUE
        loop
            exitwhen thistype.HashedInt[hash]==int
            if thistype.HashedInt[hash]==0 then
                set thistype.HashedInt[hash]=int
                return thistype(hash)
            endif
            set hash=hash+thistype.HASH_NEXT
            if hash&gt;=thistype.MAX_HASH_VALUE then
                set hash=hash-thistype.MAX_HASH_VALUE
            endif
        endloop
        return thistype(hash)
    endfunction // &lt;-- endmethod
endstruct

It compiles now, testing to see if it works correctly.

Edit...again: Works like a charm.

Zalinian · Nov 17, 2009

whoops double posted.

kingkingyyk3 · Nov 17, 2009

JASS:


library UnitTypeData

    struct UnitTypeData extends array
        private static hashtable ht = InitHashtable()
        
        //! textmacro UNIT_TYPE_DATA takes TYPE, DATA, FUNCTION
        private static key $DATA$Key
        
        method operator $DATA$= takes $TYPE$ which$DATA$ returns nothing
            call Save$FUNCTION$(thistype.ht,this,$DATA$Key,which$DATA$)
        endmethod
        
        method operator $DATA$ takes nothing returns $TYPE$
            return Load$FUNCTION$(thistype.ht,this,$DATA$Key)
        endmethod
        //! endtextmacro
        
        //! runtextmacro UNIT_TYPE_DATA(&quot;string&quot;, &quot;Name&quot;, &quot;Str&quot;)
        //! runtextmacro UNIT_TYPE_DATA(&quot;integer&quot;, &quot;Bounty&quot;, &quot;Integer&quot;)

    endstruct
    
endlibrary

This has simpler interface. If you want new type of data, use the textmacro.
This is faster than Hash when Hash meets collision.

JASS:


    function Test takes nothing returns nothing
        set UnitTypeData[&#039;hpea&#039;].Name = &quot;I am a peasant.&quot;
        set UnitTypeData[&#039;hpea&#039;].Bounty = 10
    endfunction

Jesus4Lyf · Nov 17, 2009

>This has simpler interface. If you want new type of data, use the textmacro.
No, it doesn't. That's nasty.

>This is faster than Hash when Hash meets collision.
No, it is slower.

kingkingyyk3 · Nov 17, 2009

>No, it is slower.
Loop uses a bit of process.

Jesus4Lyf · Nov 17, 2009

Array read doesn't (comparatively). You use a hashtable when I use an array read, not when I use a collision check.

eXirrah · Nov 18, 2009

When I do things like this I always use 1 array and the units type id's for indexes.

for example

JASS:

globals
    integer array UnitsBounty
endglobals
 //footman = &#039;u000&#039;
// peasant = &#039;u001&#039;
// knight  = &#039;u002&#039;
//.....

function UnitDies takes nothing returns nothing
    local player p = GetOwningPlayer(GetDyingUnit())
    local integer i = GetUnitTypeId(GetDyingUnut()) - &#039;u000&#039;
    local integer g = GetPlayerState(p,PLAYER_STATE_RESOURCE_GOLD)
    call SetPlayerState(p,PLAYER_STATE_RESOURCE_GOLD,g+UnitsBounty<i>)
endfunction

function OnInit takes nothing returns nothing
    set UnitsBounty[0] = 15 // footman bounty &#039;u000&#039;-&#039;u000&#039; = 0
    set UnitsBounty[1] = 20 // peasant bounty &#039;u001&#039;-&#039;u000&#039; = 1
    set UnitsBounty[2] = 25 // knight bounty &#039;u002&#039;-&#039;u000&#039; = 2 
endfunction
</i>

EDIT: As Jesus4Lyf reminded me in order to use my system of typeid indexing you
need to use Jass NewGen pack with enabled Grimoire -> Enable Object Editor Hack

Jesus4Lyf · Nov 18, 2009

Looks good, if you force types in the object editor.

Attaching to unit type ids

New Member

Visitor (Welcome to the Jungle, Baby!)

The DIY Ninja

New Member

The DIY Ninja

Good Idea™

New Member

The DIY Ninja

Good Idea™

New Member

New Member

Visitor (Welcome to the Jungle, Baby!)

Good Idea™

Visitor (Welcome to the Jungle, Baby!)

Good Idea™

New Member

Good Idea™

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors