% chance on attack, using "damage" library

[shiFt]

How do I detect attacks using this system, like a simple %chance on attack you get x effect. like bash etc.

Do I just use this bool

Damage_IsAttack

? to detect if its from an attack then my chance then the effect?

What if a spell deals physical damage and it sets this off?

 

[kingkingyyk3]

What if a spell deals physical damage and it sets this off?
You need to trigger all damage stuffs in spells.

Do I just use this bool
Yes.

 

[Viikuna]

The trick is simply to trigger all other sources of damage, but attacks. If damage was not dealt by one of systems damaging functions, it must be an attack.

Its same idea than with using projectile system for projectiles so you can for example make some slow time stuff, or using a buff system for buffs, so you can tranfer buffs from unit to another, oruse some buff class stuff.

The more you trigger stuff, the more you know whats actually happening in your map and the more you can control it.

 

[dudeim]

that will detect if it's a normal attack and won't fire if you deal physical damage using spells etc.. but when dealing damage using

call Damage_Physical takes unit source, unit target, real amount,attacktype whichType, boolean attack, boolean ranged

and you set boolean attack to true then it will be registerd as a normal attack

 

[shiFt]

Here is a simple chance to stormbolt a unit on attack, where would I insert the what event would I use, and where to put the boolean from the library?

scope STUN initializer Init 

globals
    private constant integer SPELL_ID = 'A00V'
    private constant integer DUMMY_ID =  'h00J'
    private constant integer DUMMY_SPELL =  'A00X'
endglobals

private function Conditions takes nothing returns boolean
    if ( not (Damage_IsAttack() == true)  ) then
        return false
    endif
    if ( not ( GetUnitAbilityLevel(GetEventDamageSource(), SPELL_ID) > 0 ) ) then
        return false
    endif
    return true
endfunction

private function Actions takes nothing returns nothing
    local unit u = GetEventDamageSource()
    local unit t = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local unit d
    local integer lvl = GetUnitAbilityLevel(u,SPELL_ID)
    set d = CreateUnit( p, DUMMY_ID, x, y, x)
    call UnitApplyTimedLife( d,  'BTLF', 0.50)
    call UnitAddAbility(d, DUMMY_SPELL)
    call SetUnitAbilityLevel(d,DUMMY_SPELL,lvl)    
    call IssueTargetOrder(d, "thunderbolt", t)
    
    
    set t = null
    set d = null
    set u = null
    set p = null
endfunction

//===========================================================================
private function Init takes nothing returns nothing
 local trigger t = CreateTrigger(  )
		
        call Damage_RegisterEvent(t)
		call TriggerAddCondition( t, Condition( function Conditions ) )
		call TriggerAddAction( t, function Actions )
		
		set t = null
	endfunction
    
endscope

 

[kingkingyyk3]

First of all, recycle the dummy. Set the animation and casting time of dummy to 0.000.
You can use "and" in your condition.

 

[Laiev]

scope STUN initializer Init 

globals
    private constant integer SPELL_ID = 'A00V'
    private constant integer DUMMY_ID =  'h00J'
    private constant integer DUMMY_SPELL =  'A00X'
endglobals

private function Conditions takes nothing returns boolean
    return Damage_IsAttack() and GetUnitAbilityLevel(GetEventDamageSource(), SPELL_ID)
endfunction

private function Actions takes nothing returns nothing
    local unit u = GetEventDamageSource()
    local unit t = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local unit d
    local integer lvl = GetUnitAbilityLevel(u,SPELL_ID)

    set d = CreateUnit(p, DUMMY_ID, x, y, x)
    call UnitApplyTimedLife(d,  'BTLF', 0.50)
    call UnitAddAbility(d, DUMMY_SPELL)
    call SetUnitAbilityLevel(d,DUMMY_SPELL,lvl)    
    call IssueTargetOrder(d, "thunderbolt", t)
    
    set t = null
    set d = null
    set u = null
    set p = null
endfunction

private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call Damage_RegisterEvent(t)
    call TriggerAddCondition(t, Condition(function Conditions))
    call TriggerAddAction(t, function Actions)
    set t = null
endfunction    
endscope

 

[shiFt]

I get a complie error, on the conditions, cannot convert integer to boolean?

 

[PurgeandFire]

Change:

    return Damage_IsAttack() and GetUnitAbilityLevel(GetEventDamageSource(), SPELL_ID)

To this:

    return Damage_IsAttack() and GetUnitAbilityLevel(GetEventDamageSource(), SPELL_ID) > 0

=P

 

[Laiev]

my mistake

 

[shiFt]

yay it works +reps

Are there any standard war3 spells that use physical damage as a base, that would maybe interfere with this system?, as this would be the first damage detection system usage in my map, will be converting it all as this now works.

 

[Laiev]

the reason to you need to trigger every damage spell is because everything which you don't trigger, will be in the 'group' Damage_IsAttack()

example:

a crushing wave, a stomp or thunder clap, both will be in Damage_IsAttack() because you don't (can't) register what type of damage it is

in the trigger you can, with the trigger function (Damage_Spell(...)) etc..

 

[shiFt]

so normal war3 spells could set this event off? without it being an actual attack

if I say cast a shockwave, would that mean that Id have to trigger the whole spell from scratch or could I just make a dummy cast a dummy shockwave? In doing this the Hero is not damaging the targets at all the dummy is, so it would not set these events off?

 

[Jesus4Lyf]

Then just check that the unit type of the damager is not 'dumy' as well? (Whatever your dummy's rawcode is.)

 

[shiFt]

so with this method I can avoid 'triggering' all damage?

 

[cleeezzz]

yes

even though triggering all damage is more work, it gives you more freedom

 

[Jesus4Lyf]

so with this method I can avoid 'triggering' all damage?

Check this out:

library OnAttack uses Damage
    globals
        Event AttackEvent // use AttackEvent.register(t) directly. or write some wrapper.
    endglobals
    private module InitAttack
        private static method onDamage takes nothing returns boolean
            if Damage_IsAttack() and GetUnitTypeId(GetEventDamageSource())!='dumy' then
                call AttackEvent.fire()
            endif
            return false
        endmethod
        private static method onInit takes nothing returns nothing
            local trigger t=CreateTrigger()
            call Damage_RegisterEvent(t)
            call TriggerAddCondition(t,Filter(function thistype.onDamage))
            set OnAttack=Event.create()
        endmethod
    endmodule
    private struct Init extends array
        implement InitAttack
    endstruct
endlibrary

I just hacked this up quickly (no syntax check), but you get the idea.
Makes it very reusable. You can calculate your own method of detecting when something is not an attack.