Destroy force help

[jomik]

scope BaseIncome initializer Init

    private function fTrue takes nothing returns boolean
        return true
    endfunction
    
    function GiveGold takes nothing returns nothing
        local player p = GetEnumPlayer()
        call SetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) + 2)
    endfunction

//From here
    
    private function actions takes nothing returns nothing
        local force f = CreateForce()
        call ForceEnumPlayers(f,Condition(function fTrue)) 
        call ForForce(f, function GiveGold)
        call DestroyForce(f)
        set f = null
    endfunction

//To here

    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterTimerEvent(t, 1.00, true)
        call TriggerAddAction(t, function actions)
    endfunction
    
endscope

vJASS...
This will not destroy all players right? :O

 

[Jesus4Lyf]

It won't. Now do this instead:

    function GiveGold takes nothing returns boolean
        local player p = GetFilterPlayer()
        call SetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) + 2)
return false
    endfunction

//From here
    
globals
private force FORCE=CreateForce()
endglobals
    private function actions takes nothing returns nothing
        call ForceEnumPlayers(FORCE,Filter(function GiveGold))
    endfunction

//To here

:thup:
Good Idea™.

 

[kingkingyyk3]

Why not loop through every players?

 

[Jesus4Lyf]

>Why not loop through every players?
Because nobody's perfect...

*Shrugs*
That would be ideal.

 

[jomik]

Why're you making FORCE global? :O
And can you explain the Filter(...) incase I want it to be only playing players? :O
And should I loop through all players instead, and just check if players are playing? - I don't want that in this code buut

 

[Jesus4Lyf]

>And should I loop through all players instead, and just check if players are playing?
Yea.

Explaining the same stuff but for unit groups.

 

[jomik]

Thanks dude

 

[Rushhour]

just curious: what about the local player handle? No need to null it in that case or simply forgotten ?^^
Edit: Guess jesus4life copy pasted and the mistake wasn't made by him?! ;P

 

[jomik]

Thought you should null it, and destroy - null the player force too :O