Patch 1.24 doesn't run my map?

[waaaks!]

I've updated some of the systems I'm using in my map (Table, TimerUtils), and replaced the return bug to return GetHandleId(h), JNGP 1.5d compiled it correctly, but when I clicked test map, wc3 doesn't run the map.

Is there anything I need to change before the map will be playable? Do I need to upload the map?

 

[Jesus4Lyf]

Read the threads about it, we can't keep making new threads for the same stuff.

 

[cleeezzz]

go through all your triggers and just do Ctrl+F, type "elseif" without quotations, and if that if/then/elseif block uses a return somewhere, change it.

soo..

if i > 5 then
    return 5
elseif i < 5 then
    return 6
endif

becomes

if i>5 then
    return 5
endif
if i < 5 then
    return 6
endif

if for specific reasons, the 2nd if should not run if the first if passes, then just do a local boolean = false. if i>5 then, set boolean = true, return 5.
then in the 2nd If, check if boolean is true or not

 

[waaaks!]

Read the threads about it, we can't keep making new threads for the same stuff.

I am already browsing through the threads which discussed about the new patch, but I still don't have a definite solution to fix the codes.

so this would simply works?

local boolean b = false
if i > 5 then
    set b = true    
    return 5
endif
if not b then
    return 6
endif

If this is the only thing I need to do with my codes, what about this?

//by PurplePoot
if true then
    return true //Return! Finish this block
else //Old block finished! Jump to endif
    call DoSomething()
endif //Jumped here
return false //Alert: Two adjacent returns!

can I turn this into this?:

if true then
    return true
endif

if false then
    return false
endif

EDIT: Changed all the codes with elseif-return block to what cleeezzz said, and still the map doesn't run

 

[lovexylitol]

First of all, JASS only allows you to define locals at the start of a function.

Secondlly, boolean b is defined in the scope of the if-endif block, so even if JASS allowed to define locals anywhere, it would not work.

Also, an if false block will never run since its condition is always false.

If you want to change

if a then
 b
 return c
else
 d
endif

Then just put d outside the if-endif block. If a is true, it will execute b and return c, if a is false, it will jump to d.

if a then
 b
 return c
endif
d

 

[waaaks!]

oh yeah I forgot (I thought it was the first line in the function), edited the code again, already tried fixing the else-ifs, and still doesn work, I wonder how DotA All-stars 6.61c get it working?

 

[cleeezzz]

that should be it, no H2I and no if/then/elseifs that return

you might have missed one?

maybe you could post your war3map.j and we could help scan for errors

(can be extracted using MPQMaster or something)

 

[waaaks!]

I don't know if I need to change something like this:

if bla then
    return this
elseif bloo then
    return that
elseif blarg then
    return those
else
    return there
endif

I still didn't changed them because I can't find a way to convert them into individual if then blocks, while in wc3c.net anitarf said, that his ABuff completely compiled and run, only the demo spells are changed, and in his ABuff system, I saw similar blocks like I posted above, also in other systems.

Just wondered about xe and ABuff, if the libraries are fine, then why the demo spells inside the map need to be changed? while the spells used the system, and some attachment system like Table 3.0, maybe this caused my problem.

Thanks for the help, but maybe I'll post the open version of the map, I don't mind about it, as long as the map will be fixed and be compatible in 1.24

Uploaded the map above, and also the .j

 

[waaaks!]

BUMP
Attachment removed, fixed the map, now working in 1.24, oh yeah!!