'simpler' Meathook

[13lade619]

i've looked through he meathook submissions on the spell section..

and i'm thinking...
tinki3's meathook was a little dull, 'cause the chain was static.

kenny's on the other hand looked really good with the moving chain.
but the code was uber... too much.. lol.

i want a simpler one, without the bouncing that makes it complicated.

i was thinking a little on the middle..
Kenny's used LinkedLists.. but i think i may not.

question: is it possible to replicate the 'moving chain' using an array of structs only? (not a linked list of structs.)

 

[kingkingyyk3]

Yep

 

[Jesus4Lyf]

It is if you know the length of the chain.

 

[Kenny]

Hahahaha. The code complication is there so that you don't have do deal with all the faults of poorly made meathooks. You can of course, turn the bouncing and stuff off.

And it is indeed possible to use a struct array, but I don't see why you would. A linked list is just an organised array.

(I was actually working on a MeatHook system that would allow multiple meathooks in a map, each with different functions and visual effects, but my map got corrupted somehow )

 

[13lade619]

It is if you know the length of the chain.

tinki3's OLD array approach just made an array of size 400... and left the unused chains blank...

is that inefficient?

Hahahaha. The code complication is there so that you don't have do deal with all the faults of poorly made meathooks. You can of course, turn the bouncing and stuff off.

And it is indeed possible to use a struct array, but I don't see why you would. A linked list is just an organised array.

i'll try some modifications then.. before i decide if i really need to make my own.

 

[Kenny]

If my computer was working, I could update my Meathook spell for you, with better movement, more efficient unit group usage and all that. But as I said before, the code is just long because it attempts to fix problems that can go wrong in different map types.

 

[Jesus4Lyf]

He just needs it not to bounce, right?
An array is less efficient than a list, yes.

 

[13lade619]

so i guess i'll save myself the trouble and import your 864 lines of code .

 

[Kenny]

Hahahaha, it's only like 700 without comments.

But yeah, you can just set:

private constant boolean    ALLOW_BOUNCE     = true
private constant boolean    DEST_BOUNCE      = true

To false, and you have no bouncing.

I will try to get an update out as soon as possible to fix a few issues I have with it.

 

[Jesus4Lyf]

I will try to get an update out as soon as possible to fix a few issues I have with it.

Reasons like this you should use other people's code. They maintain it for ya. :thup:

 

[13lade619]

hey... i think i broke it.

all i did was change the model and the constants...

i casted a load of hooks... no probs.
but then i tried to outrun the hook by blinking in front of it.

then this happened.

the chain stopped moving.
but links appeared behind me when i walked around.

 

[Kenny]

That is the problem that Jesus4Lyf found.

It actually has already been fixed. However I can't do much about it now due to my map with all my work getting erased.

If you wanted to try something..

Find the structs named Link and List in the spell and replace them with this:

private struct Link // Individual links in the linked list for units.
    
        thistype next = 0     // Next link in the list.
        thistype prev = 0     // Previous link in the list.
        unit     link = null  // The actual chain link.
        
        // Reset all the members for this struct instance.
        private method onDestroy takes nothing returns nothing
            // Remove the chain link.
            call RemoveUnit(this.link)
            set this.link = null
        endmethod
        
    endstruct
   
    //---------------------------------------------------------------------\\
    private struct List // Linked list to hold all the units that make the chain.

        Link    head = 0 // First link in the list.
        Link    last = 0 // Last link in the list.
        integer size = 0 // Size of the list.
    
        // Attach a link to the list.
        method attach takes nothing returns Link
            local Link curr = Link.create() // Create a link.
            
            // Restructuring the start of the list.                        
            if this.head == 0 then
                // If there is nothing in the first, set the new link to the head.
                set this.head = curr
            else
                // Otherwise, attach the new link to the end of the list.
                set curr.prev = this.last
                set this.last.next = curr
            endif
            
            // Setting the rest of this link and incrementing list size.
            set this.last = curr
            set this.size = this.size + 1
        
            return curr
        endmethod

        // Detach a link from the list.
        method detach takes Link curr returns nothing
            // Removing a link from the list.            
            if curr.next == 0 then
                set this.last = curr.prev
            else
                set curr.next.prev = curr.prev
            endif
            
            set curr.prev.next = curr.next
            
            // Destroy the link.
            call curr.destroy()
        
            // Decrement size of list.
            set this.size = this.size - 1
        endmethod
        
        // Destroy the list.
        private method onDestroy takes nothing returns nothing
            // Just to make sure no links are left.
            loop
                exitwhen this.size == 0
                call this.detach(this.last)
            endloop
        endmethod
    
    endstruct

And tell me how it goes.

 

[13lade619]

In the extend method:

                set linkx = this.list.first

first is not a member of MeatHookRevisited___List

 

[Kenny]

Hahahaha shiiiitt... Okay replace them with this:

private struct Link // Individual links in the linked list for units.
    
        thistype next = 0     // Next link in the list.
        thistype prev = 0     // Previous link in the list.
        unit     link = null  // The actual chain link.
        
        // Reset all the members for this struct instance.
        private method onDestroy takes nothing returns nothing
            // Remove the chain link.
            call RemoveUnit(this.link)
            set this.link = null
        endmethod
        
    endstruct
   
    //---------------------------------------------------------------------\\
    private struct List // Linked list to hold all the units that make the chain.

        Link    first = 0 // First link in the list.
        Link    last  = 0 // Last link in the list.
        integer size  = 0 // Size of the list.
    
        // Attach a link to the list.
        method attach takes nothing returns Link
            local Link curr = Link.create() // Create a link.
            
            // Restructuring the start of the list.                        
            if this.first == 0 then
                // If there is nothing in the first, set the new link to the head.
                set this.first = curr
            else
                // Otherwise, attach the new link to the end of the list.
                set curr.prev = this.last
                set this.last.next = curr       
            endif
            
            // Setting the rest of this link and incrementing list size.
            set this.last = curr
            set this.size = this.size + 1
        
            return curr
        endmethod

        // Detach a link from the list.
        method detach takes Link curr returns nothing
            // Removing a link from the list.            
            if curr.next == 0 then
                set this.last = curr.prev
            else
                set curr.next.prev = curr.prev
            endif
            
            set curr.prev.next = curr.next
            
            // Destroy the link.
            call curr.destroy()
        
            // Decrement size of list.
            set this.size = this.size - 1
        endmethod
        
        // Destroy the list.
        private method onDestroy takes nothing returns nothing
            // Just to make sure no links are left.
            loop
                exitwhen this.size == 0
                call this.detach(this.last)
            endloop
        endmethod
    
    endstruct

 

[13lade619]

works fine now.

 

[weaaddar]

In jass land, actually an array is more effecient then a linked list for the obvious reason that the linked list nodes are array elements.