TimerUtils with the new patch

[Embrace_It]

The following does not seem to work anymore. This is the function I normally use when calling TimerStart(t, SomeReal, false, function Update):

private function Update takes nothing returns nothing
   local timer t = GetExpiredTimer()
   local Data d = Data(GetTimerData(t))

   ...

endfunction

Is this correct or not? I tried putting a debug message in this function and the text did not appear...

 

[cleeezzz]

i thought it was just

local Data d = GetTimerData(t)

 

[Embrace_It]

Hmm, might be since I heard struct are "just" integers. Anyways, I tested and it does not work. Here is the code if it helps:

scope Berserk initializer Init
private keyword Data

//  -------------
// | START SETUP |
//  -------------
globals
    private constant integer ABILITY_CODE = 'A008'
endglobals

private function ExtraRegenerationPerLevel takes integer lvl returns real
    return (lvl - 1.) * 3. + 5.
endfunction
//  -----------
// | END SETUP |
//  -----------

private struct Data
    unit source
    real oldvalue
    real percentage
    real newvalue
    
    static method create takes unit source, real oldvalue, real percentage returns Data
        local Data d = Data.allocate()
        
        set d.source     = source
        set d.oldvalue   = oldvalue
        set d.percentage = percentage
        set d.newvalue   = oldvalue * (1. + percentage)
        call SetStaminaMelee(source, d.newvalue)
        
        return d
    endmethod
endstruct

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == ABILITY_CODE
endfunction

private function Update takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local Data d = GetTimerData(t)
call BJDebugMsg("lol")
    call SetStaminaMelee(d.source, d.newvalue / (1 + d.percentage))
    call ReleaseTimer(t)
    call CreateFloatingTextTarget(d.source, "Berserk fades", "|cffd2691e")
    call d.destroy()
    
    set t = null
endfunction

private function Actions takes nothing returns nothing
    local unit source = GetTriggerUnit()
    local integer lvl = GetUnitAbilityLevel(source, ABILITY_CODE)
    local timer t = NewTimer()
    local Data d = Data.create(source, GetStaminaMelee(source), ExtraRegenerationPerLevel(lvl))
    
    call CreateFloatingTextTarget(source, "Berserk!", "|cffd2691e")
    call SetTimerData(t, integer(d))
    call TimerStart(t, 25., false, function Update)
    
    set source = null
endfunction

// Main function
private function Init takes nothing returns nothing
    local trigger trig = CreateTrigger()

    call TriggerRegisterAnyUnitEventBJ(trig, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(trig, Condition(function Conditions))
    call TriggerAddAction(trig, function Actions)

    set trig = null
endfunction

endscope

Please ignore the stamina-related stuff

 

[Joker(Div)]

have you updated to the new timerutils?

 

[TriggerHappy]

Make sure you have your TimerUtils updated to version 1.24 (According to the TimerUtils page, it says 1.23b+).

 

[Vexorian]

Define "does not seem to work anymore"

 

[Embrace_It]

TimerUtils has been updated.

It does not seem to work anymore, since it did before the new patches. Assuming, of course, that the patching is the problem, but it is the most recent major change made to wc3 so I assume it is...

 

[Embrace_It]

Found a silly mistake, the problem has been solved!