What can crash Warcraft III without an error notification?

N-a-z-g-u-l

New Member
Reaction score
30
JASS:
function ExitWarcraft takes nothing returns nothing
	loop
		call ExecuteFunc("ExitWarcraft")
	endloop
endfunction

function FreezeWarcraft takes nothing returns nothing
	loop
		call TriggerSyncReady()
		call ExecuteFunc("FreezeWarcraft")
	endloop
endfunction

function BreakThread takes nothing returns nothing
	local integer i = 1/0
endfunction

function CriticalError takes nothing returns nothing
	call ExecuteFunc("0")
endfunction

function GotoMenu takes nothing returns nothing
	call EndGame(false)
endfunction


I know several ways to crash Warcraft, but I wonder whether there are more possibilities to just exit it without a notification. I had that crash in one of my maps some minutes ago, and it would really help me fix that bug, if someonw of you knew another way to exit Warcraft instantly.

Basically the map is 11k lines of custom code, and that crash does not happen everytime I play it, it is very rare. I can't reproduce it and don't have an idea of what may cause it.
 

ZakkWylde-

New Member
Reaction score
14
You mean so that it doesn't show a fatal error?
If you or anyone else figures this out, I would love you/him/her :D

If you figure out HOW that happens, post your code on this thread so that I may ninja it and give you credit =)

EDIT: uhhh, wait...that script you have there exits WC3 immediately?
 

N-a-z-g-u-l

New Member
Reaction score
30
JASS:
function ExitWarcraft takes nothing returns nothing
	loop
		call ExecuteFunc("ExitWarcraft")
	endloop
endfunction


its this function, it just closes warcraft without any message

and heres a version for just one player, however, this may open the "player lags" window... dont know.
JASS:
function ExitWarcraftForPlayer takes player p returns nothing
	if GetLocalPlayer()==p then
		call ExitWarcraft()
	endif
endfunction


i am searching for other alternatives, because i am sure i dont do something like that in my map... and i want to fix that bug.
 

ZakkWylde-

New Member
Reaction score
14
So another principle for closing WC3?
(That is, not using the same type of non-fatal error crash you have?)

The one-player version is for one person in a group game (with 2 or more people)? Not for single-player?
How does [ljass]GetLocalPlayer()==p[/ljass] do that?
 

Troll-Brain

You can change this now in User CP.
Reaction score
85
There are some "hidden" infinite loops.
For example did you know that an unit get a point order 851973, when you pause it, and it wasn't already paused/stunned ?
Imagine inside a trigger, you register point/target orders, you don't check the orders received, and pause , order unit to "stop", unpause unit, tadaa you've an infinite evaluation/execution of this trigger.
 

ZakkWylde-

New Member
Reaction score
14
Uhh...using get local player...this is what I have...
Azlier basically made this whole code, I'm just trying to fix it up for personal purposes:

JASS:
library GetSavingPlayer initializer Init requires Event //Note to self: needs polishing.

globals
    private Event Ev
    private player SavingPlayer = null
    private unit array U
    private integer LocalId
endglobals

constant function GetSavingPlayer takes nothing returns player
    return SavingPlayer
endfunction

function ExitWarcraft takes nothing returns nothing
	loop
		call ExecuteFunc("ExitWarcraft")
	endloop
endfunction

function TriggerRegisterGameSaved takes trigger t returns nothing
    call Ev.register(t)
endfunction

private function OnClick takes nothing returns boolean
    local integer i = 0
    set SavingPlayer = GetOwningPlayer(GetTriggerUnit())
    call Ev.fire()
    loop
        exitwhen i > 11
        if GetPlayerName(SavingPlayer) == udg_NameArray<i> and GetPlayerName(SavingPlayer) != udg_NameArray[0] then
            ////////////////////////////////////////////
            if GetLocalPlayer() == Player(i) then //IMPORTANT PART, really
                call ExitWarcraft()   //IMPORTANT PART, really
                set i = 12
            endif
            ////////////////////////////////////////////
        endif
    set i = i + 1
    endloop
    set SavingPlayer = null
    return false
endfunction

private function OnSave takes nothing returns boolean
    call SelectUnit(U[LocalId], true)
    call SelectUnit(U[LocalId], false)
    return false
endfunction

private function Init takes nothing returns nothing
    local trigger t
    local integer i = 11
    set LocalId = GetPlayerId(GetLocalPlayer())
    set Ev = Event.create()
    loop
        set t = CreateTrigger()
        call TriggerRegisterGameEvent(t, EVENT_GAME_SAVE)
        call TriggerAddCondition(t, Condition(function OnSave))
        if GetLocalPlayer() != Player(i) then
            call DisableTrigger(t)
        endif

        set t = CreateTrigger()
        set U<i> = CreateUnit(Player(i), &#039;hfoo&#039;, 10000, 10000, 270)
        call PauseUnit(U<i>, true)
        call TriggerRegisterUnitEvent(t, U<i>, EVENT_UNIT_SELECTED)
        call TriggerAddCondition(t, Condition(function OnClick))
        exitwhen i == 0
        set i = i - 1
    endloop
endfunction

endlibrary</i></i></i></i>


So that kicks the saving player (for the moment after the game saves)...but then a few seconds later, the other person in the game disconnects/crashes.

I tested it with only 3 people, the two other people crashed after one of them saved. Any suggestions as to how to fix this?
 

ZakkWylde-

New Member
Reaction score
14
Wrong thread?

Anyway, insta-crash with no error can be achieved by a trigger that fires its own event in an infinite loop. Like recursive damage (with no end).

...Not exactly the wrong thread. I'm trying to crash one person's Warcraft III ONLY. If that is possible...
 

N-a-z-g-u-l

New Member
Reaction score
30
Wrong thread?

Anyway, insta-crash with no error can be achieved by a trigger that fires its own event in an infinite loop. Like recursive damage (with no end).

thanks, that was a good hint... i added some safety checks there, i dont know whether this fixed it, but anyways, safety can never be wrong.

by the way, this is the map i am talking about: http://supcom.btanks.net/
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top