Critic my (bad) projectile system

[Nestharus]

if GetUnitState(.Unit, UNIT_STATE_LIFE) <= 0 then

Should be GetWidgetLife or w/e.

I actually said that in this post as well..

GetWidgetLife is faster.

 

[Narks]

I actually meant the arbitrary 0.405 number.

Why that?

 

[Azlier]

0.407 is better.

Because something abut 0.407 (or possibly 0.0407) being the exact level of health at which a unit dies. So <= 0 can be unreliable or something, I guess.

 

[Troll-Brain]

0.407 is better.

Because something abut 0.407 (or possibly 0.0407) being the exact level of health at which a unit dies. So <= 0 can be unreliable or something, I guess.

I think you're mad.

An unit with hp <= 0.405 will die.

 

[Jesus4Lyf]

There's a whole argument about this, because you can change a unit's life after it dies.

Apparently: A unit dies at 0.407, gets its health set to 0 automatically, and then can have it changed with triggers to be anything you like without reviving it.
Conclusion? [LAJSS]IsUnitState(unit,UNIT_STATE_DEAD)[/LJASS] perhaps. But can that state be removed without reviving a unit or something anyway? Who knows.

WC3 is great, can't even figure out a solid way to tell if a unit is dead? XD

 

[Troll-Brain]

library test initializer init

private function init takes nothing returns nothing
    call TriggerSleepAction(1.)
    call SetWidgetLife(CreateUnit(Player(0),'hpea',0.,0.,0.),0.407)
    call SetWidgetLife(CreateUnit(Player(0),'hpea',0.,0.,0.),0.406)
    call SetWidgetLife(CreateUnit(Player(0),'hfoo',0.,0.,0.),0.405)
endfunction

endlibrary

Only the footman dead.

About the solid way :

http://www.hiveworkshop.com/forums/jass-functions-413/isunitdead-135811/

 

[Azlier]

I don't like the way it says, 'can and will cause bugs'. Especially because that isn't true.

 

[Troll-Brain]

Anyway i don't trust that more on real comparison, coz they are floats. I still prefer IsUnitDead.
But it's good to know.

 

[Nestharus]

You do know that IsUnitDead is just a function wrapper BJ right? Unless you're takling about the IsUnitDead snippet : P

 

[Troll-Brain]

The snippet ofc, tell me when and where i've said BJ in this topic ...
But i tend to inline it though, since JassHelper won't inline it for the moment.