Not really....
Why not just have DAMAGE as a direct value? Much more easier to manage.
MEELE? Melee.... also it doesn't really. What effects does having it false do?
--
Aren't you sort of learning yourself? This doesn't really suit Spells section, like said.. too simple. You could post in Jass help for coding feedback.
JASS:
Why not just have DAMAGE as a direct value? Much more easier to manage.
JASS:
private constant boolean IS_MEELE = true //Explains. it. self
MEELE? Melee.... also it doesn't really. What effects does having it false do?
- Make every if that is depending on SHOWDAMAGE a static if. Which in turns means you'll need latest JassHelper. However, it's not being run periodically so meh.
- [ljass]call SetTextTagColor (TT, 90, 0, 110, 255 )[/ljass] - Configurable colours?
- [ljass]90. * bj_DEGTORAD[/ljass] - Possible to convert to a global to save calculations. And while you are there, it can be made into a configurable, the angle of the TextTag.
- Also, is this for when a unit takes damaged or attacked? Because [ljass]EVENT_PLAYER_UNIT_ATTACKED[/ljass] registers on animation attack buildup, not damagepoint, resulting in possible abuses.
- Please, use delimited comments [ljass]/* comment */[/ljass] in your Cons function for the sake of readability. Also another tip, you don't need the [ljass]Filter( function Cons)[/ljass] in the Init function, as JassHelper does that work.
- Also, what if I want to add effects onto 5 spots? You only provide two effect points.
- Texttag life spans should be configurable.
--
But it's good to learn from.
Aren't you sort of learning yourself? This doesn't really suit Spells section, like said.. too simple. You could post in Jass help for coding feedback.