Spell Moving Strikes

[SanKakU]

there's a lot of off topic nonsense going on lately with me. i'm sorry. why don't you give us a review of what went on in this thread since there's so much not about the spell here?

 

[Chaos_Knight]

What? Static Ifs?

 

[killingdyl]

Quick question, little learning experience for me. What does this part do? (explain in details please:thup

call DisableTrigger( GetTriggeringTrigger())
            call UnitDamageTarget( u , t , DMG(GetUnitAbilityLevel(u, ID))  , IS_RANGED , IS_MEELE , AtkType , DmgType , WepType )
            call EnableTrigger( GetTriggeringTrigger())

 

[BlackRose]

Disables the trigger, to prevent recursive damage crap. Since damage is registered, if you damage again, it registers again, making more damage, so forth.

Also, how is this static if offtopic. It's a suggestion to improve your code yet you are dismissing it as offtopic.

 

[Chaos_Knight]

Quick question, little learning experience for me. What does this part do? (explain in details please:thup

call DisableTrigger( GetTriggeringTrigger())
            call UnitDamageTarget( u , t , DMG(GetUnitAbilityLevel(u, ID))  , IS_RANGED , IS_MEELE , AtkType , DmgType , WepType )
            call EnableTrigger( GetTriggeringTrigger())

This does actually just turn off the trigger and turns it on. Because of that fact, it will cause heavy lag if you remove [lJASS]call DisableTrigger(GetTriggeringTrigger())[/lJASS]

Blade told me to do so, so i got no more idea than you actually... :banghead:

 

[Jedi]

Lets see what can happen if you remove those lines:

Event: Target takes damage from SomeOne
Action: Damage Target

You damaged to the target, and that will fire the event again, so trigger will run over and over instantly.If you are lucky, you won't get fatal error at first time

Shortly, you must disable trigger before deal damage.

 

[Chaos_Knight]

What do you think about this, Jedi?

 

[BlackRose]

Also, how is this static if offtopic. It's a suggestion to improve your code yet you are dismissing it as offtopic.

[ljass]static if SHOWEFFECT then[/ljass]

 

[Chaos_Knight]

Should i place static ifs instead of normal Ifs?

 

[Chaos_Knight]

Bump. Ety. Bump.

 

[SanKakU]

Lets see what can happen if you remove those lines:

Event: Target takes damage from SomeOne
Action: Damage Target

You damaged to the target, and that will fire the event again, so trigger will run over and over instantly.If you are lucky, you won't get fatal error at first time

Shortly, you must disable trigger before deal damage.

wow really? heh, heh. that's good to know...

 

[Chaos_Knight]

Bump.
BUMP.
BUMP.
BUMP.
BUMP.
BUMP

 

[Jedi]

set t = null at the end of Init function.

 

[Chaos_Knight]

Should i null [ljass]trigger[/ljass] triggers?

UPDATE: Check it Out!

Enough for Approval?

 

[Laiev]

set t = null at the end of Init function.

you don't need it

 

[Chaos_Knight]

Bump. ._. -.-
_ _ _ _
| I |
|_._._|

 

[Chaos_Knight]

PLEASE SOME CRITISM!

I want a reason that this shouldnt be approved.

 

[BlackRose]

PLEASE SOME CRITISM!

I want a reason that this shouldnt be approved.

IT'S TOO SIMPLE.

This is basically a target-blink-damage.

Anyways:

1) GRAMMAR:

The Blademaster is so quickly with his attack, so he can move incredibly fast behind the target, dealing damage.

I'm not saying you SHOULD copy this but something like:

The Blademaster is adept at the art of swordsmanship, he can quickly move behind a target, dealing additional damage.

Your spell is based on chance, so potentially incorporate the chance factor into the tooltop. This goes against my own saying that spells are a base, people edit them. But nothing else to 'criticise?'

IS_MEELE should be IS_MELEE

2) DAMAGE TEXTTAG:

Convert it to an integer:

35.000 is ugly, people don't need to see decimals. Also, you might want to consider changing the colour for the demo map, purple was hard to read ​

3) STATIC IFS

Alright, all you needed was a:

[ljass]if SHOWEFFECTS/SHOWDAMAGE then[/ljass] to become [ljass]static if SHOWEFFECTS/SHOWDAMAGE then[/ljass]

4) CON[dition]S

• That's unreadable. How can you work with it?
  
  This on the otherhand.
  

      private function Cons takes nothing returns boolean
          return  IsUnitEnemy(GetTriggerUnit() , GetOwningPlayer(GetEventDamageSource()))         and /*
          */      GetRandomInt(0, 100) <= CHANC(GetUnitAbilityLevel(GetEventDamageSource(), ID))  and /*
          */      not IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO)                                and /*
          */      GetUnitAbilityLevel(GetEventDamageSource() , ID) > 0
      endfunction

  
  
• Store [ljass]GetTriggerUnit()[/ljass] and [ljass]GetEventDamageSource()[/ljass] into global unit variables, since they are being called more than once in the function. For effiency.

5) WHAT?

            local real x1 = GetUnitX( u ) /* A Units X Position */
            local real y1 = GetUnitY( u ) /* A Units Y Position */
            local real x2 = GetUnitX( t ) /* A Units X Position */
            local real y2 = GetUnitY( t ) /* A Units Y Position */

• What's the point in using delimited comments?
• What's the point in commenting them in the first place? x1 is obviously caster x, although cx and tx are better names IMO.

6) TEXTTAGS

What if SHOWDAMAGE is false, you are just wasting a texttag, declaring then nulling for nothing. Maybe have TT set to null as default and set TT to null in the if.

[ljass]call SetTextTagVelocity (TT, 0.0355 * Cos(90. * bj_DEGTORAD), 0.0355 * Sin(90. * bj_DEGTORAD))[/ljass]

Seeing as your not gonna set the text tag angle to a configurable [if you are then ignore, remember the fade and duration if you make it a config], just set [ljass]0.03555 * Cos( 90. * bj_DEGTORAD )[/ljass] to the value it calculates to. [ljass]BJDebugMsg()[/ljass] it to find out. Same for [ljass]Sin[/ljass].

7) SPELL GAMEPLAY

I added Chain Lightning onto my Blademaster, order him to cast, and he teleports!

So, say my hero had a landmine spell, a unit steps on it and I'm 25000 range away. Do I teleport into say a group of incoming enemies?

Is this all forms of damage?

I suggest add a range cap and make it your attack that the spell registers.

 

[Chaos_Knight]

I love you.

 

[Laiev]

I'm amazed by their tremendous patience BlackRose