Spell Moving Strikes

[BlackRose]

Not really....

    private constant function DMG takes integer Lvl returns integer
        return DAMAGE * Lvl
    endfunction

Why not just have DAMAGE as a direct value? Much more easier to manage.

        private constant boolean IS_MEELE = true //Explains. it. self

MEELE? Melee.... also it doesn't really. What effects does having it false do?

• Make every if that is depending on SHOWDAMAGE a static if. Which in turns means you'll need latest JassHelper. However, it's not being run periodically so meh.
  
• [ljass]call SetTextTagColor (TT, 90, 0, 110, 255 )[/ljass] - Configurable colours?
  
• [ljass]90. * bj_DEGTORAD[/ljass] - Possible to convert to a global to save calculations. And while you are there, it can be made into a configurable, the angle of the TextTag.
  
• Also, is this for when a unit takes damaged or attacked? Because [ljass]EVENT_PLAYER_UNIT_ATTACKED[/ljass] registers on animation attack buildup, not damagepoint, resulting in possible abuses.
  
• Please, use delimited comments [ljass]/* comment */[/ljass] in your Cons function for the sake of readability. Also another tip, you don't need the [ljass]Filter( function Cons)[/ljass] in the Init function, as JassHelper does that work.
  
• Also, what if I want to add effects onto 5 spots? You only provide two effect points.
  
• Texttag life spans should be configurable.

--

But it's good to learn from.

Aren't you sort of learning yourself? This doesn't really suit Spells section, like said.. too simple. You could post in Jass help for coding feedback.

 

[Chaos_Knight]

Yup..

Are you the negative guy? I really like your ideas about it. But didnt you ever be a new to JASS? Everyone starts somewhere.

Do you think this should be removed?

 

[Laiev]

Blackrose is a nice guy.. he just don't want be another guy to say
"hey, your spells is soooooooo great"

*looking spell*

- move instantly unit to position of unit

 

[SanKakU]

what is a static if?

 

[Chaos_Knight]

- move instantly unit to position of unit

Huum? What?

I will change to globals for the color of the TextTag.
Tell me and i will fix what you want.

 

[Laiev]

what is a static if?

static ifs are like normal ifs, except that a) the condition must contain only constant booleans, the and operator and the not operator and b) They are evaluated during compile time. Which means that the code that is not matched to its condition is simply ignored.

Huum? What?

I will change to globals for the color of the TextTag.
Tell me and i will fix what you want.

Is just a example of some sh1t trigger at internet D: not your... what i mean is...

he's not another guy which will come here and say good job with some code fails

 

[Chaos_Knight]

Now, i got so angry so i created another if, SIX SFXs, A BOOLEAN that should be true if you wanna see the effects.

//Chaos_Knight.

 

[Laiev]

things which you can improve:

    private constant function CHANCE takes integer level returns integer
        return C * level
    endfunction
    
    private constant function DMG takes integer Lvl returns integer
        return DAMAGE * Lvl
    endfunction

just remove it.. and use the variable in the script... when you callback...

this improve a bit the run time of trigger..

i think you got a little problem with global.... like.. to order then

 

[Chaos_Knight]

things which you can improve:

    private constant function CHANCE takes integer level returns integer
        return C * level
    endfunction
    
    private constant function DMG takes integer Lvl returns integer
        return DAMAGE * Lvl
    endfunction

just remove it.. and use the variable in the script... when you callback...

this improve a bit the run time of trigger..

i think you got a little problem with global.... like.. to order then

Huh?

 

[tooltiperror]

Not required, but using GTrigger instead of basic events may help.

Your header is really ugly. You should redo the head.

Also, you need to complicate the spell. Boring and generic spells that just swap people around and do fancy things are really hard to get approved, because they don't require a lot of coding, and are just too simple.

You should just create a new spell more advanced and lock this.

 

[SanKakU]

i don't understand the explanation for static if. can you give some examples? and what are the advantages/disadvantages, if any?

 

[Chaos_Knight]

If nobody like this spell, tell me now.

 

[BlackRose]

i don't understand the explanation for static if. can you give some examples? and what are the advantages/disadvantages, if any?

In a function being run at like every 0.03125, and you have a boolean KILL_TREES for example, if you have say:

static if KILL_TREES then
    // stuff
endif

Everything within the static if will be compiled if KILL_TREES is true, so the if is not run periodically, for efficiency? [Need clarification on if I said right]

--

If nobody like this spell, tell me now.

Don't be discouraged. You'll learn. I made simple spells when I started too.

 

[Laiev]

If nobody like this spell, tell me now.

I don't test it in game... but i assume.. the screenshot is REALLY bad :x

i don't understand the explanation for static if. can you give some examples? and what are the advantages/disadvantages, if any?

BlackRose just explain it

 

[HeX.16]

Tested Ingame
--------------------
- Its to flashy for my tastes.
- Very simple
- I hear BJ's are bad.

 call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_ATTACKED)

 

[Laiev]

Tested Ingame
--------------------
- Its to flashy for my tastes.
- Very simple
- I hear BJ's are bad.

 call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_ATTACKED)

there's no problem with the event bj...

is just a bit¹²³¹²³¹²³²³ more slow then the native... also with this bj is more readable

 

[Chaos_Knight]

It's to flashy for my tastes

That's why i created this

SHOWEFFECTS = true

Just set to false and DONE.

 

[tooltiperror]

If this is 'too' flashy, I suggest you do not browse the spell section.

Sankaku, I'll write on your wall.

 

[Sharp]

It's a simple spell, he's learning it. So guys, don't discourage him.

 

[BlackRose]

- I hear BJ's are bad.

The 'bad BJ's are the ones who just call the native of what they do, usually including the word Swapped function name or something. Eg, the:

function GetUnitAbilityLevelSwapped takes integer abilcode, unit whichUnit returns integer
    return GetUnitAbilityLevel(whichUnit, abilcode)
endfunction

The event BJ is more better looking, and it's called on map init, speed doesn't matter.