Snippet PreventSave

[Nestharus]

Brilliant

 

[Jesus4Lyf]

Will approve if we can get a verify that this works online without desynchs...

Just wanted to bump this point.

 

[Romek]

The fact that the non-constant global which users are meant to modify is in all capitals is indeed misleading.
I also assumed it was a constant simply by the name of it.

 

[Jesus4Lyf]

Actually, same here. Please change.

 

[Narks]

what, change it to constant or change to non-capitals?

I personally think it's fine, if someone really wanted to toggle saving in their map, they probably would look through the code and realise that it is not a constant.

 

[Jesus4Lyf]

>change to non-capitals
That. It's just confusing to read. Standards are the way they are so code is readable and makes sense quickly.

 

[Narks]

does vJASS inline constants?

Like

globals
    constant integer TheGame = 4
endglobals

function YouLost takes nothing returns nothing
    local integer i = TheGame
endfunction

becomes

function YouLost takes nothing returns nothing
    local integer i = 4
endfunction

 

[TriggerHappy]

I don't see what would be the point of inlining that.

It's probably the same speed.

 

[Jesus4Lyf]

    globals
        boolean gameAllowSave = false
    endglobals

Isn't the global variables convention here:

    globals
        boolean GameAllowSave = false
    endglobals

?

 

[TriggerHappy]

From what I've seen, blizzard names their globals like this;

bj_variableName.

 

[Jesus4Lyf]

They also prefix all user variables with udg_, but we don't...
And you're right, for example they have an array named [LJASS]bj_ghoul[/LJASS].
But it is problematic for us, because one-word global variables would take on the same name accidentally as a local variable, so we uppercase the first letter of each word including the first one these days...

For example, if you had to store a unit in a global temporarily for a [LJASS]ForGroup[/LJASS] call, let's say you'd call the unit [LJASS]Unit[/LJASS] or [LJASS]Hero[/LJASS] (or something). Without the convention we use, it would be [LJASS]unit[/LJASS] (which is a type keyword) or [LJASS]hero[/LJASS] (which could conflict with a local variable or parameter). So we don't follow Blizzard's stuff on this one - the reason is we don't follow their udg_ stuff (with which this wouldn't occur...).

 

[Lyerae]

> From what I've seen, blizzard names their globals like this;
bj_variableName.

Yes, that's correct from what I've seen in Blizzard.j

 

[Jesus4Lyf]

Looks fantastic.

Will approve if we can get a verify that this works online without desynchs...

Just noting this again, nothing is stopping this from approval except the question of whether or not it works online without desynching...

 

[black.sheep]

Works, I think... Someone left when I did it thou, but that might be cuz they were a dick.
Shall try again.

Okay, I think it might crash macs, but apart from that it will work.

 

[Jesus4Lyf]

Can we get a check from Weep on that?

 

[Weep]

Works fine in single-player and on BNet (one player), from what I can tell.

 

[Jesus4Lyf]

Good enough!
Approved! :thup:

Great find.

 

[jalisco]

Best library ever.

 

[Slapshot136]

Best library ever.

x2