System Status

[13lade619]

did you remove the Preloading?

i noticed PreloadModule wasnt implemented in the code... it's causing me lag..

I had to manually implement the module myself.. it worked.

<hmm.. BuffStruct not preloading + Status not preloading = lagspike!.>

 

[Jesus4Lyf]

i noticed PreloadModule wasnt implemented in the code... it's causing me lag..

I was wondering why my map spikes... lol xD
Will fix, at some point..

 

[Furby]

Here:

method removeStun takes nothing returns nothing
            set this.stunLevel=this.stunLevel-1
            if this.stunLevel==0 then
                call UnitRemoveAbility(this.unit,BUFF_STUN)
            endif
        endmethod

you should remove ability even if it is lower than 0 not just exactly 0.. because if I want to make unit immune to stuns I would decrease stunLevel by like 100 or so.. and then it would not remove the stun.

you should probably also add some simpler way to edit Levels of these stuff, so I can make unit "immune" to certain stuff.

 

[Viikuna]

Like I said before, it would probably better to have [lJASS]StunUnit(unit,boolean) [/lJASS]and [lJASS]ModifyUnitStunStatus(unit,integer)[/lJASS] functions for this shit.

 

[Furby]

Yeah, Viikuna is right. That would be a way more customizable. But you seems to be a little inactive.

 

[Ghan]

This is pretty awesome. Approved, I say!

 

[13lade619]

I was wondering why my map spikes... lol xD
Will fix, at some point..

i think you shouldve waited for this update before approval Ghan.

 

[Furby]

Furby agrees.

 

[Jesus4Lyf]

i noticed PreloadModule wasnt implemented in the code... it's causing me lag..

I had to manually implement the module myself.. it worked.

Lol, cheers. Fixed..
Never fear, lurking lurker is lurking. :thup:
I've been busy with work and social stuff, but set aside 30 mins tonight to clean up the minor issues with the systems which got approved.

 

[Weep]

Attack/missile reflection...hmm.

I was thinking about that the other day, and it seems like it could cause a heap of trouble with the way a lot of abilities are coded.

The damage will come from the originally-attacked unit. Will buff-placers from the original-attacker be applied to itself when the shot returns? There wouldn't be a good way to determine effect ownership for any on-attack abilities possessed by the original-attacker, or even to determine the presence or level of an ability on the original-attacker. And wouldn't the damage be interpreted by Damage as an attack, as it's non-triggered?

More food for thought.

 

[SanKakU]

can you please provide a wider variety of demonstrations in the original post? just that one small demonstration doesn't seem very interesting...

 

[Jesus4Lyf]

The damage will come from the originally-attacked unit. Will buff-placers from the original-attacker be applied to itself when the shot returns? There wouldn't be a good way to determine effect ownership for any on-attack abilities possessed by the original-attacker, or even to determine the presence or level of an ability on the original-attacker. And wouldn't the damage be interpreted by Damage as an attack, as it's non-triggered?

It'd count as an attack from the targetted unit to the attacker. Which is fine, in my books, in terms of lore or w/e. Besides, this system doesn't inherently need to be "compatible" with Damage (as in have all its features tied together). People should still consider this stuff themself.

>can you please provide a wider variety of demonstrations in the original post?
I guess I'll throw up a BuffStruct example some time. :thup:

 

[13lade619]

question on modMoveSpeedPercentBonus:

Status[unit].modMoveSpeedPercentBonus(50)
<DO STUFF HERE OR WAIT>
Status[unit].modMoveSpeedPercentBonus(-50)

would suffice normally but,
what if another modMoveSpeedPercentBonus is modded in between the wait?
then doing (-50) would set the bonus to be faster/slower than before the (50) was applied..

what's the solution??

Or will the bonuses all nullify when the other modMoveSpeedPercentBonus ends and there's no real problem...
well that situation just bugs me and i cant seem to think clearly now.. lol.

 

[Furby]

It works good, don't worry.

Percents are added just when unit moves.

////////////////////
        // Movement Speed //
        ////////////////////
        
        private real moveSpeedBonus
        private real moveSpeedPercentBonus
        private real x
        private real y
        private static real updateUnitX
        private static real updateUnitY
        private static real xInc
        private static real yInc
        private static real updateDist
        private method periodic takes nothing returns nothing
            set thistype.updateUnit=this.unit
            set thistype.updateUnitX=GetUnitX(thistype.updateUnit)
            set thistype.updateUnitY=GetUnitY(thistype.updateUnit)
            set thistype.xInc=thistype.updateUnitX-this.x
            set thistype.yInc=thistype.updateUnitY-this.y
            set thistype.updateDist=SquareRoot(thistype.xInc*thistype.xInc+thistype.yInc*thistype.yInc)
            if thistype.updateDist>0 then
                if UnitAlive(thistype.updateUnit) and this.disableLevel<=0 and this.stunLevel<=0 and this.pauseLevel<=0 and this.immoboliseLevel<=0 and GetUnitMoveSpeed(thistype.updateUnit)>0 then
                    if this.moveSpeedPercentBonus!=0.0 then
                        set thistype.updateUnitX=thistype.updateUnitX+thistype.xInc*this.moveSpeedPercentBonus
                        set thistype.updateUnitY=thistype.updateUnitY+thistype.yInc*this.moveSpeedPercentBonus
                    endif
                    if this.moveSpeedBonus!=0.0 then
                        set thistype.updateDist=this.moveSpeedBonus/thistype.updateDist
                        set thistype.updateUnitX=thistype.updateUnitX+thistype.xInc*thistype.updateDist
                        set thistype.updateUnitY=thistype.updateUnitY+thistype.yInc*thistype.updateDist
                    endif
                    call SetUnitX(thistype.updateUnit,thistype.updateUnitX)
                    call SetUnitY(thistype.updateUnit,thistype.updateUnitY)
                endif
            endif
            set this.x=thistype.updateUnitX
            set this.y=thistype.updateUnitY
        endmethod
        implement T32xs
        method modMoveSpeedBonus takes real amount returns nothing
            set this.moveSpeedBonus=this.moveSpeedBonus+amount*T32_PERIOD
            if this.moveSpeedBonus==0 and this.moveSpeedPercentBonus==0 then
                call this.stopPeriodic()
            else
                set this.x=GetUnitX(this.unit)
                set this.y=GetUnitY(this.unit)
                call this.startPeriodic()
            endif
        endmethod
        method getMoveSpeedBonus takes nothing returns real
            return this.moveSpeedBonus/T32_PERIOD
        endmethod
        method modMoveSpeedPercentBonus takes real amount returns nothing
            set this.moveSpeedPercentBonus=this.moveSpeedPercentBonus+amount*0.01
            if this.moveSpeedBonus==0 and this.moveSpeedPercentBonus==0 then
                call this.stopPeriodic()
            else
                set this.x=GetUnitX(this.unit)
                set this.y=GetUnitY(this.unit)
                call this.startPeriodic()
            endif
        endmethod
        method getMoveSpeedPercentBonus takes nothing returns real
            return this.moveSpeedPercentBonus/0.01
        endmethod

 

[Jesus4Lyf]

question on modMoveSpeedPercentBonus:

Status[unit].modMoveSpeedPercentBonus(50)
<DO STUFF HERE OR WAIT>
Status[unit].modMoveSpeedPercentBonus(-50)

would suffice normally but,
what if another modMoveSpeedPercentBonus is modded in between the wait?
then doing (-50) would set the bonus to be faster/slower than before the (50) was applied..

what's the solution??

Or will the bonuses all nullify when the other modMoveSpeedPercentBonus ends and there's no real problem...
well that situation just bugs me and i cant seem to think clearly now.. lol.

With this system, if you add +50% and then add +20%, the unit will then have +70%. They stack additively, not multiplicatively. :thup:

 

[13lade619]

So it's additively... GREAT. thanks. (you didnt mention that anywhere, and i cant understand the monster sized code )

 

[hgkjfhfdsj]

Syntax Error
removeAlwaysMiss is not a member of Status

// Always Miss
        private integer alwaysMissLevel
        method addAlwaysMiss takes nothing returns nothing
            set this.alwaysMissLevel=this.alwaysMissLevel+1
            if this.alwaysMissLevel>0 then
                call UnitAddAbility(this.unit,ABIL_ALWAYS_MISS)
                call UnitMakeAbilityPermanent(this.unit,true,ABIL_ALWAYS_MISS)
            endif
        endmethod
        method AlwaysNeverMiss takes nothing returns nothing // <------<
            set this.alwaysMissLevel=this.alwaysMissLevel-1
            if this.alwaysMissLevel==0 then
                call UnitMakeAbilityPermanent(this.unit,false,ABIL_ALWAYS_MISS)
                call UnitRemoveAbility(this.unit,ABIL_ALWAYS_MISS)
            endif
        endmethod
        method isAlwaysMiss takes nothing returns boolean
            return this.alwaysMissLevel>0
        endmethod

 

[Jesus4Lyf]

Hey... well spotted. Thanks.
Release Version 1.3.0 with that fixed. :thup: +Rep.

 

[SanKakU]

[ljass]// You should use your favourite timer system instead of TriggerSleepAction.[/ljass]
>that's fine but doesn't the code structure change completely when you do that? lol

Actually, I think multiple attacks is not really the way to go. It should be some fake attack system, which allows user do for example spells like Omnislash in DotA.

hmm...i'm not sure i agree. isn't what he trying to accomplish with double attack kindof like what they had in final fantasy?

if the point of this system is to simulate rpg stuff, then it sounds cool to me.

edit: hmm...i think i figured out how to use the system. i guess i'll read more into it to see if i can discover how you did all that.

        // This is because deep down I love GUI and all the trouble it causes.
        call BJDebugMsg("Stunning everything for 5 seconds.")
        call ForGroupBJ(GetUnitsInRectAll(GetPlayableMapRect()),function Action)
        call TriggerSleepAction(5.0)
        call BJDebugMsg("5 seconds has passed.")

yeah, you do love that adorably moronic BJDebugMsg which MSGS replaces.
lol...i was like...5 seconds has passed. oh, really? it's been more like 30! and all the way up to 55...

anyway, this looks like a really cool system.

hmm....uses DummyCaster...

is that the same system you wrote that uses a single caster? i suppose these systems were designed for eachother?
isn't the point of the two of these for the sake of creeps' spells? am i right about this assumption?

edit: OH THIS WAS THE ONE THAT HAD SOME WEIRD OBJECT MERGER STUFF THAT I DIDN'T UNDERSTAND!

"Usually with stuns you want to add effects when they begin and remove then when they end, or use them in unit sliding effects which may end abruptly if it hits a wall or something. For this reason (and the freedom of choice for timer system) I have not made a timed stun system, merely a stun system. I think this is the API that mappers truly need, rather than someone that tries to do too much for you."
>yeah, i guess that's pretty cool.

QUESTION!

debug if this.attackSpeedBonus>=thistype.twoPow[LEVELS_ATTACK_SPEED] then
                debug call BJDebugMsg("Status Error: Status["+GetUnitName(this.unit)+"].modAttackSpeedBonus("+I2S(amount)+") - must not reach >= "+I2S(thistype.twoPow[LEVELS_ATTACK_SPEED])+".")

what's this debug if and debug call? i think i heard of something somewhere about debug mode being on or off...is that what this is about? i don't know anything about that...can you please explain?

 

[Jesus4Lyf]

DummyCaster is about creating casting dummy spells for use in any spells, not just creep spells.

>what's this debug if and debug call? i think i heard of something somewhere about debug mode being on or off...is that what this is about? i don't know anything about that...can you please explain?

[LJASS]debug[/LJASS] lines disappear when debug mode is turned off, in your JassHelper settings in the NewGen editor. Their purpose is to help with debugging. For example, if you misuse a function, you would like an error to display while you're editing, but if that somehow occurs after map release, you want the editor to be hidden. Hence, debug mode.

The purpose of this system is not strictly anything to do with RPGs:

//      What is Status?
//     ¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
//          Status allows you to apply stuns, silences, disable attacks and much
//          more. Status effects based off dummy casted spells are applied 0.0
//          seconds after the "add" method is called. Status aims to commoditise
//          unit effects in WC3.

The point is handling status effects in WC3.
This and BuffStruct are a match made in heaven, although completely separate and functional independently.