1.24 patch causes my spells make wc3 not load

Red_drake · Aug 6, 2009

so basically, after patch 1.24, i had to sift through my map and remove all the retun bugs (which i did) but its still not loading (like im still using the return bug(which im not)) and then i read somewhere about if/elseif blocks causing wc3 to think im using the return bug... so i isolated the triggers that are causing it to not load... so i disabled the triggers, the map loads fine, and then when i re-enable the triggers, the map doesnt load (like im using the bug)... now 4/6 of the spells dont use *anything* fancy, just a basic unit casts spell. do simple effects (the other two use TimerUtils, but i fixed that to use GetHandleId(h) instead of the return bug)... but for some reason its still not loading (i disabled the condition, cause i thought something might be messed up with the condition's return, but its not that, i also removed the filter cause it uses if/elseif blocks, but its not that either)

so, after my long explanation, here are my spells, if anyone could *please* help me, i really would rather be able to actually finish this map...

EDIT: so only stalker and blood for the blood god dont work now

EDIT2: so everything is fixed, i set booleans isntead of returninig, and put the single spells without filters into scopes and made the gobals private, and everything works... this thread can be closed now.

JASS:

globals
    integer i
endglobals

function Trig_Stalker_Conditions takes nothing returns boolean
    return GetUnitAbilityLevel(GetTriggerUnit(), &#039;A04P&#039;) &gt; 0
endfunction
    
struct stalker
    unit u
endstruct

function stalker_filter takes nothing returns nothing
    if GetDestructableTypeId(GetEnumDestructable()) == &#039;JTtw&#039; then
        set i = i+1
    endif
endfunction

function stalker_timer takes nothing returns nothing 
    local location l 
    local stalker d = GetTimerData(GetExpiredTimer())
    
    set i = 0
    set l = GetUnitLoc(d.u)
    call LoreEnumDestructablesInRangeOfLoc(l, 350, function stalker_filter)
    
    if i &gt; 0 then
        if GetUnitAbilityLevel(d.u, &#039;A04U&#039;) == 0 then
            call UnitAddAbility(d.u, &#039;A04W&#039;)
        endif
        call SetUnitAbilityLevel(d.u, &#039;A04U&#039;, GetUnitAbilityLevel(d.u, &#039;A04P&#039;))
        call SetUnitAbilityLevel(d.u, &#039;A04V&#039;, GetUnitAbilityLevel(d.u, &#039;A04P&#039;))
    else
        call UnitRemoveAbility(d.u, &#039;A04W&#039;)
    endif
    
    call RemoveLocation(l)
    set l = null
endfunction

function Trig_Stalker_Actions takes nothing returns nothing
    local timer t = NewTimer()
    local stalker d = stalker.create()
    
    set d.u = GetTriggerUnit()
    
    call SetTimerData(t, d)
    call TimerStart(t, 1, true, function stalker_timer)
endfunction

//===========================================================================
function InitTrig_Stalker takes nothing returns nothing
    set gg_trg_Stalker = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Stalker, GetWorldBounds())
    call TriggerAddCondition( gg_trg_Stalker, Condition( function Trig_Stalker_Conditions ) )
    call TriggerAddAction( gg_trg_Stalker, function Trig_Stalker_Actions )
endfunction

JASS:

function Trig_the_shrouding_Conditions takes nothing returns boolean
    return GetUnitAbilityLevel(GetTriggerUnit(), &#039;A06A&#039;) &gt; 0
endfunction

struct shrouding
    unit u
endstruct

function shrouding_filter takes nothing returns boolean
    if IsUnitType(GetFilterUnit(), UNIT_TYPE_MECHANICAL) then
        return false
    elseif IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) then
        return false
    elseif IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) then
        return false
    endif
    
    return true
endfunction

function shrouding_timer takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local shrouding d = GetTimerData(t)
    local unit u = d.u
    local location l = GetUnitLoc(u)
    local group g = CreateGroup()
    local unit n
    local unit i
 
     if IsUnitType(d.u, UNIT_TYPE_DEAD) == false then
        call GroupEnumUnitsInRangeOfLoc(g, l, 800, Condition(function shrouding_filter))    
        loop
            set n = FirstOfGroup(g)
            call GroupRemoveUnit(g, n)
            exitwhen n == null
            
            if IsUnitEnemy(n, GetOwningPlayer(u)) then 
                set i = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h000&#039;, l, 270)
                call UnitAddAbility(i, &#039;A080&#039;)
                call SetUnitAbilityLevel(i, &#039;A080&#039;, GetUnitAbilityLevel(u, &#039;A06A&#039;))
                call IssueTargetOrder(i, &quot;curse&quot;, n)
                call UnitApplyTimedLife(i, &#039;BTLF&#039;, 2)
            endif        
        endloop
    endif

    call d.destroy()
    call DestroyGroup(g)
    call RemoveLocation(l)
    set g = null
    set l = null
    set u = null
    set n = null
    set i = null
endfunction

function Trig_the_shrouding_Actions takes nothing returns nothing
    local timer t = NewTimer()
    local shrouding d = shrouding.create()
    
    set d.u = GetTriggerUnit()
    call SetTimerData(t, d)
    call TimerStart(t, 1, true, function shrouding_timer)
    
    call d.destroy()
endfunction

//===========================================================================
function InitTrig_the_shrouding takes nothing returns nothing
    set gg_trg_the_shrouding = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_the_shrouding, GetWorldBounds())
    call TriggerAddCondition( gg_trg_the_shrouding, Condition( function Trig_the_shrouding_Conditions ) )
    call TriggerAddAction( gg_trg_the_shrouding, function Trig_the_shrouding_Actions )
endfunction

JASS:

function Trig_nemasis_active_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == &#039;A06C&#039;
endfunction

function Trig_nemasis_active_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local unit n
    local unit i = GetSpellTargetUnit()
    local unit t
    local location l = GetUnitLoc(u)
            
    set n = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h000&#039;, l, 270)
    call UnitAddAbility(n, &#039;A06K&#039;)
    call IssueTargetOrder(n, &quot;spiritlink&quot;, u)
    call UnitApplyTimedLife(n, &#039;BTLF&#039;, 2)
    
    set t = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h000&#039;, l, 270)
    call UnitAddAbility(t, &#039;A075&#039;)
    call IssueTargetOrder(t, &quot;thunderbolt&quot;, i)
    call UnitApplyTimedLife(t, &#039;BTLF&#039;, 2)
    
    call UnitAddAbility(u, &#039;A06M&#039;)    
    call SetUnitAbilityLevel(u, &#039;A06J&#039;, GetUnitAbilityLevel(u, &#039;A06C&#039;))
    
    call IssueTargetOrder(u, &quot;attack&quot;, i)
    
    call RemoveLocation(l)
    set l = null
    set u = null
    set n = null
    set i = null
    set t = null
endfunction

function StartNemasis takes nothing returns nothing
    set gg_trg_nemasis_active = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_nemasis_active, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_nemasis_active, Condition( function Trig_nemasis_active_Conditions ) )
    call TriggerAddAction( gg_trg_nemasis_active, function Trig_nemasis_active_Actions )
endfunction

//===========================================================================
function InitTrig_nemasis_active takes nothing returns nothing
endfunction

JASS:


function Trig_ardent_blade_cast_Conditions takes nothing returns boolean
    return true
endfunction

function blade_filter takes nothing returns boolean
    if IsUnitType(GetFilterUnit(), UNIT_TYPE_MECHANICAL) then
        return false
    elseif IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) then
        return false
    elseif IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) then
        return false
    endif
    
    return true
endfunction

function Trig_ardent_blade_cast_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local unit n
    local unit i
    local location l = GetUnitLoc(u)
    local group g = CreateGroup()
    
    call SetUnitTimeScale(u, .5) 
    call SetUnitAnimation(u, &quot;attack&quot;)
    
    call GroupEnumUnitsInRangeOfLoc(g, l, 700, Condition(function blade_filter))
    loop
        set n = FirstOfGroup(g)
        call GroupRemoveUnit(g, n)
        exitwhen n == null
            
        if AngleBetweenUnits(n, u)+180 &gt; (GetUnitFacing(u)-45) and AngleBetweenUnits(n, u)+180 &lt; (GetUnitFacing(u)+45) and IsUnitAlly(n, GetOwningPlayer(u)) == false then
            set i = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h01E&#039;, l, 270)
            call SetUnitAbilityLevel(i, &#039;A09N&#039;, GetUnitAbilityLevel(u, &#039;A09J&#039;))
            call IssueTargetOrder(i, &quot;attack&quot;, n)
            call UnitApplyTimedLife(i, &#039;BTLF&#039;, 1)
        endif
    endloop
    
    call SetUnitTimeScale(u, 1)    
    
    call RemoveLocation(l)
    call DestroyGroup(g)
    set l = null
    set g = null
    set u = null
    set n = null
    set i = null
endfunction

function StartArdentCast takes nothing returns nothing
    set gg_trg_ardent_blade_cast = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_ardent_blade_cast, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_ardent_blade_cast, Condition( function Trig_ardent_blade_cast_Conditions ) )
    call TriggerAddAction( gg_trg_ardent_blade_cast, function Trig_ardent_blade_cast_Actions )
endfunction

//===========================================================================
function InitTrig_ardent_blade_cast takes nothing returns nothing
endfunction

JASS:

function Trig_UnstableInjection_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == &#039;A00O&#039;
endfunction

function Trig_UnstableInjection_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local unit n = GetSpellTargetUnit()
    local location l = GetUnitLoc(n)
    local unit i
    local real r = GetUnitState(n, UNIT_STATE_LIFE)
    
    if IsUnitAlly(n, GetOwningPlayer(u)) == true then
        call SetUnitState(n, UNIT_STATE_LIFE, r + (75 + 50*GetUnitAbilityLevel(u, &#039;A00O&#039;)) )
        
        set i = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h000&#039;, l, 270)
        call UnitAddAbility(i, &#039;A00Q&#039;)
        call SetUnitAbilityLevel(i, &#039;A00Q&#039;, GetUnitAbilityLevel(u, &#039;A00O&#039;))
        call IssueTargetOrder(i, &quot;bloodlust&quot;, n)
        call UnitApplyTimedLife(i, &#039;BTFL&#039;, 2)
        
    else
        call UnitDamageTarget(u, n, (75 + 50*GetUnitAbilityLevel(u, &#039;A00O&#039;)), true, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_FIRE, WEAPON_TYPE_WHOKNOWS)
        
        set i = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h000&#039;, l, 270)
        call UnitAddAbility(i, &#039;A00P&#039;)
        call SetUnitAbilityLevel(i, &#039;A00P&#039;, GetUnitAbilityLevel(u, &#039;A00O&#039;))
        call IssueTargetOrder(i, &quot;slow&quot;, n)
        call UnitApplyTimedLife(i, &#039;BTFL&#039;, 2)
    endif
    
    call RemoveLocation(l)
    set u = null
    set n = null
    set i = null    
endfunction

function StartInjection takes nothing returns nothing
    set gg_trg_UnstableInjection = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_UnstableInjection, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_UnstableInjection, Condition( function Trig_UnstableInjection_Conditions ) )
    call TriggerAddAction( gg_trg_UnstableInjection, function Trig_UnstableInjection_Actions )
endfunction

//===========================================================================
function InitTrig_UnstableInjection takes nothing returns nothing
endfunction

JASS:

globals
    integer level = 0
endglobals

function Trig_Blood_for_the_Blood_God_Conditions takes nothing returns boolean
    return GetUnitAbilityLevel(GetKillingUnit(), &#039;A03O&#039;) &gt; 0
endfunction

function Trig_Blood_for_the_Blood_God_Actions takes nothing returns nothing
    local unit u = GetKillingUnit()
    local unit n
    local location l = GetUnitLoc(u)
    
    set n = CreateUnitAtLoc(GetOwningPlayer(u), &#039;h000&#039;, l, 270)
    call UnitAddAbility(n, &#039;A03Q&#039;)
    
    if IsUnitType(GetTriggerUnit(), UNIT_TYPE_HERO) then
        set level = 5 + 5*GetUnitAbilityLevel(u, &#039;A03O&#039;)
    elseif GetUnitAbilityLevel(u, &#039;B015&#039;) == 0 then
        set level = 1
    else
        set level = level + 1
        if level &gt; 5 + 5*GetUnitAbilityLevel(u, &#039;A03O&#039;) then
            set level = 5 + 5*GetUnitAbilityLevel(u, &#039;A03O&#039;)
        endif
    endif
    
    call SetUnitAbilityLevel(n, &#039;A03Q&#039;, level)        
    call IssueImmediateOrder(n, &quot;roar&quot;)
    call UnitApplyTimedLife(n, &#039;BTLF&#039;, 2)
    
    call RemoveLocation(l)
    set u = null
    set n = null
    set l = null
endfunction

function StartBloodGod takes nothing returns nothing
    set gg_trg_Blood_for_the_Blood_God = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Blood_for_the_Blood_God, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition( gg_trg_Blood_for_the_Blood_God, Condition( function Trig_Blood_for_the_Blood_God_Conditions ) )
    call TriggerAddAction( gg_trg_Blood_for_the_Blood_God, function Trig_Blood_for_the_Blood_God_Actions )
endfunction

//===========================================================================
function InitTrig_Blood_for_the_Blood_God takes nothing returns nothing
endfunction

Komaqtion · Aug 6, 2009

Well, the only thing I know about the new patch is that you can't use elseif, so:

JASS:

function shrouding_filter takes nothing returns boolean
    if IsUnitType(GetFilterUnit(), UNIT_TYPE_MECHANICAL) then
        return false
    elseif IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) then
        return false
    elseif IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) then
        return false
    endif
    
    return true
endfunction

Has to be:

JASS:

function shrouding_filter takes nothing returns boolean
    if IsUnitType(GetFilterUnit(), UNIT_TYPE_MECHANICAL) then
        return false
    endif
    if IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) then
        return false
    endif
    if IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) then
        return false
    endif
    
    return true
endfunction

Or you could simple do this:

JASS:

<div class="bbCodeBlock bbCodeBlock--screenLimited bbCodeBlock--code"><div class="bbCodeBlock-title">JASS:</div><div class="bbCodeBlock-content"><pre class="bbCodeCode"><code class="jass"><span class="keyword">function</span> <span>shrouding_filter</span> <span class="keyword">takes</span> <a href="http://wiki.thehelper.net/wc3/jass/common.j/nothing" class="type">nothing</a> <span class="keyword">returns</span> <a href="http://wiki.thehelper.net/wc3/jass/common.j/boolean" class="type">boolean</a>
    <span class="keyword">return</span> <span class="symbol">(</span><span class="keyword">not</span> <span class="symbol">(</span><a href="http://wiki.thehelper.net/wc3/jass/common.j/IsUnitType" class="native">IsUnitType</a><span class="symbol">(</span><a href="http://wiki.thehelper.net/wc3/jass/common.j/GetFilterUnit" class="native">GetFilterUnit</a><span class="symbol">(</span><span class="symbol">)</span><span class="symbol">,</span> <a href="http://wiki.thehelper.net/wc3/UNIT_TYPE_MECHANICAL" class="variable">UNIT_TYPE_MECHANICAL</a><span class="symbol">)</span><span class="symbol">)</span><span class="symbol">)</span> <span class="keyword">or</span> <span class="symbol">(</span><span class="keyword">not</span> <span class="symbol">(</span><a href="http://wiki.thehelper.net/wc3/jass/common.j/IsUnitType" class="native">IsUnitType</a><span class="symbol">(</span><a href="http://wiki.thehelper.net/wc3/jass/common.j/GetFilterUnit" class="native">GetFilterUnit</a><span class="symbol">(</span><span class="symbol">)</span><span class="symbol">,</span> <a href="http://wiki.thehelper.net/wc3/UNIT_TYPE_STRUCTURE" class="variable">UNIT_TYPE_STRUCTURE</a><span class="symbol">)</span><span class="symbol">)</span><span class="symbol">)</span> <span class="keyword">or</span> <span class="symbol">(</span><span class="keyword">not</span> <span class="symbol">(</span><a href="http://wiki.thehelper.net/wc3/jass/common.j/IsUnitType" class="native">IsUnitType</a><span class="symbol">(</span><a href="http://wiki.thehelper.net/wc3/jass/common.j/GetFilterUnit" class="native">GetFilterUnit</a><span class="symbol">(</span><span class="symbol">)</span><span class="symbol">,</span> <a href="http://wiki.thehelper.net/wc3/UNIT_TYPE_DEAD" class="variable">UNIT_TYPE_DEAD</a><span class="symbol">)</span><span class="symbol">)</span><span class="symbol">)</span>
<span class="keyword">endfunction</span></code></pre></div></div>

UndeadDragon · Aug 6, 2009

Why the hell did Blizzard stop you using elseif??

Elseif is an important conditional statement.

Red_drake · Aug 6, 2009

well, i thought that would be a problem too, but there are triggers that dont use elseifs at all, and still bug

darkreapers · Aug 6, 2009

have you also checked any systems you may have in your map, e.g timer ultis ect ect. those systems would need to be updated as well

jwallstone · Aug 6, 2009

It has nothing to do with elseif. There is nothing wrong with using it. It has everything to do with how you use the "return" statement. It's safest to just use it at the end of the function.

waaaks! · Aug 6, 2009

jwallstone said:
It has nothing to do with elseif. There is nothing wrong with using it. It has everything to do with how you use the "return" statement. It's safest to just use it at the end of the function.

agreed

its still about the return bug, they say they have fixed the return bug, but people still found a way to use return bug, and with that, lots of if/else/elseif blocks with returns turned out to be bugged

R 3 T R O · Aug 6, 2009

Uhm are you guys sure you cant use the elseif becaouse im using it and i can still host the map properly xD

Chocobo · Aug 7, 2009

R 3 T R O said:
Uhm are you guys sure you cant use the elseif becaouse im using it and i can still host the map properly xD

"elseif return <blahblah>"

is not supposed to work anymore

"elseif <some actions>" works

Rainther · Aug 7, 2009

JASS:

function returnish takes noting returns boolean
local boolean returner
if &lt;statement&gt; then
set returner = false
elseif &lt;statement2&gt; then
set returner = true
endif
return returner

Works, rite? Anybuddy got a good method to search and replace elseif returners in ones map? Cause I have like 40 seperate triggers

Igor_Z · Aug 7, 2009

Does some 1 know something about GUI? I want to know should I update to the 1.24 patch or not. Reply plz

Chocobo · Aug 7, 2009

Igor_Z said:
Does some 1 know something about GUI? I want to know should I update to the 1.24 patch or not. Reply plz

GUI only can't do elseif return or H2I return bug so it's safe.

JASS:

function returnish takes noting returns boolean
local boolean returner
if &lt;statement&gt; then
set returner = false
elseif &lt;statement2&gt; then
set returner = true
endif
return returner

should work

but another way of doing this would be :

JASS:

function returnish takes noting returns boolean
return (&lt;statement2&gt; and not &lt;statement&gt;)

Rainther · Aug 7, 2009

Of course, but if I'm creating a dummy for instance I want to do more then returning a value. I want to create unit, etc.

And is there any efficient way to search and find where I use elseif and return?

Chocobo · Aug 7, 2009

Rainther said:
Of course, but if I'm creating a dummy for instance I want to do more then returning a value. I want to create unit, etc.

And is there any efficient way to search and find where I use elseif and return?

search for : "elseif return" and fix them one by one until you find no more of them

JASS:

function blabla takes nothing returns boolean
    if &lt;blabla&gt; then
        return false //ok
    elseif &lt;blabla&gt; then
        return false //NOT ok
    elseif &lt;blabla then
        call PolledWait(2.0) //ok
    endif
    return true
endfunction

Rainther · Aug 7, 2009

NVM, these 2 seems to have been triffling with my map.

This is taken from TimerUtils:

JASS:

    function ReleaseTimer takes timer t returns nothing
        if(t==null) then
            debug call BJDebugMsg(&quot;Warning: attempt to release a null timer&quot;)
            return
        endif
        if (tN==8191) then
            debug call BJDebugMsg(&quot;Warning: Timer stack is full, destroying timer!!&quot;)

            //stack is full, the map already has much more troubles than the chance of bug
            call DestroyTimer(t)
        else
            call PauseTimer(t)
            if(GetTimerData(t)==HELD) then
                debug call BJDebugMsg(&quot;Warning: ReleaseTimer: Double free!&quot;)
                return //I&#039;m talking about this thingie here
            endif
            call SetTimerData(t,HELD)
            set tT[tN]=t
            set tN=tN+1
        endif    
    endfunction

Does this mess anything up?
And while at it:

JASS:

function GetHandleHandle takes handle subject, string name returns handle
    return GetStoredInteger(LocalVars(), I2S(GetHandleId(subject)), name)
    return null
endfunction

Does this count as the return bug?

Uszi · Aug 7, 2009

Igor_Z said:
Does some 1 know something about GUI? I want to know should I update to the 1.24 patch or not. Reply plz

If he maps are GUI they still work.

1.24 patch causes my spells make wc3 not load

Red_drake

New Member

Komaqtion

You can change this now in User CP.

UndeadDragon

Super Moderator

Red_drake

New Member

darkreapers

New Member

jwallstone

New Member

waaaks!

Zinctified

R 3 T R O

New Member

Chocobo

White-Flower

Rainther

I guess I should write something of value here...

Igor_Z

You can change this now in User CP.

Chocobo

White-Flower

Rainther

I guess I should write something of value here...

Chocobo

White-Flower

Rainther

I guess I should write something of value here...

Uszi

New Member

Settings Notifications

Options

The Helper Discord

Members online

Share this page

Affiliates

Network Sponsors

1.24 patch causes my spells make wc3 not load

New Member

You can change this now in User CP.

Super Moderator

New Member

New Member

New Member

Zinctified

New Member

White-Flower

I guess I should write something of value here...

You can change this now in User CP.

White-Flower

I guess I should write something of value here...

White-Flower

I guess I should write something of value here...

New Member

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors